Commit graph

1598 commits

Author SHA1 Message Date
Matt Rogers
fddcc1d8a5
Remove support for IE7 and IE8 2020-03-14 09:45:43 -05:00
Matt Rogers
c2a882ceac
Merge pull request #2301 from ZeiP/feature/#2072_tag_sanitize
#2072: Remove needless sanitisation of tags. The sanitised version is…
2020-01-03 11:54:05 -06:00
Matt Rogers
b01f027d8d
Merge pull request #2302 from jyruzicka/fix-2220
#2220: Use @original_item over other @original_item like instance variables
2019-12-22 10:14:17 -06:00
Jan-Yves Ruzicka
4ea94152c4 Remove @original_item_due_id
Remove one last @original_item_due_id from app/views/todos/destroy.js.erb
2019-12-22 12:33:02 +13:00
Matt Rogers
7eb5f43a7f
Restyle the new multiple todos form as well 2019-12-07 09:05:17 -06:00
Matt Rogers
40e3aa298c
Restyle the new todo form
This makes use of bootstrap and provides more space for the individual
fields to use.
2019-12-07 08:55:50 -06:00
Matt Rogers
3f095eb675
Allow bootstrap based styling to be used in on this form 2019-11-26 15:27:57 -06:00
Matt Rogers
eb5c2484a9
Remove a useless variable assignment
We can shortcut the assignment that was in the partial by naming the
object directly.
2019-11-26 15:27:19 -06:00
Jan-Yves Ruzicka
c66ce02cb6 Refactor todos_controller and todos_helper to use @original_item
Project uses properties of @original_item over a number of similar-named
variables (eg. @original_item_description, @original_item_was_pending, etc.)

Have left in @original_item_due_date and @original_completed_period as these
are more complex, and not simply properties of the todo item.
2019-11-17 16:03:40 +13:00
Jyri-Petteri Paloposki
e0aa0ac69e #2072: Remove needless sanitisation of tags. The sanitised version is only used in DB queries, which handle escaping themselves; the actual UI XSS sanitisation is handled separately. 2019-11-14 02:16:59 +02:00
Jyri-Petteri Paloposki
f7bad05dad Merge remote-tracking branch 'origin/master' into bug/#2259_charts_quality 2019-11-13 13:58:26 +02:00
Matt Rogers
3ac8702a5e
Merge pull request #2255 from ZeiP/feature/#1955_user_tags
#1955: Migrate tags to belong to named users for enhanced privacy.
2019-08-02 09:38:52 -05:00
Jyri-Petteri Paloposki
0cfa0e65f2 #2242: Fix the JS procedure run on add form submission by changing the context ID to the new format. 2019-06-28 13:53:24 +03:00
Jyri-Petteri Paloposki
e92b22ea30 #2259: Use a Chartjs-ror version with airblade/chartjs-ror#57 applied. Adds a container around each chart allowing to enable responsivity and get a less fuzzy chart. 2019-06-28 00:31:00 +03:00
Jyri-Petteri Paloposki
f6d1f243c5 #1955: Use existing user parameter in taggable models instead of passing it 2019-06-26 00:19:32 +03:00
Jyri-Petteri Paloposki
5394973346 #1955: Migrate tags to belong to named users for enhanced privacy. 2019-06-25 11:37:34 +03:00
Matt Rogers
7026737bf8
Merge pull request #2238 from ZeiP/bug/1898_default_context_tag_for_project
#1898: Fix setting the project's default context and tag in the new a…
2019-06-13 18:57:45 -05:00
Matt Rogers
ece584c3f6
Merge pull request #2235 from ZeiP/preferences_fixes
Fix the preferences form: Labels' for attributes, boolean fields and …
2019-06-13 18:57:03 -05:00
Jyri-Petteri Paloposki
e66511c34e #2249: Add space between sentences 2019-06-10 20:43:00 +03:00
Jyri-Petteri Paloposki
7bb8efce16 #2243: Reduce footer z-index to avoid it disabling part of the new action form 2019-06-10 13:16:48 +03:00
Jyri-Petteri Paloposki
6ad1e2cf93
Merge pull request #2231 from ZeiP/bug/1153_stats
Change the Flash charts to Charts.js
2019-05-29 19:33:57 +03:00
Jyri-Petteri Paloposki
2f0ceb9385 #1898: Fix setting the project's default context and tag in the new action form 2019-05-23 03:28:30 +03:00
Jyri-Petteri Paloposki
2bda716ceb
Merge pull request #2076 from C-Otto/fix-2048
also update project name in multiple-actions mode
2019-05-23 01:10:35 +03:00
Jyri-Petteri Paloposki
dad7fdf006
Merge pull request #2055 from scriptythekid/master
make drag&drop todos from/to contexts work again  - fix #2054
2019-05-22 22:46:51 +03:00
Jyri-Petteri Paloposki
0df6f19726 Fixed bug causing context change to hidden returning a server error 2019-05-22 16:09:46 +03:00
Jyri-Petteri Paloposki
22530a6b80 Fix the preferences form: Labels' for attributes, boolean fields and autofill of the new password field 2019-05-22 03:36:27 +03:00
Jyri-Petteri Paloposki
dc0ca7239a
Merge branch 'master' into bug/1153_stats 2019-05-22 01:48:37 +03:00
Jyri-Petteri Paloposki
359f615bf7 Remove unnecessary string manipulation 2019-05-22 01:31:26 +03:00
Jyri-Petteri Paloposki
1e0f1bd611 Change context element IDs to use underscore instead of just the c prefix 2019-05-22 01:28:50 +03:00
Jyri-Petteri Paloposki
644cf0d9e7 Fix the syntax 2019-05-21 22:33:21 +03:00
Jyri-Petteri Paloposki
7fc1f1bf9f
Update app/models/todos/undone_todos_query.rb
Co-Authored-By: Matt Rogers <mattr-@github.com>
2019-05-21 22:28:37 +03:00
Jyri-Petteri Paloposki
d784b1a5eb #1929: Fix the actions query breaking when querying actions with a non-existent tag 2019-05-21 15:17:50 +03:00
Jyri-Petteri Paloposki
ccb5e1e2f1 Remove the decomissioned chart view from the selection display listing 2019-05-20 01:39:39 +03:00
Jyri-Petteri Paloposki
80aad1b4f2 #1153: Remove unnecessary type change and test for stats chart templates and endpoints which were removed 2019-05-20 01:12:25 +03:00
Jyri-Petteri Paloposki
458d46da9e #1153: Remove debug output 2019-05-19 18:46:02 +03:00
Jyri-Petteri Paloposki
313e6ee106 #1153: Remove resolved TODO comment 2019-05-19 18:42:56 +03:00
Jyri-Petteri Paloposki
b7320a1de8 #1153: Perhaps the final deletion of the old Flash charts code 2019-05-19 18:40:23 +03:00
Jyri-Petteri Paloposki
61ed4c33f3 #1153: Remove the last of Flash charts 2019-05-19 18:31:04 +03:00
Jyri-Petteri Paloposki
b040dfce51 #1153: Final checks against the old code, fixed the last mistakes 2019-05-19 17:39:38 +03:00
Jyri-Petteri Paloposki
f9370a9a4a #1153: Fix whitespace issues caused by Vim misconfiguration 2019-05-19 16:51:26 +03:00
Jyri-Petteri Paloposki
0b326e17d8 #1153: Use translations properly, add missing labels, fix bugs and add links to charts 2019-05-19 16:40:00 +03:00
Jyri-Petteri Paloposki
0a106aac5e #1153: Remove unnecessary Flash-stats related templates 2019-05-19 13:26:09 +03:00
Jyri-Petteri Paloposki
f873a93eb3 #1153: Convert rest of the stats to use ChartJS 2019-05-19 13:04:33 +03:00
Jyri-Petteri Paloposki
dec82fd26c #1153: Change to using Chart.js with a basic RoR library instead of Chartkick because Chartkick doesn't support combo charts. 2019-05-17 22:49:21 +03:00
Jyri-Petteri Paloposki
c9cae9421a #1153: Few of the graphs converted to use Chartkick 2019-05-17 22:49:21 +03:00
Steven R. Baker
1461a3a10c The actual link should be URI escaped, not HTML escaped. 2019-05-13 18:59:39 +02:00
Matt Rogers
8bf0627d41
Merge pull request #2210 from ZeiP/bug/2032_api_filters
#2032: Use context and project filters in API also when not requestin…
2019-05-12 13:52:19 -05:00
Matt Rogers
cb7be6d564
Merge pull request #2206 from TracksApp/focus-new-action-field
Remove the autofocus from the search fields
2019-05-12 13:40:32 -05:00
Matt Rogers
19168f262d
Merge pull request #2211 from TracksApp/prefer-find-by-over-detect
Prefer find_by over detect
2019-05-06 08:43:51 -05:00
Matt Rogers
11b9081064
Use !exists? instead of empty?
`exists?` issues a better SQL query than `empty?`
2019-05-04 15:16:36 -05:00