Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2026-01-01 14:58:50 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2211 from TracksApp/prefer-find-by-over-detect

Browse source 
Prefer find_by over detect
This commit is contained in:
Matt Rogers 2019-05-06 08:43:51 -05:00 • committed by GitHub
commit 19168f262d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/user.rb
View file

@ -28,7 +28,7 @@ class User < ApplicationRecord
end
def update_positions(project_ids)
project_ids.each_with_index {|id, position|
project = self.detect { |p| p.id == id.to_i }
project = self.find_by(id: id.to_i)
raise I18n.t('models.user.error_project_not_associated', :project => id, :user => @user.id) if project.nil?
project.update_attribute(:position, position + 1)
}