Commit graph

488 commits

Author SHA1 Message Date
Jan-Yves Ruzicka
6fcf7e6d46 Fix test_start_from_in_future 2020-02-06 10:46:32 +13:00
Jyri-Petteri Paloposki
6b54962388 #1955: Add user_id to tag test fixtures to fix tests 2019-06-27 15:58:12 +03:00
Jyri-Petteri Paloposki
dc0ca7239a
Merge branch 'master' into bug/1153_stats 2019-05-22 01:48:37 +03:00
Jyri-Petteri Paloposki
43523d8191 Test the RSS feed of starred, active todos 2019-05-22 00:40:58 +03:00
Jyri-Petteri Paloposki
088346ecb0 One more decomissioned test file away 2019-05-20 01:21:55 +03:00
Jyri-Petteri Paloposki
80aad1b4f2 #1153: Remove unnecessary type change and test for stats chart templates and endpoints which were removed 2019-05-20 01:12:25 +03:00
Steven R. Baker
1461a3a10c The actual link should be URI escaped, not HTML escaped. 2019-05-13 18:59:39 +02:00
Jyri-Petteri Paloposki
78ef3141c6 #2203: Change the test testing API token access to test for ok instead of forbidden 2019-05-04 20:58:53 +03:00
Matt Rogers
63ac90ebb2
Convert to using symbols everywhere 2019-04-11 11:28:43 -05:00
Matt Rogers
fc17a03bc0
Add tests for the new object and fix a bug
Each of the individual query chunks has their own test, in addition to a
test for the full combination of parameters that could influence a
query.

There is also a bugfix for the tag query in here, since I want, as much
as possible, to have passing tests on every commit.
2019-04-11 09:53:53 -05:00
Matt Rogers
7608ed080c
Remove the alt text for removing the dependency
It's no longer generated automatically by Rails' helpers
2018-11-17 10:58:16 -06:00
Matt Rogers
32d267d6cd
Remove private variable usage from models
It seems that `@new_record_before_save` as an instance variable has been
present since around 2007 and it wasn't until Rails 5.1 that things were
changed in such a way to make this inaccessible now.
2018-11-12 13:23:30 -06:00
Matt Rogers
735c6848fc
Use hash style syntax to get errors
ActiveModel::Errors#get is deprecated, has no effect, and will be
removed without replacement.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:23:56 -05:00
Matt Rogers
6e48ce6594
Compare items of the same type
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:19:57 -05:00
Matt Rogers
908f021aa5
Stop using a deprecated method to reload an association
Use `reload` instead.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:16:00 -05:00
Matt Rogers
2f85a42f91
Use the keyword args syntax for controller actions
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
Matt Rogers
fd2f49596c
Update test with the proper param structure
Fixes the test failure we were seeing here.
2018-10-27 13:33:40 -05:00
Matt Rogers
edd0559da1
Fix the mixed-indent in NotesControllerTest 2018-10-19 11:35:52 -05:00
Matt Rogers
71c95c0d01
Switch assert_not_equal to refute_equal
Preferring to use minitest methods here instead of test-unit.
2018-10-19 11:35:52 -05:00
Matt Rogers
dea3b1b58e
Update to a more performant random string implementation
Since `SecureRandom.alphanumeric` is Ruby 2.5 only, we can't use that
for now. Implement a new version until we can get Tracks updated to that
version.
2018-10-19 11:35:52 -05:00
Matt Rogers
bb8fd08685
Remove the assert_value_changed helper
It's only used in one place and it's easy enough to rewrite this into
something more straightforward and less clever.
2018-10-17 21:22:13 -05:00
ericmoon
a92317f0b5 stupid typos 2018-08-02 11:58:56 -07:00
ericmoon
589ee75168 another assert_nil hack 2018-08-02 11:52:01 -07:00
ericmoon
04d5e764b2 typo fix 2018-08-02 11:43:48 -07:00
ericmoon
429a22778c hack to remove minitest deprecation warnings 2018-08-02 11:31:50 -07:00
ericmoon
fa7f2a777b assert_equal nil deprecated: replace with assert_nil 2018-08-02 10:57:11 -07:00
Matt Rogers
eaedd53875 Add a test for longest running projects 2017-06-19 09:24:10 -05:00
Dan Rice
b50456d04d Uncomment but skip tests for known issues 2017-03-19 14:13:26 -04:00
Carsten Otto
afb0f03fd3 add tests for open issues 2017-03-07 22:08:12 +01:00
Carsten Otto
c0d20f2e1f move existing tests to rendering_helper_test 2017-03-07 22:08:12 +01:00
Dan Rice
1ba829e960 Merge branch '2.3_branch' 2016-10-15 13:13:02 -04:00
Carsten Otto
f18ef64db4 fix time zone issue in test 2016-06-04 00:22:13 +02:00
Carsten Otto
d7aa83b747 add tests for feeds
and reorganize existing tests
2016-06-04 00:22:13 +02:00
Dan Rice
58e2b82315 Isolate SITE_CONFIG in tests using minitest-stub-const 2016-05-22 21:59:44 -04:00
Dan Rice
a789a0296b Reorder HTML tag attributes to fix failing tests 2016-05-22 21:59:44 -04:00
Dan Rice
689db4c9c3 Update assert_select for Nokogiri compatibility
assert_select has been moved into the rails-dom-testing gem and is now
based on Nokogiri.

* Remove assert_tag and assert_xml_select
* Quote CSS attribute selector values
* Use decoded versions of HTML in assert_select. Nokogiri decodes
  elements prior to matching.
* Add a test helper for entities such as `&nbsp;` for which it's
  difficult or confusing to include the decoded version directly in the
  assertion.
* Assert directly on Atom feeds' XML namespace because it isn't
  selectable as an attribute
2016-05-22 21:59:44 -04:00
Dan Rice
1dfdad96fe Add a helper for fixed-width icons 2016-05-15 22:37:03 -04:00
Carsten Otto
ed3bca22a4 Remove 'project_hidden' state
Compute it using project/context state

Notable change:
todo.hidden? now also returns true if the todo is completed
2016-04-16 09:27:33 +02:00
Jan-Yves Ruzicka
ccf13418f4 Extract rendering to helper method. Shift filename sanitization to controller. 2016-02-02 11:08:12 +00:00
Carsten Otto
3327966af1 add target="_blank" for generated links
This causes the links to be opened in a new window/tab.
Existing (rendered) notes are not affected by this.

Fixes #1747
2016-01-27 21:26:27 +01:00
Matt Rogers
42ab5e3000 Merge pull request #1951 from C-Otto/show_from_midnight
when recurring todos always use midnight for "show from"
2016-01-21 16:13:30 -06:00
Carsten Otto
d2931ea7f0 sort current projects by last_reviewed date
fixes #1960
2016-01-21 22:30:48 +01:00
Carsten Otto
98ccb20f53 fix test 2015-12-13 16:12:55 +01:00
Carsten Otto
b788194f8d fix test 2015-12-13 16:12:45 +01:00
Carsten Otto
2d8d36f46b when recurring todos always use midnight for "show from"
fixes #1940
2015-12-13 15:45:21 +01:00
Carsten Otto
cd09cce7a4 when recurring todos always use midnight for "show from"
fixes #1940
2015-12-13 15:44:40 +01:00
Matt Rogers
3468d1ec13 Merge branch '2.3_branch' 2015-12-08 20:14:33 -06:00
Nascher
dd6698b8a1 Update the maximum password length 2015-08-29 23:58:02 +00:00
Reinier Balt
ddd9c07d3b Fasterer: Use &:symbol is faster
Calling argumentless methods within blocks is slower than using
symbol to proc.
2015-08-19 14:48:31 +02:00
Carsten Otto
e0143cf435 move actual activation to model
fixes #1881
2015-08-09 13:47:17 +02:00