Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2025-12-16 23:30:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove private variable usage from models

Browse source 
It seems that `@new_record_before_save` as an instance variable has been
present since around 2007 and it wasn't until Rails 5.1 that things were
changed in such a way to make this inaccessible now.
This commit is contained in:
Matt Rogers 2018-11-12 13:23:30 -06:00
parent 78742d15b8
commit 32d267d6cd
No known key found for this signature in database
GPG key ID: 605D017C07EB4316
5 changed files with 4 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/models/context_test.rb
View file

@ -61,12 +61,6 @@ class ContextTest < ActiveSupport::TestCase
assert_equal '', c.name
end
def test_new_record_before_save
assert !@agenda.new_record_before_save?, "existing records should not be new_record"
c = Context.where(:name => "I do not exist").first_or_create
assert c.new_record_before_save?, "newly created record should be new_record"
end
def test_hide_context
assert @agenda.active?
@agenda.hide!

6
test/models/project_test.rb
View file

@ -174,12 +174,6 @@ class ProjectTest < ActiveSupport::TestCase
assert_equal 3, @moremoney.todos.not_completed.count
end
def test_new_record_before_save
assert !@timemachine.new_record_before_save?, "existing records should not be new_record"
p = Project.where(:name => "I do not exist").first_or_create
assert p.new_record_before_save?, "newly created record should be new_record"
end
def test_shortened_name
s = "project"*7 # len=49
p = users(:admin_user).projects.create(:name => s)