Reinier Balt
a4e0860aa4
fix failing scenarios
2013-04-14 11:50:21 +02:00
Reinier Balt
67247980ad
fix failing tests
2013-04-11 11:04:07 +02:00
Reinier Balt
9c0445fcb7
make adding of todos from sidebar work in context and project grouping
2013-04-11 10:53:35 +02:00
Reinier Balt
78d28d41e0
fix wrong passing of params to ajax
2013-04-08 19:52:04 +02:00
Reinier Balt
42566b6fee
add test for collapsing project containers
2013-04-06 12:57:53 +02:00
Reinier Balt
3fd2b175f5
restore menu entry
2013-04-06 12:57:53 +02:00
Dan Rice
b1f54e68b8
Use default context sort order when returning autocomplete
...
Fixes #1403
2013-03-25 12:20:50 +02:00
Dan Rice
e6dceb5058
Fix contexts not being viewable if collapsed
...
Contexts collapsed on the homepage were also being collapsed on the
context detail page, but without the option to expand them.
This change stops collapsing them on the detail page regardless of the
setting on the homepage.
2013-03-20 18:56:40 +02:00
Dan Rice
7893401c2f
Remember collapsed state of "Completed actions"
2013-03-20 18:23:44 +02:00
Katrina Owen
a4ae0c03bf
Fix failing tests
2013-03-18 21:54:19 -06:00
Katrina Owen
a690e4a4cd
Extract methods in pie chart data model
2013-03-18 19:57:42 -06:00
Katrina Owen
961227da0c
Extract pie chart data logic into model layer
...
Move most of the tests for this logic into the unit test layer.
2013-03-18 19:49:54 -06:00
Katrina Owen
9f3470f9dc
Shave off slight redundancy
2013-03-18 18:59:56 -06:00
Katrina Owen
f3a076c2af
Turn unreferenced ivars into local variables
2013-03-18 18:58:36 -06:00
Katrina Owen
6e2f1a8e5f
De-dupe pie chart view
...
Pull logic into the controller from the view. There were only a couple
of tiny differences between the running actions and the total actions
view, so I added a couple of instance variables and then called the same
template twice.
2013-03-18 18:56:41 -06:00
Matt Rogers
0cd6656be2
Merge pull request #175 from kytrinyx/pie-chart-bug
...
Add heavy-handed tests against pie chart bug
2013-03-18 06:41:38 -07:00
Reinier Balt
2596d612fa
hide group by project from menu to safely merge refactorings with master
2013-03-18 12:36:40 +01:00
Reinier Balt
85fc82d494
refactor done todos view and tests
2013-03-18 12:36:40 +01:00
Reinier Balt
0a9755c8a3
get all scenario's running again, first pass.
2013-03-18 12:36:40 +01:00
Reinier Balt
ede898120c
remove option to show empty containers and start fixing failing cucumber scenarios
2013-03-18 12:36:40 +01:00
Reinier Balt
22b371ef8c
do a big refactor of rendering collections of todos for home page, tag page, project page, context page
2013-03-18 12:36:40 +01:00
Reinier Balt
f22dfc1f9b
initial changes to add an option to select either context or project as grouping of todos on home or tag page
...
* new menu item in view menu
* js to toggle view
* store setting in cookie to keep de choice of view persistent
* refactor index and tag page of todos to look more alike
* refactor context and project partials to look more alike
2013-03-18 12:32:28 +01:00
Katrina Owen
d6ed7d9722
Add heavy-handed tests against pie chart bug
2013-03-17 19:20:48 -06:00
Katrina Owen
119e536a97
Fix off-by-one error in pie chart data
...
A pie chart with exactly 10 contexts would show up with 9 contexts +
(other).
2013-03-17 16:20:12 -06:00
Dan Rice
d0a12a7010
Merge pull request #173 from zoombody/remove_formatize
...
Render notes using RedCloth without formatize
2013-03-13 08:58:48 -07:00
Dan Rice
dc311221f1
Render notes using RedCloth without formatize
...
Removes the outdated bluecloth dependency
2013-03-13 17:03:58 +02:00
Matt Rogers
f541a4c9d6
Simplify SearchController#results
...
Give names to the various things being searched for and move them out
into their own methods. Also add scopes to give names to things being
queried out of the models.
2013-03-12 19:49:19 -05:00
Matt Rogers
63fc460c00
Refactor the empty message criteria into its own method.
...
Removes plenty of duplication in the code
2013-03-12 14:21:12 -05:00
Matt Rogers
d699359648
Move the view logic back into the helper
...
Staleness#days_stale only gives us the number of days that a Todo has
been stale. Add the logic for choosing the CSS class to use back to the
view helper.
2013-03-10 22:18:59 -05:00
Matt Rogers
8dfbac0fe8
Use the newly extracted method object for getting todo staleness
2013-03-09 22:38:38 -06:00
Dan Rice
d7e9b384f7
Clean up a couple hardcoded strings in alt tags
2013-03-09 12:46:05 -05:00
Katrina Owen
3479585991
Use a more appropriate name for stats domain object
2013-03-05 07:49:44 -07:00
Katrina Owen
d5a555fbac
Encapsulate dependencies of stats index page
...
This may be a bit extreme.
It's modeled after the ideal "rails way".
In the controller, we now know the name of a single resource. It
doesn't happen to be backed by a database table, but it does know all
about the task of collecting stats, leaving the controller concerned
with just munging params and rendering stuff.
I called the resource `IndexPage`, to avoid the temptation of trying to
reuse it, which can get pretty messy.
Later, if a better abstraction appears, it should be fairly painless to
alter.
2013-03-02 17:35:19 -07:00
Katrina Owen
6df3534baf
Inline last pieces into StatsController#index
...
We can now skip the before filter that sets instance variables.
2013-03-02 17:27:38 -07:00
Katrina Owen
ac4a483b18
Inline helper method
2013-03-02 17:24:05 -07:00
Katrina Owen
615a9e46c9
Encapsulate counts and totals into a class.
...
Move queries out of the view and into the model layer.
2013-03-02 17:22:15 -07:00
Katrina Owen
6ccb9a81fb
Group context-related pieces in a class
2013-03-02 17:21:03 -07:00
Katrina Owen
8b1f0a34a0
Group project-related stats into a class.
...
Reduce number of instance variables available to the views.
Replace raw SQL with AR-type query.
2013-03-02 17:12:14 -07:00
Reinier Balt
1e3782ce67
Merge pull request #168 from kytrinyx/stats-actions
...
Encapsulate the stats for actions on the stats index page
2013-03-02 13:58:32 -08:00
Matt Rogers
9e4ec67dd2
Merge pull request #167 from kytrinyx/stats-contexts-view
...
Simplify context partial in stats
2013-03-02 13:52:52 -08:00
Katrina Owen
c4433a5ea9
Don't round in ttc.min_sec method
...
This fixes a bug where it would round 1.8 days up to
2 days, and still display the extra hours in addition.
2013-03-02 16:16:45 -05:00
Katrina Owen
03282638af
Move calculation out of view
2013-03-02 16:16:45 -05:00
Katrina Owen
27ba50b460
Extract time to complete partial
2013-03-02 16:16:45 -05:00
Katrina Owen
62336f94cd
Move time to complete stats into separate class
...
This separates out the calculations from the queries so we can get
decent tests around them.
2013-03-02 16:16:45 -05:00
Katrina Owen
0ebb98d49f
Encapsulate action stats
...
This gets rid of a bunch of instance variables in the view/controller
layer.
2013-03-02 16:16:45 -05:00
Katrina Owen
2d2e5fd133
Simplify context partial in stats
2013-03-02 16:15:18 -05:00
Katrina Owen
d4fb1f95d8
Add spaces so tag cloud columns can wrap.
2013-03-02 15:52:39 -05:00
Reinier Balt
f649c6ce0c
fix js for contexts and add i18n keys for closed contexts
2013-03-02 16:33:38 +01:00
Reinier Balt
2719cb87c7
use state machine from controller and handle exception
2013-03-02 14:52:21 +01:00
Matt Rogers
004339a2ca
Merge pull request #164 from kytrinyx/adjust-font-size
...
Split up the font size calculation
2013-03-02 05:40:38 -08:00