Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2026-01-06 09:18:50 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Turn unreferenced ivars into local variables

Browse source
This commit is contained in:
Katrina Owen 2013-03-17 19:42:51 -06:00
parent 6e2f1a8e5f
commit f3a076c2af
1 changed files with 9 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

20
app/controllers/stats_controller.rb
View file

@ -347,30 +347,28 @@ class StatsController < ApplicationController
def prep_context_data_for_view(all_actions_per_context)
@sum = all_actions_per_context.inject(0){|sum, apc| sum += apc['total'].to_i }
sum = all_actions_per_context.inject(0){|sum, apc| sum += apc['total'].to_i }
pie_cutoff=10
size = [all_actions_per_context.size, pie_cutoff].min
# explicitely copy contents of hash to avoid ending up with two arrays pointing to same hashes
@actions_per_context = Array.new(size){|i| {
actions_per_context = Array.new(size){|i| {
'name' => all_actions_per_context[i]['name'],
'total' => all_actions_per_context[i]['total'].to_i,
'id' => all_actions_per_context[i]['id']
} }
if all_actions_per_context.size > pie_cutoff
@actions_per_context[size-1]['name']=t('stats.other_actions_label')
@actions_per_context[size-1]['total']=@actions_per_context[size-1]['total']
@actions_per_context[size-1]['id']=-1
size.upto(all_actions_per_context.size-1){ |i| @actions_per_context[size-1]['total']+=(all_actions_per_context[i]['total'].to_i) }
actions_per_context[size-1]['name']=t('stats.other_actions_label')
actions_per_context[size-1]['total']=actions_per_context[size-1]['total']
actions_per_context[size-1]['id']=-1
size.upto(all_actions_per_context.size-1){ |i| actions_per_context[size-1]['total']+=(all_actions_per_context[i]['total'].to_i) }
end
@truncate_chars = 15
@pie_slices = Array.new(size){|i| @actions_per_context[i]['total'].to_i*100/@sum }
@pie_labels = Array.new(size){|i| @actions_per_context[i]['name'].truncate(@truncate_chars, :omission => '...') }
@pie_links = Array.new(size){|i| context_path(@actions_per_context[i]['id'])}
@pie_slices = Array.new(size){|i| actions_per_context[i]['total'].to_i*100/sum }
@pie_labels = Array.new(size){|i| actions_per_context[i]['name'].truncate(15, :omission => '...') }
@pie_links = Array.new(size){|i| context_path(actions_per_context[i]['id'])}
end
def init