Commit graph

1673 commits

Author SHA1 Message Date
Jyri-Petteri Paloposki
22530a6b80 Fix the preferences form: Labels' for attributes, boolean fields and autofill of the new password field 2019-05-22 03:36:27 +03:00
Jyri-Petteri Paloposki
dc0ca7239a
Merge branch 'master' into bug/1153_stats 2019-05-22 01:48:37 +03:00
Jyri-Petteri Paloposki
359f615bf7 Remove unnecessary string manipulation 2019-05-22 01:31:26 +03:00
Jyri-Petteri Paloposki
1e0f1bd611 Change context element IDs to use underscore instead of just the c prefix 2019-05-22 01:28:50 +03:00
Jyri-Petteri Paloposki
644cf0d9e7 Fix the syntax 2019-05-21 22:33:21 +03:00
Jyri-Petteri Paloposki
7fc1f1bf9f
Update app/models/todos/undone_todos_query.rb
Co-Authored-By: Matt Rogers <mattr-@github.com>
2019-05-21 22:28:37 +03:00
Jyri-Petteri Paloposki
d784b1a5eb #1929: Fix the actions query breaking when querying actions with a non-existent tag 2019-05-21 15:17:50 +03:00
Jyri-Petteri Paloposki
ccb5e1e2f1 Remove the decomissioned chart view from the selection display listing 2019-05-20 01:39:39 +03:00
Jyri-Petteri Paloposki
80aad1b4f2 #1153: Remove unnecessary type change and test for stats chart templates and endpoints which were removed 2019-05-20 01:12:25 +03:00
Jyri-Petteri Paloposki
458d46da9e #1153: Remove debug output 2019-05-19 18:46:02 +03:00
Jyri-Petteri Paloposki
313e6ee106 #1153: Remove resolved TODO comment 2019-05-19 18:42:56 +03:00
Jyri-Petteri Paloposki
b7320a1de8 #1153: Perhaps the final deletion of the old Flash charts code 2019-05-19 18:40:23 +03:00
Jyri-Petteri Paloposki
61ed4c33f3 #1153: Remove the last of Flash charts 2019-05-19 18:31:04 +03:00
Jyri-Petteri Paloposki
b040dfce51 #1153: Final checks against the old code, fixed the last mistakes 2019-05-19 17:39:38 +03:00
Jyri-Petteri Paloposki
f9370a9a4a #1153: Fix whitespace issues caused by Vim misconfiguration 2019-05-19 16:51:26 +03:00
Jyri-Petteri Paloposki
0b326e17d8 #1153: Use translations properly, add missing labels, fix bugs and add links to charts 2019-05-19 16:40:00 +03:00
Jyri-Petteri Paloposki
0a106aac5e #1153: Remove unnecessary Flash-stats related templates 2019-05-19 13:26:09 +03:00
Jyri-Petteri Paloposki
f873a93eb3 #1153: Convert rest of the stats to use ChartJS 2019-05-19 13:04:33 +03:00
Jyri-Petteri Paloposki
dec82fd26c #1153: Change to using Chart.js with a basic RoR library instead of Chartkick because Chartkick doesn't support combo charts. 2019-05-17 22:49:21 +03:00
Jyri-Petteri Paloposki
c9cae9421a #1153: Few of the graphs converted to use Chartkick 2019-05-17 22:49:21 +03:00
Steven R. Baker
1461a3a10c The actual link should be URI escaped, not HTML escaped. 2019-05-13 18:59:39 +02:00
Matt Rogers
8bf0627d41
Merge pull request #2210 from ZeiP/bug/2032_api_filters
#2032: Use context and project filters in API also when not requestin…
2019-05-12 13:52:19 -05:00
Matt Rogers
cb7be6d564
Merge pull request #2206 from TracksApp/focus-new-action-field
Remove the autofocus from the search fields
2019-05-12 13:40:32 -05:00
Matt Rogers
19168f262d
Merge pull request #2211 from TracksApp/prefer-find-by-over-detect
Prefer find_by over detect
2019-05-06 08:43:51 -05:00
Matt Rogers
11b9081064
Use !exists? instead of empty?
`exists?` issues a better SQL query than `empty?`
2019-05-04 15:16:36 -05:00
Matt Rogers
996395cc80
Merge pull request #2207 from TracksApp/exists-instead-of-count
Use exists? instead of count > 0
2019-05-04 14:54:21 -05:00
Matt Rogers
596096b8d5
Prefer find_by over detect
Uses a better SQL query to pull a single object vs. pulling a full set
and then iterating over it.
2019-05-04 14:51:22 -05:00
Matt Rogers
2c627be0cc
Merge pull request #2208 from ZeiP/feature/2203_api_token
#2203: Allow using REST API with token
2019-05-04 14:49:24 -05:00
Jyri-Petteri Paloposki
8c5edd2dcf #2032: Use context and project filters in API also when not requesting only done items 2019-05-04 22:47:39 +03:00
Jyri-Petteri Paloposki
16ca18e4f5 #2034: Change the REST API documentation to point to the existing done tasks API 2019-05-04 20:35:38 +03:00
Jyri-Petteri Paloposki
d3ba80c84e #2203: Allow using REST API with token 2019-05-04 20:31:32 +03:00
Matt Rogers
a7d8b3c950
Use exists? instead of count > 0 2019-05-04 10:32:15 -05:00
Matt Rogers
f08d596a4e
Remove the autofocus from the search fields 2019-05-04 10:17:43 -05:00
Jyri-Petteri Paloposki
b9a80a385e #2036: Change empty XML responses to have the correct base element 2019-05-03 11:47:05 +03:00
Matt Rogers
d08608c755
Remove the query code from TodosController
It has been completely replaced with our new query object
2019-04-11 14:38:56 -05:00
Matt Rogers
63ac90ebb2
Convert to using symbols everywhere 2019-04-11 11:28:43 -05:00
Matt Rogers
fc17a03bc0
Add tests for the new object and fix a bug
Each of the individual query chunks has their own test, in addition to a
test for the full combination of parameters that could influence a
query.

There is also a bugfix for the tag query in here, since I want, as much
as possible, to have passing tests on every commit.
2019-04-11 09:53:53 -05:00
Matt Rogers
df091c7ec5
Use the results of the new query object
This confirms that we've successfully extracted the code and now we can
start removing the old code.
2019-04-07 20:08:11 -05:00
Matt Rogers
eb7c34e973
Run both the new query and the old query
Throw away the results of the new query for now. Now that we know it
will run without raising exceptions, we can replace the old query with
the new query.
2019-04-07 20:04:28 -05:00
Matt Rogers
ec1a4d78ba
Temporarily add the sanitize helper
This is so we can keep the tests passing by fixing a NoMethodError when
attempting to run both the new query object and the existing code at the
same time.
2019-04-07 20:01:22 -05:00
Matt Rogers
9de975f8eb
Extract a query object for not done todos 2019-04-07 19:59:01 -05:00
Matt Rogers
f2647e3f94
Remove deprecations printed out in the test suite 2018-11-20 19:57:02 -06:00
Matt Rogers
32d267d6cd
Remove private variable usage from models
It seems that `@new_record_before_save` as an instance variable has been
present since around 2007 and it wasn't until Rails 5.1 that things were
changed in such a way to make this inaccessible now.
2018-11-12 13:23:30 -06:00
Matt Rogers
78742d15b8
Remove rendering of the charts
There's something wrong with the swf_fu gem. It's not worth it to fix a
gem that hasn't seen any activity in six years and is using outdated
flash technology in the first place.
2018-11-12 13:19:49 -06:00
Matt Rogers
c3a13bca16
Fix the undefined reference to Staleness
Not sure what's going on with Rails' autoloading here, so fix it the
ruby way by using plain ol' `require`
2018-11-12 08:55:42 -06:00
Matt Rogers
0e21d64890
Convert to ApplicationRecord
Rails 5 requires the use of this superclass for all database backed
model objects now.
2018-11-03 15:57:14 -05:00
Matt Rogers
6d81e14b41
Use a non deprecated method to collect errors
Hash-based access to set an error is deprecated. Use
ActiveModel::Errors.add instead.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:12:27 -05:00
Matt Rogers
7fe0cf271a
Access MIME types via hash lookup instead of constant
Use a constant to look up a mime type is deprecated.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
Matt Rogers
6e70fcbe5e
Update how the sorting is done in the User model
Use the `sort_by` method to do the sorting rather than converting to an
array and then calling `sort`

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:27:22 -05:00
Matt Rogers
cf6f9de377
Merge pull request #2115 from hewo/feature_search_in_navbar
Feature search in navbar
2018-09-23 13:55:26 -05:00