Commit graph

59 commits

Author SHA1 Message Date
Reinier Balt
78f81ed29f Do not symbolize arbitray locale params
* Validate locale is valid before assigning it
* Don't convert invalid locales to symbols (creates DoS risk)

thanks @brynary
2013-05-07 09:29:47 +02:00
Matt Rogers
c1597a7751 Rename to_xml_params to todo_xml_params 2013-04-30 22:52:22 -05:00
Matt Rogers
8fe343cccc Push to_xml_params down to ApplicationController 2013-04-30 22:50:32 -05:00
Matt Rogers & Katrina Owen
a1b270699d Extract creation of todos from recurrings todos 2013-04-25 20:45:14 -05:00
Dan Rice
dc311221f1 Render notes using RedCloth without formatize
Removes the outdated bluecloth dependency
2013-03-13 17:03:58 +02:00
Reinier Balt
583664be36 remove some dynamic finders (they are deprecated for rails4) and add test for untested method of context.rb 2013-02-25 10:21:04 +01:00
Reinier Balt
1b0d08bbb5 fix timing issues on failing scenarios. Fix deprecated jquery functions and update jqueryui
Signed-off-by: Reinier Balt <lrbalt@gmail.com>
2013-02-15 22:27:39 +01:00
Matt Rogers
4d2f25ab20 Refactor the fetching of done todos
Move the get_done_today, get_done_this_week, and get_done_this month
methods into their own class in lib/tracks and use the new class in the
context, project, and todo controllers.

This removes the complexity from the application controller, silos it
off, and slightly reduces the complexity of the other controllers so
that they don't have to duplicate as much code.

The tradeoff here is that the code that was moved out into its own class
was also duplicated in the todos controller due to a different use case
that I didn't see before. This is still an improvement however and so
I'm ok with going back and tackling the extra complexity added to
TodoController at a later date.
2012-11-27 23:07:46 -06:00
Dan Rice
5b6cbf566a Don't sort todos when counting them
Grouping isn't as lax in PostgreSQL as it is in MySQL or SQLite. All
sort fields also need to be in the GROUP BY, or be aggregated. The order
isn't relevant when counting, so simply don't order in that case.

Fix #1336
2012-10-04 10:43:22 -04:00
Stefan Hacker
27adccb6e9 Remove unused layout and clear up naming
* scaffold.css is only used by login -> rename to login.css
* standard.html.erb is the default application layout -> rename to application.html.erb
* scaffold.html.erb is unused -> deleted
2012-09-02 14:20:17 +02:00
Matt Rogers
7d0c716366 Fix a few typos in the comment 2012-07-13 20:55:53 -05:00
Reinier Balt
bd8498f39c fix #1287. Fix various small bugs and some small improvements 2012-06-29 16:48:30 +02:00
Reinier Balt
901a5ff0d2 get project features to pass 2012-05-12 14:48:56 +02:00
Reinier Balt
d7aebf03a0 get context, dependencies and admin scenarios running 2012-05-01 15:45:58 +02:00
Reinier Balt
7bce774daa get context list scenario passing 2012-05-01 09:39:53 +02:00
Reinier Balt
96db48dd86 get project integrations and login controller tests running 2012-04-30 13:56:40 +02:00
Reinier Balt
e964769553 home page is restored, so is context view 2012-04-30 13:56:37 +02:00
Reinier Balt
86afd42148 Work in progress: has_many_polymorphs does not work with rails 3.2 because of intrusive changes in rails internals. I think we need to rip out this dependency... 2012-04-30 13:56:34 +02:00
Reinier Balt
a83c8b3f92 initial upgrade to rails 3.2.3 2012-04-30 13:56:33 +02:00
Reinier Balt
e74f8842ae Get more i18n fixed in for he locale. Include fallback to en locale and include pluralization mechanism 2012-04-16 13:19:04 +02:00
Reinier Balt
12d8915eda Get all non-cucumber tests passing 2012-04-12 12:47:25 +02:00
Reinier Balt
bb8b5a4c72 store rendered notes of todos in database to avoid costly rendering when you load a page 2012-04-12 11:34:08 +02:00
Reinier Balt
f74370aab5 first refactoring of stats controller 2012-01-20 23:34:58 +01:00
Reinier Balt
4b6aff5502 hopefully fix failing recurring todos test. Timezones are a pain to get right 2011-11-16 22:05:06 +01:00
Matt Rogers
b387b27f4a Show deferred actions on the project listing and sidebar
If a project does not have any active actions, then it will now display
that it has x number of deferred actions.

Fixes #1084
2011-10-20 21:05:57 -05:00
Reinier Balt
eb26f4f7b9 fix error on end of each request at cleanup_application
declaring self.method caused rails to error

Signed-off-by: Reinier Balt <lrbalt@gmail.com>
2011-09-30 19:49:18 +02:00
Jan Stępień
5d3829cfbf Users with SHA-1 hashes are redirected to the password change page 2011-09-07 16:06:03 +02:00
Reinier Balt
f2d581d5a4 revert refactoring that created a big performance regression 2011-07-09 17:21:35 +02:00
Reinier Balt
a58e832945 get the done view on a context and a project 2011-07-09 17:21:34 +02:00
Reinier Balt
8546ae5dfa fix test failures after the changes and refactorings 2011-07-09 17:19:12 +02:00
Reinier Balt
559a02d6f1 start on done overview page 2011-07-09 17:19:12 +02:00
Reinier Balt
3116d46820 fix #1132 by moving z-index of topbar to 500+ and the z-index of the todos to 500- 2011-03-26 20:05:56 +01:00
Reinier Balt
898dbe01c6 fix #1125 where rest/xml request were being rejected by the new csrf code of rails 2011-03-26 17:34:54 +01:00
Reinier Balt
00f3a25807 fix #1128 for 2.0 2011-03-12 00:58:32 +01:00
Reinier Balt
36f007a087 clean ups 2011-02-26 14:20:51 +01:00
Reinier Balt
e9d92438d6 fix #1109 and do some small optimizations on home page 2011-02-25 23:54:53 +01:00
Reinier Balt
1f67d2a603 get dependency add/remove from new_action_form running 2011-02-25 14:51:05 +01:00
Reinier Balt
a02f1d2584 migrate dependencies
without functional changes
2011-02-03 18:19:29 +01:00
Reinier Balt
1a821a228f let autocomplete fail gracefully when param is not set 2011-02-03 18:19:21 +01:00
Reinier Balt
f923a40a40 get tag view working for updating todos. Refactored update a lot 2011-02-03 18:18:41 +01:00
Reinier Balt
e13e946295 migrate adding to actions on all pages 2011-02-03 18:18:38 +01:00
Reinier Balt
c834403340 replace old prototype/jrails code for periodic checks and start work on autocomplete and edit projects
Signed-off-by: Reinier Balt <lrbalt@gmail.com>
2011-02-03 18:16:51 +01:00
Marcus Ilgner
a7998ba40a Fixes for failed tests 2011-01-16 18:26:00 +01:00
Marcus Ilgner
338d4bb5a6 Added locale selection to preferences
Mostly completed transition to full i18n
Incorporated german translations by Ulf Klose <ulf.klose@gmail.com>
2011-01-16 18:14:07 +01:00
Reinier Balt
6b36d6eb8f fix failing tests 2010-11-09 10:47:09 +01:00
Marcus Ilgner
fd3f69d927 Changed code to support basic i18n.
Added RubyMine configuration and rvm setup to .gitignore.
2010-11-09 16:31:26 +08:00
Eric Allen
c79d1c964a Autocomplete lists should be based on "q" parameter
If you don't filter server-side, the user sees the full list until
another character is entered.
2010-04-02 13:36:59 -04:00
Eric Allen
9ab69adb38 Dynamically load autocompletes
This cuts something like 100ms off of page load times!

Closes #1011
2010-04-02 13:24:21 -04:00
Eric Allen
502e60c9a1 Oops..Forgot to revert this little bit of i18n
Fixes #991
2010-01-26 15:50:21 -05:00
Eric Allen
b87f4cc12e Revert i18n changes
We haven't merged that branch yet to trunk
2010-01-12 17:49:39 -08:00