Matt Rogers
2cbe020d8a
Update the app for Rails 5.2
...
After the framework bump, run `rails app:update` to pull in the new
framework changes and defaults.
2018-11-17 12:37:03 -06:00
Matt Rogers
daf5736a32
Merge pull request #2144 from TracksApp/rails52
...
Upgrade Rails to 5.2
2018-11-17 11:04:50 -06:00
Matt Rogers
7608ed080c
Remove the alt text for removing the dependency
...
It's no longer generated automatically by Rails' helpers
2018-11-17 10:58:16 -06:00
Matt Rogers
9e76a5e734
Bump mysql to 0.4.x
2018-11-17 10:58:16 -06:00
dependabot[bot]
002b387fb5
Bump rails from 5.1.6 to 5.2.1
...
Bumps [rails](https://github.com/rails/rails ) from 5.1.6 to 5.2.1.
- [Release notes](https://github.com/rails/rails/releases )
- [Commits](https://github.com/rails/rails/compare/v5.1.6...v5.2.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-17 10:57:38 -06:00
Matt Rogers
bc4333c32e
Merge pull request #2143 from TracksApp/remove-rails51-deprecations
...
Remove Rails 5.1 deprecations
2018-11-17 09:33:59 -06:00
Matt Rogers
aca54f5aff
Remove raise_on_unfiltered_parameters
...
Deprecated and has no effect in Rails 5.1
2018-11-17 09:15:49 -06:00
Matt Rogers
faaecbae40
Remove halt_callback_chains_on_return_false
...
It's deprecated in Rails 5.1 and will block the Rails 5.2 upgrade.
2018-11-17 09:11:52 -06:00
Matt Rogers
6952202e7b
Merge pull request #2130 from TracksApp/dependabot/bundler/bootstrap-sass-3.3.7
...
Bump bootstrap-sass from 3.3.3 to 3.3.7
2018-11-16 22:30:02 -06:00
Matt Rogers
497a35da67
Merge pull request #2132 from TracksApp/dependabot/bundler/mocha-1.7.0
...
Bump mocha from 1.6.0 to 1.7.0
2018-11-16 22:29:17 -06:00
Matt Rogers
9e10cabef8
Merge pull request #2140 from TracksApp/dependabot/bundler/rubocop-0.60.0
...
Bump rubocop from 0.58.2 to 0.60.0
2018-11-16 22:28:21 -06:00
dependabot[bot]
d4cc907d8d
Bump rubocop from 0.58.2 to 0.60.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.58.2 to 0.60.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.58.2...v0.60.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-14 05:53:59 +00:00
dependabot[bot]
7c0d27f625
Bump mocha from 1.6.0 to 1.7.0
...
Bumps [mocha](https://github.com/freerange/mocha ) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/freerange/mocha/releases )
- [Changelog](https://github.com/freerange/mocha/blob/master/RELEASE.md )
- [Commits](https://github.com/freerange/mocha/compare/v1.6.0...v1.7.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-13 21:50:38 +00:00
Matt Rogers
6754d8ffa9
Merge pull request #2139 from TracksApp/rails51
...
Upgrade to Rails 5.1
2018-11-13 15:48:50 -06:00
Matt Rogers
ab24522df0
Add the listen gem to the project
...
This is so the tests will run in CI properly.
2018-11-12 16:03:42 -06:00
Matt Rogers
32d267d6cd
Remove private variable usage from models
...
It seems that `@new_record_before_save` as an instance variable has been
present since around 2007 and it wasn't until Rails 5.1 that things were
changed in such a way to make this inaccessible now.
2018-11-12 13:23:30 -06:00
Matt Rogers
78742d15b8
Remove rendering of the charts
...
There's something wrong with the swf_fu gem. It's not worth it to fix a
gem that hasn't seen any activity in six years and is using outdated
flash technology in the first place.
2018-11-12 13:19:49 -06:00
Matt Rogers
1ccf96ae83
Initial upgrade to Rails 5.1
2018-11-12 09:07:12 -06:00
Matt Rogers
d24b9d9aa1
Merge pull request #2138 from TracksApp/fix-missing-staleness-class
...
Fix the undefined reference to Staleness
2018-11-12 09:06:23 -06:00
Matt Rogers
c3a13bca16
Fix the undefined reference to Staleness
...
Not sure what's going on with Rails' autoloading here, so fix it the
ruby way by using plain ol' `require`
2018-11-12 08:55:42 -06:00
Matt Rogers
c19be59ca5
Merge pull request #2136 from TracksApp/dependabot/bundler/rack-2.0.6
...
[Security] Bump rack from 2.0.5 to 2.0.6
2018-11-06 11:44:12 -06:00
dependabot[bot]
fa81c7afa0
[Security] Bump rack from 2.0.5 to 2.0.6
...
Bumps [rack](https://github.com/rack/rack ) from 2.0.5 to 2.0.6. **This update includes security fixes.**
- [Release notes](https://github.com/rack/rack/releases )
- [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rack/rack/compare/2.0.5...2.0.6 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-06 00:28:33 +00:00
Matt Rogers
7a94631a5c
Merge pull request #2135 from TracksApp/add-application-record
...
Convert to ApplicationRecord
2018-11-03 16:08:32 -05:00
Matt Rogers
0e21d64890
Convert to ApplicationRecord
...
Rails 5 requires the use of this superclass for all database backed
model objects now.
2018-11-03 15:57:14 -05:00
Matt Rogers
35e6384b95
Merge pull request #2134 from TracksApp/remove-rails-51-deprecations
...
Remove all the deprecations seen in the tests
2018-11-03 15:47:14 -05:00
Matt Rogers
6e5dcb082b
Remove raise_in_transactional_callbacks
...
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:30:14 -05:00
Matt Rogers
735c6848fc
Use hash style syntax to get errors
...
ActiveModel::Errors#get is deprecated, has no effect, and will be
removed without replacement.
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:23:56 -05:00
Matt Rogers
6e48ce6594
Compare items of the same type
...
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:19:57 -05:00
Matt Rogers
908f021aa5
Stop using a deprecated method to reload an association
...
Use `reload` instead.
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:16:00 -05:00
Matt Rogers
6d81e14b41
Use a non deprecated method to collect errors
...
Hash-based access to set an error is deprecated. Use
ActiveModel::Errors.add instead.
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:12:27 -05:00
Matt Rogers
1eb892a473
Don't convert ActionController::Parameters to a hash
...
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:07 -05:00
Matt Rogers
7fe0cf271a
Access MIME types via hash lookup instead of constant
...
Use a constant to look up a mime type is deprecated.
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
Matt Rogers
2f85a42f91
Use the keyword args syntax for controller actions
...
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
dependabot[bot]
05ef3e56df
Bump bootstrap-sass from 3.3.3 to 3.3.7
...
Bumps [bootstrap-sass](https://github.com/twbs/bootstrap-sass ) from 3.3.3 to 3.3.7.
- [Release notes](https://github.com/twbs/bootstrap-sass/releases )
- [Changelog](https://github.com/twbs/bootstrap-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/twbs/bootstrap-sass/compare/v3.3.3...v3.3.7 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-11-02 05:38:55 +00:00
Matt Rogers
755a7a1b80
Merge pull request #2122 from greysteil/dependabot/bundler/loofah-2.2.3
...
[Security] Bump loofah from 2.2.2 to 2.2.3
2018-11-01 17:25:36 -05:00
dependabot[bot]
510984e965
[Security] Bump loofah from 2.2.2 to 2.2.3
...
Bumps [loofah](https://github.com/flavorjones/loofah ) from 2.2.2 to 2.2.3. **This update includes security fixes.**
- [Release notes](https://github.com/flavorjones/loofah/releases )
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/loofah/compare/v2.2.2...v2.2.3 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-30 14:08:24 +00:00
Matt Rogers
a3344026c9
Merge pull request #2121 from TracksApp/upgrade-to-rails-5-0
...
Upgrade to Rails 5.0
2018-10-27 13:48:40 -05:00
Matt Rogers
fd2f49596c
Update test with the proper param structure
...
Fixes the test failure we were seeing here.
2018-10-27 13:33:40 -05:00
Matt Rogers
36e59746ea
Add the environment setup for Rails 5
2018-10-27 12:28:29 -05:00
Matt Rogers
6e70fcbe5e
Update how the sorting is done in the User model
...
Use the `sort_by` method to do the sorting rather than converting to an
array and then calling `sort`
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:27:22 -05:00
Matt Rogers
859701a81f
Update configuration after the Rails upgrade
...
Ran `bin/rake rails:upgrade` and went through all the changes.
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:27:07 -05:00
Matt Rogers
c7b9f008a6
Use puma instead of thin
...
Puma has become the default and has some really nice integration points
in Rails.
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:26:48 -05:00
Matt Rogers
57ae87cccb
Initial gem update to Rails 5.x
...
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:26:44 -05:00
Matt Rogers
1d9c947705
Merge pull request #2120 from TracksApp/remove-testing-cruft
...
Update some testing practices to use more relevant methods
2018-10-21 13:45:11 -05:00
Matt Rogers
edd0559da1
Fix the mixed-indent in NotesControllerTest
2018-10-19 11:35:52 -05:00
Matt Rogers
71c95c0d01
Switch assert_not_equal to refute_equal
...
Preferring to use minitest methods here instead of test-unit.
2018-10-19 11:35:52 -05:00
Matt Rogers
dea3b1b58e
Update to a more performant random string implementation
...
Since `SecureRandom.alphanumeric` is Ruby 2.5 only, we can't use that
for now. Implement a new version until we can get Tracks updated to that
version.
2018-10-19 11:35:52 -05:00
Matt Rogers
bb8fd08685
Remove the assert_value_changed helper
...
It's only used in one place and it's easy enough to rewrite this into
something more straightforward and less clever.
2018-10-17 21:22:13 -05:00
Matt Rogers
cf6f9de377
Merge pull request #2115 from hewo/feature_search_in_navbar
...
Feature search in navbar
2018-09-23 13:55:26 -05:00
Matt Rogers
303bee0244
Merge pull request #2117 from TracksApp/rails-syntax-updates
...
Compatibility updates for newer versions of Rails
2018-09-23 13:55:08 -05:00