Commit graph

71 commits

Author SHA1 Message Date
Jyri-Petteri Paloposki
d4c9041ccd More code style fixes 2021-01-06 03:47:35 +02:00
Jyri-Petteri Paloposki
67a426a2e9 More code climate style fixes 2020-10-10 15:24:01 +03:00
Jyri-Petteri Paloposki
d8acf60049 Code style fixes 2020-10-10 05:14:24 +03:00
Jyri-Petteri Paloposki
bbb9fc8809 Make LIKE searches case-insensitive also on PgSQL 2020-09-05 02:17:32 +03:00
Jyri-Petteri Paloposki
a0768636c3 Try fixing a few test deprecations 2020-08-20 19:33:46 +03:00
Matt Rogers
11b9081064
Use !exists? instead of empty?
`exists?` issues a better SQL query than `empty?`
2019-05-04 15:16:36 -05:00
Matt Rogers
f2647e3f94
Remove deprecations printed out in the test suite 2018-11-20 19:57:02 -06:00
Matt Rogers
32d267d6cd
Remove private variable usage from models
It seems that `@new_record_before_save` as an instance variable has been
present since around 2007 and it wasn't until Rails 5.1 that things were
changed in such a way to make this inaccessible now.
2018-11-12 13:23:30 -06:00
Matt Rogers
0e21d64890
Convert to ApplicationRecord
Rails 5 requires the use of this superclass for all database backed
model objects now.
2018-11-03 15:57:14 -05:00
Carsten Otto
ed3bca22a4 Remove 'project_hidden' state
Compute it using project/context state

Notable change:
todo.hidden? now also returns true if the todo is completed
2016-04-16 09:27:33 +02:00
Matt Rogers
efbf881742 Merge pull request #1872 from C-Otto/create-reviewed-2.3
(2.3) create projects as reviewed at creation time
2015-08-07 19:59:57 -04:00
Carsten Otto
67ced62096 Projects with completed actions may be blocked
Currently, a project cannot be blocked if at least one completed
action exists. This was introduced in
acab98d4c7,
and I assume this change was not intended
2015-06-16 20:44:26 -04:00
Carsten Otto
6014ce7a6f create projects as reviewed at creation time
Fixes #1788
2015-05-22 23:12:45 +02:00
Reinier Balt
166387f0be Statistics for longest running projects now includes completed and hidden projects. fixes #1725 2014-11-05 17:09:59 +01:00
Matt Rogers
aa41e20e46 Remove trailing whitespace and tabs 2014-08-14 21:05:05 -05:00
Dan Rice
622291d98d Purge UserTime from app/* 2014-06-12 21:24:31 -04:00
Dan Rice
1b3543c5de Add stub for NullProject.persisted? 2014-05-06 21:51:39 -04:00
Dan Rice
8e13059df1 Further improve time comparison in Project model 2014-03-30 21:49:12 -04:00
Dan Rice
ece69b8540 Use Date class to assist with date math in Project model
Fixes an intermittent failure in ProjectTest#test_age_in_days
2014-03-30 17:26:31 -04:00
Reinier Balt
17dca39d3a update gems and fix i18n and aasm deprecation warnings 2013-12-30 20:52:35 +01:00
Greg Sutcliffe
2f043911c6 Extend RichMessage format to include other data
Uses new Regex to detect:

 @ context
 ~ project
 > tickler-date
 < due-date
 # tag (repeatable)
 * (starred)
2013-10-16 21:25:47 +01:00
Reinier Balt
a31c0a7a5d fix import for csv 2013-09-16 11:37:16 +02:00
Matt Rogers
6681df9530 Merge pull request #202 from TracksApp/extract-extras-from-user
Extract time and date concerns from User
2013-08-01 14:59:17 -07:00
Matt Rogers
96777c2e3a Replace User#time with UserTime#time 2013-07-30 16:21:04 -05:00
Matt Rogers
6c695aa61a Fix a date-based issue in the project tests
Due to time zone issues, this test was failing for me because it was
attempting to compare a date in my local time zone with a UTC date.
2013-07-29 21:43:05 -05:00
Darren Cato
2e13affdce typos and style tweaks 2013-07-23 01:28:43 -04:00
Darren Cato
3450c22e97 first pass at csv import functionality for tracks 2013-07-21 13:37:35 -04:00
Reinier Balt
671f64b419 move to strong_parameters of rails4. 2013-05-27 12:44:31 +02:00
Reinier Balt
ebff4cfc0c start fixing deprecation warnings 2013-05-11 23:13:32 +02:00
Matt Rogers
883ea2b968 Move Project#create_from_todo to its own class
The point of this is to keep as many things out of the ActiveRecord
objects as possible and use them as just a thin database abstraction
layer.
2013-05-02 22:30:24 -05:00
Reinier Balt
5ed69fc1a2 update gems and fix failures from new aasm
I'm not sure the test failures caused by reload not working are caused by the new aasm, 
perhaps the thread isolation is causing that...
2013-04-29 11:53:32 +02:00
Reinier Balt
22b371ef8c do a big refactor of rendering collections of todos for home page, tag page, project page, context page 2013-03-18 12:36:40 +01:00
Matt Rogers
f541a4c9d6 Simplify SearchController#results
Give names to the various things being searched for and move them out
into their own methods. Also add scopes to give names to things being
queried out of the models.
2013-03-12 19:49:19 -05:00
Katrina Owen
2686a0d3b5 Don't link to null projects
If you have fewer than 10 projects, then empty running projects were
linked to with the path `/projects/-1`.

Copy/pasted the list strategy from the other project sections in the
same partial so the duplication becomes explicit.
2013-03-02 00:19:47 -05:00
Reinier Balt
acab98d4c7 fix failing tests 2013-03-01 16:22:29 +01:00
Matt Rogers
b01c7878d1 Push conversion of a todo to a project down.
Refactor the conversion of a todo to a project and move it from the
TodosController to the Project model.
2012-08-14 19:33:54 -05:00
Reinier Balt
4e29bf69f7 fix failing tests and small refactorings 2012-07-18 11:42:26 +02:00
Reinier Balt
5d703975a3 fix #1292. Make the sort order in project view the same as context view 2012-06-27 14:10:14 +02:00
Reinier Balt
96db48dd86 get project integrations and login controller tests running 2012-04-30 13:56:40 +02:00
Reinier Balt
86afd42148 Work in progress: has_many_polymorphs does not work with rails 3.2 because of intrusive changes in rails internals. I think we need to rip out this dependency... 2012-04-30 13:56:34 +02:00
Matt Rogers
beb18ac1f4 Hidden projects are not stalled. Update the comment. 2011-12-19 12:30:51 -06:00
Craig Maloney
48de4b1b00 Keep hidden projects from showing up as stalled, since they're likely hidden for a reason. 2011-12-19 12:28:57 -06:00
sf
90f9e41671 changed the condition to increase readability 2011-10-10 05:36:56 -04:00
sf
3d3646a137 completed reviews no longer show up that they need a review 2011-10-08 00:23:31 -04:00
Reinier Balt
2f0bfbbf47 some smallfurther adjustments 2011-09-28 15:34:15 +02:00
Reinier Balt
3a07010338 first cleanups of review feature 2011-09-28 13:58:46 +02:00
sf
227e0052b3 fixed always true line 2011-09-27 09:42:30 -04:00
sfischme
6f8d9ec2ae exclude completed projects from blocked list 2011-09-17 13:15:30 -04:00
sfischme
7873d2cff8 explude completed projects from review 2011-09-17 13:13:45 -04:00
sfischme
ac98737176 first version of review view 2011-09-16 23:34:09 -04:00