some smallfurther adjustments

This commit is contained in:
Reinier Balt 2011-09-28 15:34:15 +02:00
parent 3a07010338
commit 2f0bfbbf47
4 changed files with 6 additions and 6 deletions

View file

@ -40,7 +40,7 @@ class ProjectsController < ApplicationController
@projects_to_review = current_user.projects.select {|p| p.needs_review?(current_user)}
@stalled_projects = current_user.projects.select {|p| p.stalled?}
@blocked_projects = current_user.projects.select {|p| p.blocked?}
@current_projects = current_user.projects.select {|p| not(p.needs_review?(current_user))}
@current_projects = current_user.projects.uncompleted.select {|p| not(p.needs_review?(current_user))}
init_not_done_counts(['project'])
init_project_hidden_todo_counts(['project'])

View file

@ -115,14 +115,14 @@ class Project < ActiveRecord::Base
def blocked?
## mutually exclusive for stalled and blocked
# blocked is uncompleted project with deferred or pending todos, but no next actions
return false if self.stalled? || self.completed?
return !self.todos.deferred_or_blocked.empty?
return false if self.completed?
return !self.todos.deferred_or_blocked.empty? && self.todos.not_deferred_or_blocked.empty?
end
def stalled?
# stalled is active/hidden project with no active todos
return false if self.completed?
return self.todos.not_completed.empty?
return self.todos.deferred_or_blocked.empty? && self.todos.not_deferred_or_blocked.empty?
end

View file

@ -40,7 +40,7 @@ project = project_form
<%=image_tag("cancel.png", :alt => "") %>
Cancel
</a>
<a href="/projects/<%=project.id.to_s+"/set_reviewed"%>" id="<%= dom_id(project, 'reviewed') %>" class="reviewed">
<a href="<%=set_reviewed_project_path(project)%>" id="<%= dom_id(project, 'reviewed') %>" class="reviewed">
<%=image_tag("reviewed.png", :alt => "") %>
Reviewed
</a>

View file

@ -14,7 +14,7 @@ ActionController::Routing::Routes.draw do |map|
map.resources :projects,
:collection => {:order => :post, :alphabetize => :post, :actionize => :post, :done => :get},
:member => {:done_todos => :get, :all_done_todos => :get, :set_reviewed => :post} do |projects|
:member => {:done_todos => :get, :all_done_todos => :get, :set_reviewed => :get} do |projects|
projects.resources :todos, :name_prefix => "project_"
end