Andreas/ngx-admin
1
0
Fork 0
mirror of https://github.com/akveo/ngx-admin.git synced 2025-12-17 07:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(baAmChart): ViewChild instead of querying dom

Browse source
This commit is contained in:
nixa 2016-05-20 19:46:37 +03:00
parent 8e82cc57ff
commit b05f525a7c
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/app/theme/components/baAmChart/baAmChart.component.ts
View file

@ -1,4 +1,4 @@
import {Component, ViewEncapsulation, Input, Output, ElementRef, EventEmitter} from '@angular/core'; import {Component, ViewChild, ViewEncapsulation, Input, Output, ElementRef, EventEmitter} from '@angular/core';
import './baAmChart.loader.ts'; import './baAmChart.loader.ts';
import {BaAmChartThemeService} from './baAmChartTheme.service'; import {BaAmChartThemeService} from './baAmChartTheme.service';
@ -15,7 +15,9 @@ export class BaAmChart {
@Input() baAmChartClass:string; @Input() baAmChartClass:string;
@Output() onChartReady = new EventEmitter<any>(); @Output() onChartReady = new EventEmitter<any>();
constructor (private _elementRef:ElementRef, private _baAmChartThemeService:BaAmChartThemeService) { @ViewChild('baAmChart') private _selector:ElementRef;
constructor (private _baAmChartThemeService:BaAmChartThemeService) {
} }
ngOnInit() { ngOnInit() {
@ -23,9 +25,7 @@ export class BaAmChart {
} }
ngAfterViewInit() { ngAfterViewInit() {
let el = this._elementRef.nativeElement.querySelector('.ba-am-chart'); let chart = AmCharts.makeChart(this._selector.nativeElement, this.baAmChartConfiguration);
let chart = AmCharts.makeChart(el, this.baAmChartConfiguration);
this.onChartReady.emit(chart); this.onChartReady.emit(chart);
} }
} }

2
src/app/theme/components/baAmChart/baAmChart.html
View file

@ -1 +1 @@
<div class="ba-am-chart {{baAmChartClass || ''}}"></div> <div #baAmChart class="ba-am-chart {{baAmChartClass || ''}}"></div>