From b05f525a7c13e74598c3ccc3044decebb1bc8116 Mon Sep 17 00:00:00 2001 From: nixa <4dmitr@gmail.com> Date: Fri, 20 May 2016 19:46:37 +0300 Subject: [PATCH] refactor(baAmChart): ViewChild instead of querying dom --- .../theme/components/baAmChart/baAmChart.component.ts | 10 +++++----- src/app/theme/components/baAmChart/baAmChart.html | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/app/theme/components/baAmChart/baAmChart.component.ts b/src/app/theme/components/baAmChart/baAmChart.component.ts index 6a3092dc..102858e3 100644 --- a/src/app/theme/components/baAmChart/baAmChart.component.ts +++ b/src/app/theme/components/baAmChart/baAmChart.component.ts @@ -1,4 +1,4 @@ -import {Component, ViewEncapsulation, Input, Output, ElementRef, EventEmitter} from '@angular/core'; +import {Component, ViewChild, ViewEncapsulation, Input, Output, ElementRef, EventEmitter} from '@angular/core'; import './baAmChart.loader.ts'; import {BaAmChartThemeService} from './baAmChartTheme.service'; @@ -15,7 +15,9 @@ export class BaAmChart { @Input() baAmChartClass:string; @Output() onChartReady = new EventEmitter(); - constructor (private _elementRef:ElementRef, private _baAmChartThemeService:BaAmChartThemeService) { + @ViewChild('baAmChart') private _selector:ElementRef; + + constructor (private _baAmChartThemeService:BaAmChartThemeService) { } ngOnInit() { @@ -23,9 +25,7 @@ export class BaAmChart { } ngAfterViewInit() { - let el = this._elementRef.nativeElement.querySelector('.ba-am-chart'); - - let chart = AmCharts.makeChart(el, this.baAmChartConfiguration); + let chart = AmCharts.makeChart(this._selector.nativeElement, this.baAmChartConfiguration); this.onChartReady.emit(chart); } } diff --git a/src/app/theme/components/baAmChart/baAmChart.html b/src/app/theme/components/baAmChart/baAmChart.html index f2fdf1be..b0997e84 100644 --- a/src/app/theme/components/baAmChart/baAmChart.html +++ b/src/app/theme/components/baAmChart/baAmChart.html @@ -1 +1 @@ -
+