Andreas/ngx-admin
1
0
Fork 0
mirror of https://github.com/akveo/ngx-admin.git synced 2025-12-16 15:40:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(Dockerfile): passing --host directly

Browse source 
Passing --host 0.0.0.0 option directly instead of editing the package.json file to hardcode it.
This commit is contained in:
Ibrahim Bali 2018-07-09 10:25:04 +03:00 • committed by GitHub
parent 619476db5c
commit 6b7a4ea4e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Dockerfile
View file

@ -6,20 +6,6 @@ WORKDIR /usr/src
COPY . .
# replace ng serve with ng serve --host 0.0.0.0 so that it serves outside
# install jq for json edit
RUN apk update \
&& apk add jq
# replace package.json
RUN input_json="package.json" \
&& tmp_json="tmp.json" \
&& jq '.scripts.start = "ng serve --host 0.0.0.0"' $input_json > $tmp_json \
&& mv $tmp_json $input_json
# remove jq
RUN apk del jq
RUN npm install
RUN npm audit fix
# running this a second time does seem to fix another vuln.
@ -29,4 +15,4 @@ RUN npm update ws --depth 4
EXPOSE 4200
CMD ["npm", "start"]
CMD ["npm", "start", "--", "--host", "0.0.0.0"]