From 6b7a4ea4e3ad6e067ae5c4e07df6d459c04eb4af Mon Sep 17 00:00:00 2001 From: Ibrahim Bali Date: Mon, 9 Jul 2018 10:25:04 +0300 Subject: [PATCH] refactor(Dockerfile): passing --host directly Passing --host 0.0.0.0 option directly instead of editing the package.json file to hardcode it. --- Dockerfile | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/Dockerfile b/Dockerfile index c9562b05..67b7f3d4 100644 --- a/Dockerfile +++ b/Dockerfile @@ -6,20 +6,6 @@ WORKDIR /usr/src COPY . . -# replace ng serve with ng serve --host 0.0.0.0 so that it serves outside -# install jq for json edit -RUN apk update \ - && apk add jq - -# replace package.json -RUN input_json="package.json" \ - && tmp_json="tmp.json" \ - && jq '.scripts.start = "ng serve --host 0.0.0.0"' $input_json > $tmp_json \ - && mv $tmp_json $input_json - -# remove jq -RUN apk del jq - RUN npm install RUN npm audit fix # running this a second time does seem to fix another vuln. @@ -29,4 +15,4 @@ RUN npm update ws --depth 4 EXPOSE 4200 -CMD ["npm", "start"] +CMD ["npm", "start", "--", "--host", "0.0.0.0"]