refactor(Conversation.js): change default pageSize from 12 to 14 in getConvosByPage and getConvosQueried functions. Remove unnecessary parentheses and curly braces in getConvosQueried function. Remove unnecessary parentheses in deleteConvos function. (#267)

This commit is contained in:
Danny Avila 2023-05-14 11:45:18 -04:00 committed by GitHub
parent 93dd1eb036
commit 5d40396fb2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -30,7 +30,7 @@ module.exports = {
return { message: 'Error saving conversation' }; return { message: 'Error saving conversation' };
} }
}, },
getConvosByPage: async (user, pageNumber = 1, pageSize = 12) => { getConvosByPage: async (user, pageNumber = 1, pageSize = 14) => {
try { try {
const totalConvos = (await Conversation.countDocuments({ user })) || 1; const totalConvos = (await Conversation.countDocuments({ user })) || 1;
const totalPages = Math.ceil(totalConvos / pageSize); const totalPages = Math.ceil(totalConvos / pageSize);
@ -45,7 +45,7 @@ module.exports = {
return { message: 'Error getting conversations' }; return { message: 'Error getting conversations' };
} }
}, },
getConvosQueried: async (user, convoIds, pageNumber = 1, pageSize = 12) => { getConvosQueried: async (user, convoIds, pageNumber = 1, pageSize = 14) => {
try { try {
if (!convoIds || convoIds.length === 0) { if (!convoIds || convoIds.length === 0) {
return { conversations: [], pages: 1, pageNumber, pageSize }; return { conversations: [], pages: 1, pageNumber, pageSize };
@ -57,7 +57,7 @@ module.exports = {
// will handle a syncing solution soon // will handle a syncing solution soon
const deletedConvoIds = []; const deletedConvoIds = [];
convoIds.forEach((convo) => convoIds.forEach(convo =>
promises.push( promises.push(
Conversation.findOne({ Conversation.findOne({
user, user,
@ -120,7 +120,7 @@ module.exports = {
}, },
deleteConvos: async (user, filter) => { deleteConvos: async (user, filter) => {
let toRemove = await Conversation.find({ ...filter, user }).select('conversationId'); let toRemove = await Conversation.find({ ...filter, user }).select('conversationId');
const ids = toRemove.map((instance) => instance.conversationId); const ids = toRemove.map(instance => instance.conversationId);
let deleteCount = await Conversation.deleteMany({ ...filter, user }).exec(); let deleteCount = await Conversation.deleteMany({ ...filter, user }).exec();
deleteCount.messages = await deleteMessages({ conversationId: { $in: ids } }); deleteCount.messages = await deleteMessages({ conversationId: { $in: ids } });
return deleteCount; return deleteCount;