From 5d40396fb2cc703b020a7af9ff2513bcfabb68d7 Mon Sep 17 00:00:00 2001 From: Danny Avila <110412045+danny-avila@users.noreply.github.com> Date: Sun, 14 May 2023 11:45:18 -0400 Subject: [PATCH] refactor(Conversation.js): change default pageSize from 12 to 14 in getConvosByPage and getConvosQueried functions. Remove unnecessary parentheses and curly braces in getConvosQueried function. Remove unnecessary parentheses in deleteConvos function. (#267) --- api/models/Conversation.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/api/models/Conversation.js b/api/models/Conversation.js index 2047071866..4b4f08708a 100644 --- a/api/models/Conversation.js +++ b/api/models/Conversation.js @@ -30,7 +30,7 @@ module.exports = { return { message: 'Error saving conversation' }; } }, - getConvosByPage: async (user, pageNumber = 1, pageSize = 12) => { + getConvosByPage: async (user, pageNumber = 1, pageSize = 14) => { try { const totalConvos = (await Conversation.countDocuments({ user })) || 1; const totalPages = Math.ceil(totalConvos / pageSize); @@ -45,7 +45,7 @@ module.exports = { return { message: 'Error getting conversations' }; } }, - getConvosQueried: async (user, convoIds, pageNumber = 1, pageSize = 12) => { + getConvosQueried: async (user, convoIds, pageNumber = 1, pageSize = 14) => { try { if (!convoIds || convoIds.length === 0) { return { conversations: [], pages: 1, pageNumber, pageSize }; @@ -57,7 +57,7 @@ module.exports = { // will handle a syncing solution soon const deletedConvoIds = []; - convoIds.forEach((convo) => + convoIds.forEach(convo => promises.push( Conversation.findOne({ user, @@ -120,7 +120,7 @@ module.exports = { }, deleteConvos: async (user, filter) => { let toRemove = await Conversation.find({ ...filter, user }).select('conversationId'); - const ids = toRemove.map((instance) => instance.conversationId); + const ids = toRemove.map(instance => instance.conversationId); let deleteCount = await Conversation.deleteMany({ ...filter, user }).exec(); deleteCount.messages = await deleteMessages({ conversationId: { $in: ids } }); return deleteCount;