Andreas/wekan
1
0
Fork 0
mirror of https://github.com/wekan/wekan.git synced 2025-09-22 01:50:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Updated Oracle OIM (markdown)

Lauri Ojansivu 2020-10-21 19:25:36 +03:00
parent b06d4fd3e6
commit e4ec085e23
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Oracle-OIM.md

@ -6,7 +6,7 @@ Here is a summary of code and changes by anonymous Wekan contributors and xet7:
- If the OAuth2 token doesn't contain the email address, Wekan raises an exception. The userinfo and servicedata were changed to avoid that.
- In the getToken function, OIM expects a POST request that contains OAUTH2_CLIENT_ID and OAUTH2_SECRET in its header. We fixed that.
- We also had to edit the app.js in order to put a custom "scope" value. But we think the target should be to be able to set this as an environment variable.
- Another point concerns OAUTH2_REQUEST_PERMISSION. It must be exactly `BDFUserProfile.me`. xet7 hardcoded it in above commit at `wekan/server/authentication.js`
- OAUTH2_REQUEST_PERMISSION can be set with environment variable for what is required at `wekan/server/authentication.js`
- There is a problem in the code when email is null or empty. I know it might not be null but we have some situation where it is. xet7 maybe fixed it in above commit so that if email is missing, it takes that value from username. When logging into Wekan with OIDC, both username and email should be mapped to email.
- TODO: Testing does everything work with these changes.