From dc2574a6ed88e8ca3c45931237b920c800809355 Mon Sep 17 00:00:00 2001 From: Lauri Ojansivu Date: Wed, 21 Oct 2020 19:29:01 +0300 Subject: [PATCH] Updated Oracle OIM (markdown) --- Oracle-OIM.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Oracle-OIM.md b/Oracle-OIM.md index 7ac17a7..d2a9bf5 100644 --- a/Oracle-OIM.md +++ b/Oracle-OIM.md @@ -1,14 +1,13 @@ ## Login with OIDC OAuth2 Oracle OIM, on premise identity manager -[Added with this commit](https://github.com/wekan/wekan/commit/ec8a78537f1dc40e967de36a02ea09cf7398318a). +[Added with this commit](https://github.com/wekan/wekan/commit/ec8a78537f1dc40e967de36a02ea09cf7398318a), and after [added change that OAUTH2_REQUEST_PERMISSION can be set freely with environment variable](https://github.com/wekan/wekan/commit/1b429b3f99c32840ebb0ff9a29015aa8c28ec644) for what is required. Here is a summary of code and changes by anonymous Wekan contributors and xet7: - If the OAuth2 token doesn't contain the email address, Wekan raises an exception. The userinfo and servicedata were changed to avoid that. - In the getToken function, OIM expects a POST request that contains OAUTH2_CLIENT_ID and OAUTH2_SECRET in its header. We fixed that. - We also had to edit the app.js in order to put a custom "scope" value. But we think the target should be to be able to set this as an environment variable. -- OAUTH2_REQUEST_PERMISSION can be set with environment variable for what is required at `wekan/server/authentication.js` -- There is a problem in the code when email is null or empty. I know it might not be null but we have some situation where it is. xet7 maybe fixed it in above commit so that if email is missing, it takes that value from username. When logging into Wekan with OIDC, both username and email should be mapped to email. -- TODO: Testing does everything work with these changes. +- There is a problem in the code when email is null or empty. I know it might not be null but we have some situation where it is. xet7 fixed it in above commit so that if email is missing, it takes that value from username. When logging into Wekan with OIDC, both username and email should be mapped to email. +- It was tested that with these changes, this works well. ### About settings