diff --git a/Oracle-OIM.md b/Oracle-OIM.md index 7251617..92308c2 100644 --- a/Oracle-OIM.md +++ b/Oracle-OIM.md @@ -1,18 +1,18 @@ ## Login with OIDC OAuth2 Oracle on premise identity manager OIM -[Added with this commit](https://github.com/wekan/wekan/commit/ec8a78537f1dc40e967de36a02ea09cf7398318a) +[Added with this commit](https://github.com/wekan/wekan/commit/ec8a78537f1dc40e967de36a02ea09cf7398318a). Here is a summary of code and changes by anonymous Wekan contributors and xet7: - If the OAuth2 token doesn't contain the email address, Wekan raises an exception. The userinfo and servicedata were changed to avoid that. - In the getToken function, OIM expects a POST request that contains OAUTH2_CLIENT_ID and OAUTH2_SECRET in its header. We fixed that. - We also had to edit the app.js in order to put a custom "scope" value. But we think the target should be to be able to set this as an environment variable. - Another point concerns OAUTH2_REQUEST_PERMISSION. It must be exactly `BDFUserProfile.me`. xet7 hardcoded it in above commit at `wekan/server/authentication.js` -- There is a problem in the code when email is null or empty. I know it might not be null but we have some situation where it is. xet7 maybe fixed it in above commit so that if email is missing, it takes that value from username. When logging into Wekan with OIDC, both username and email should be set to email. +- There is a problem in the code when email is null or empty. I know it might not be null but we have some situation where it is. xet7 maybe fixed it in above commit so that if email is missing, it takes that value from username. When logging into Wekan with OIDC, both username and email should be mapped to email. - TODO: Testing does everything work with these changes. ### About settings -Other OIDC settings are similar like in this wiki OAuth2, Google, Azure etc settings. +Other OIDC settings are similar like in this wiki OAuth2, Google, Azure etc settings. Both username and email should be mapped to email. ### Snap ```