From 28717b99485dc5685e79fb6c51ec2f66271971d9 Mon Sep 17 00:00:00 2001 From: Lauri Ojansivu Date: Mon, 24 Sep 2018 17:49:06 +0300 Subject: [PATCH] Updated Developer Documentation (markdown) --- Developer-Documentation.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Developer-Documentation.md b/Developer-Documentation.md index 01386d1..9815b24 100644 --- a/Developer-Documentation.md +++ b/Developer-Documentation.md @@ -26,6 +26,12 @@ Please read the meteor style guide before making any significant contribution. - When doing pull requests, only add additions and changes to English at wekan/i18n/en.i18n.json . Other translations are done at [https://www.transifex.com/wekan/wekan](https://www.transifex.com/wekan/wekan). - If you have fix to some existing pull request, add your fix as comment. Do not post new pull request. - For new features add new pull request, if there is none already. +- remove all console.log statements +- [Fix all lint errors and warnings](https://github.com/wekan/wekan/wiki/Developer-Documentation#preventing-travis-ci-lint-errors-before-submitting-pull-requests) +- [Add Snap settings to code](https://github.com/wekan/wekan/wiki/Adding-new-Snap-settings-to-code) so that CAS is default disabled, and can be enabled with Snap commands +- [Add Snap settings to wiki](https://github.com/wekan/wekan-snap/wiki/Supported-settings-keys) +- Add settings also to [Dockerfile](https://github.com/wekan/wekan/blob/edge/Dockerfile) +- [Make your pull request to edge branch](https://github.com/wekan/wekan/wiki/Developer-Documentation#pull-request-workflow-please-read-before-submitting-prs) with all of CAS code included. I will soon remove CAS from stable, because CAS if not fully tested yet. - Use the [feature branch](https://www.atlassian.com/git/tutorials/comparing-workflows#feature-branch-workflow) workflow. - create a PR from your feature-branch to `wekan/edge` directly so that you can continue your work without interruption. - Keep your local forks updated with this repo by setting your `git upstream` value as described [here](https://robots.thoughtbot.com/keeping-a-github-fork-updated).