Import members: working on card import

This commit is contained in:
Xavier Priour 2015-11-13 15:52:14 +01:00
parent a7427b9ae4
commit f6f41270de
3 changed files with 84 additions and 42 deletions

View file

@ -4,6 +4,11 @@ template(name="importPopup")
form form
p: label(for='import-textarea') {{_ getLabel}} p: label(for='import-textarea') {{_ getLabel}}
textarea#import-textarea.js-import-json(placeholder="{{_ 'import-json-placeholder'}}" autofocus) textarea#import-textarea.js-import-json(placeholder="{{_ 'import-json-placeholder'}}" autofocus)
| {{jsonText}}
if membersMapping
div
a.show-mapping
| {{_ 'show-mapping'}}
input.primary.wide(type="submit" value="{{_ 'import'}}") input.primary.wide(type="submit" value="{{_ 'import'}}")
template(name="mapMembersPopup") template(name="mapMembersPopup")
@ -24,7 +29,7 @@ template(name="mapMembersPopup")
a.member.add-member.js-add-members a.member.add-member.js-add-members
i.fa.fa-plus i.fa.fa-plus
form form
input.primary.wide(type="submit" value="{{_ 'import'}}") input.primary.wide(type="submit" value="{{_ 'done'}}")
template(name="addMemberPopup") template(name="addMemberPopup")
@ -36,7 +41,7 @@ template(name="mapMembersAddPopup")
ul.pop-over-list ul.pop-over-list
+esEach(index="users") +esEach(index="users")
li.item.js-member-item li.item.js-member-item
a.name.js-select-member(title="{{profile.name}} ({{username}})" data-id="{{_id}}") a.name.js-select-import(title="{{profile.name}} ({{username}})" data-id="{{_id}}")
+userAvatar(userId=_id esSearch=true) +userAvatar(userId=_id esSearch=true)
span.full-name span.full-name
= profile.name = profile.name

View file

@ -11,6 +11,14 @@ const ImportPopup = BlazeComponent.extendComponent({
return 'importPopup'; return 'importPopup';
}, },
jsonText() {
return Session.get('import.text');
},
membersMapping() {
return Session.get('import.membersToMap');
},
onCreated() { onCreated() {
this.error = new ReactiveVar(''); this.error = new ReactiveVar('');
this.dataToImport = ''; this.dataToImport = '';
@ -20,9 +28,21 @@ const ImportPopup = BlazeComponent.extendComponent({
Popup.close(); Popup.close();
}, },
onShowMapping(evt) {
// todo xxx make it work - currently we don't find the text
// this._storeText(evt);
Popup.open('mapMembers')(evt);
},
_storeText(evt) {
const dataJson = $(evt.currentTarget).find('.js-import-json').val();
Session.set('import.text', dataJson);
return dataJson;
},
onSubmit(evt){ onSubmit(evt){
evt.preventDefault(); evt.preventDefault();
const dataJson = $(evt.currentTarget).find('.js-import-json').val(); const dataJson = this._storeText(evt);
let dataObject; let dataObject;
try { try {
dataObject = JSON.parse(dataJson); dataObject = JSON.parse(dataJson);
@ -31,18 +51,14 @@ const ImportPopup = BlazeComponent.extendComponent({
this.setError('error-json-malformed'); this.setError('error-json-malformed');
return; return;
} }
// if there are members listed in the import, we need to map them // if there are members listed in the import and we have no mapping for them...
if(dataObject.members.length > 0) { if(dataObject.members.length > 0 && !this.membersMapping()) {
// we will work on the list itself (an ordered array of POJO) // we will work on the list itself (an ordered array of POJO)
// when a mapping is done, we add a 'wekan' field to the POJO representing the imported member // when a mapping is done, we add a 'wekan' field to the POJO representing the imported member
const membersToMap = dataObject.members; const membersToMap = dataObject.members;
// todo save initial import object - to save later, on mapping submission
// this.data().toImport = dataObject;
// auto-map based on username // auto-map based on username
const wekanMembers = Users;
membersToMap.forEach((importedMember) => { membersToMap.forEach((importedMember) => {
const wekanUser = Users.findOne({username: importedMember.username}) const wekanUser = Users.findOne({username: importedMember.username});
if(wekanUser) { if(wekanUser) {
importedMember.wekan = wekanUser; importedMember.wekan = wekanUser;
} }
@ -52,7 +68,20 @@ const ImportPopup = BlazeComponent.extendComponent({
Session.set('import.membersToMap', membersToMap); Session.set('import.membersToMap', membersToMap);
Popup.open('mapMembers')(evt); Popup.open('mapMembers')(evt);
} else { } else {
Meteor.call(this.getMethodName(), dataObject, this.getAdditionalData(), const additionalData = this.getAdditionalData();
const membersMapping = this.membersMapping();
if(membersMapping) {
const mappingById = {};
membersMapping.forEach((member) => {
if (member.wekan) {
mappingById[member.id] = member.wekan._id;
}
});
additionalData.membersMapping = mappingById;
}
Session.set('import.membersToMap', null);
Session.set('import.text', null);
Meteor.call(this.getMethodName(), dataObject, additionalData,
(error, response) => { (error, response) => {
if (error) { if (error) {
this.setError(error.error); this.setError(error.error);
@ -69,6 +98,7 @@ const ImportPopup = BlazeComponent.extendComponent({
events() { events() {
return [{ return [{
submit: this.onSubmit, submit: this.onSubmit,
'click .show-mapping': this.onShowMapping,
}]; }];
}, },
@ -144,7 +174,7 @@ const ImportMapMembers = BlazeComponent.extendComponent({
listOfMembers.forEach((member) => { listOfMembers.forEach((member) => {
if(finder(member)) { if(finder(member)) {
if(value !== null) { if(value !== null) {
member[property] = true; member[property] = value;
} else { } else {
delete member[property]; delete member[property];
} }
@ -152,10 +182,8 @@ const ImportMapMembers = BlazeComponent.extendComponent({
// we shortcut if we don't care about unsetting the others // we shortcut if we don't care about unsetting the others
return false; return false;
} }
} else { } else if(unset) {
if(unset) { delete member[property];
delete member[property];
}
} }
return true; return true;
}); });
@ -188,47 +216,40 @@ const ImportMapMembers = BlazeComponent.extendComponent({
}); });
ImportMapMembers.extendComponent({ ImportMapMembers.extendComponent({
onSelectMember(evt) { onMapMember(evt) {
const memberToMap = this.currentData(); const memberToMap = this.currentData();
this.setSelectedMember(memberToMap.id); if(memberToMap.wekan) {
console.log(`selected member#${memberToMap.id}`); // todo xxx ask for confirmation?
Popup.open('mapMembersAdd')(evt); this.unmapMember(memberToMap.id);
}, } else {
onRemove(evt){ this.setSelectedMember(memberToMap.id);
const userId = this.currentData()._id; Popup.open('mapMembersAdd')(evt);
console.log(`confirm and then call unmapMember ${userId}`); }
}, },
onSubmit(evt) { onSubmit(evt) {
console.log("Mapping:"); evt.preventDefault();
console.log(this.members()); Popup.back();
}, },
events() { events() {
return [{ return [{
'submit': this.onSubmit, 'submit': this.onSubmit,
'click .js-add-members': this.onSelectMember, 'click .mapping': this.onMapMember,
'click .js-member': this.onRemove,
}]; }];
}, },
}).register('mapMembersPopup'); }).register('mapMembersPopup');
ImportMapMembers.extendComponent({ ImportMapMembers.extendComponent({
//template() {
// return "mapMembersAddPopup";
//},
onSelectUser(){ onSelectUser(){
const wekanUser = this.currentData(); this.mapSelectedMember(this.currentData());
console.log(`clicked on ${wekanUser._id}`); Popup.back();
console.log(wekanUser);
//this.mapSelectedMember(this.currentData());
}, },
events() { events() {
return [{ return [{
//'click .js-select-member': this.onSelectUser(), 'click .js-select-import': this.onSelectUser,
}]; }];
}, },
onRendered() { onRendered() {
console.log('rendered'); // todo XXX why do I not get the focus??
// todo XXX why do I not focus?? this.find('.js-map-member input').focus();
$('.js-map-member input').focus();
}, },
}).register('mapMembersAddPopup'); }).register('mapMembersAddPopup');

View file

@ -4,7 +4,7 @@ const DateString = Match.Where(function (dateAsString) {
}); });
class TrelloCreator { class TrelloCreator {
constructor() { constructor(data) {
// The object creation dates, indexed by Trello id (so we only parse actions // The object creation dates, indexed by Trello id (so we only parse actions
// once!) // once!)
this.createdAt = { this.createdAt = {
@ -18,6 +18,8 @@ class TrelloCreator {
this.lists = {}; this.lists = {};
// The comments, indexed by Trello card id (to map when importing cards) // The comments, indexed by Trello card id (to map when importing cards)
this.comments = {}; this.comments = {};
// the members, indexed by Trello member id => Wekan user ID
this.members = data.membersMapping ? data.membersMapping : {};
} }
checkActions(trelloActions) { checkActions(trelloActions) {
@ -191,6 +193,19 @@ class TrelloCreator {
return this.labels[trelloId]; return this.labels[trelloId];
}); });
} }
// add members {
if(card.idMembers) {
const wekanMembers = [];
// we can't just map, as some members may not have been mapped
card.idMembers.forEach((id) => {
if(this.members[id]) {
wekanMembers.push(this.members[id]);
}
});
if(wekanMembers.length>0) {
cardToCreate.members = wekanMembers;
}
}
// insert card // insert card
const cardId = Cards.direct.insert(cardToCreate); const cardId = Cards.direct.insert(cardToCreate);
// log activity // log activity
@ -298,7 +313,7 @@ class TrelloCreator {
Meteor.methods({ Meteor.methods({
importTrelloBoard(trelloBoard, data) { importTrelloBoard(trelloBoard, data) {
const trelloCreator = new TrelloCreator(); const trelloCreator = new TrelloCreator(data);
// 1. check all parameters are ok from a syntax point of view // 1. check all parameters are ok from a syntax point of view
try { try {
@ -326,13 +341,14 @@ Meteor.methods({
}, },
importTrelloCard(trelloCard, data) { importTrelloCard(trelloCard, data) {
const trelloCreator = new TrelloCreator(); const trelloCreator = new TrelloCreator(data);
// 1. check parameters are ok from a syntax point of view // 1. check parameters are ok from a syntax point of view
try { try {
check(data, { check(data, {
listId: String, listId: String,
sortIndex: Number, sortIndex: Number,
membersMapping: Match.Optional(Object),
}); });
trelloCreator.checkCards([trelloCard]); trelloCreator.checkCards([trelloCard]);
trelloCreator.checkLabels(trelloCard.labels); trelloCreator.checkLabels(trelloCard.labels);