From 0a8adf4b511d4609f8b60b82271ab2f0b6f00e00 Mon Sep 17 00:00:00 2001 From: omri zaher Date: Sat, 9 Aug 2025 19:32:47 +0300 Subject: [PATCH 1/5] Remove unused json import in test_board.py --- tests/board/test_board.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/board/test_board.py b/tests/board/test_board.py index a5813ccb9..45c22fba9 100644 --- a/tests/board/test_board.py +++ b/tests/board/test_board.py @@ -1,6 +1,5 @@ import pytest import requests -import json base_url = "http://10.0.0.17" class TestBoard: From 39882bbafcbfa5d4c494c9de29ea1069f910e9a5 Mon Sep 17 00:00:00 2001 From: omri zaher Date: Sun, 10 Aug 2025 09:47:20 +0300 Subject: [PATCH 2/5] Refactor Chrome and ChromeDriver installation in UI testing workflow --- .github/workflows/ui-testing.yml | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ui-testing.yml b/.github/workflows/ui-testing.yml index 04a69e5a8..e01f5eff3 100644 --- a/.github/workflows/ui-testing.yml +++ b/.github/workflows/ui-testing.yml @@ -30,8 +30,29 @@ jobs: - name: Install Chrome and ChromeDriver run: | - sudo apt-get update - sudo apt-get install -y google-chrome-stable + sudo apt update + sudo apt install -y wget unzip xvfb libxi6 libgbm-dev libnss3 libxshmfence1 libasound2t64 + + # Download and install latest stable Google Chrome + wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb + sudo apt install -y ./google-chrome-stable_current_amd64.deb + + # Get Chrome version number like "139.0.7258.66" + CHROME_VERSION=$(google-chrome --version | grep -oP "\d+\.\d+\.\d+\.\d+") + + # Download matching ChromeDriver from official "chrome-for-testing" bucket (preferred) + wget -q -O chromedriver.zip "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/${CHROME_VERSION}/linux64/chromedriver-linux64.zip" + + # Unzip ChromeDriver, then move binary correctly (handles folder name) + unzip chromedriver.zip + mv */chromedriver /usr/local/bin/chromedriver + sudo chmod +x /usr/local/bin/chromedriver + + # Clean up + rm -rf chromedriver.zip google-chrome-stable_current_amd64.deb + + # Create temporary directories for Chrome user data + mkdir -p /tmp/chrome-user-data - name: Run Selenium tests env: From a3b0a7671fb8e5df96584b089e29a0f80b9607f5 Mon Sep 17 00:00:00 2001 From: omri zaher Date: Sun, 10 Aug 2025 09:55:18 +0300 Subject: [PATCH 3/5] Simplify Chrome and ChromeDriver installation in UI testing workflow --- .github/workflows/ui-testing.yml | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/.github/workflows/ui-testing.yml b/.github/workflows/ui-testing.yml index e01f5eff3..04a69e5a8 100644 --- a/.github/workflows/ui-testing.yml +++ b/.github/workflows/ui-testing.yml @@ -30,29 +30,8 @@ jobs: - name: Install Chrome and ChromeDriver run: | - sudo apt update - sudo apt install -y wget unzip xvfb libxi6 libgbm-dev libnss3 libxshmfence1 libasound2t64 - - # Download and install latest stable Google Chrome - wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb - sudo apt install -y ./google-chrome-stable_current_amd64.deb - - # Get Chrome version number like "139.0.7258.66" - CHROME_VERSION=$(google-chrome --version | grep -oP "\d+\.\d+\.\d+\.\d+") - - # Download matching ChromeDriver from official "chrome-for-testing" bucket (preferred) - wget -q -O chromedriver.zip "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/${CHROME_VERSION}/linux64/chromedriver-linux64.zip" - - # Unzip ChromeDriver, then move binary correctly (handles folder name) - unzip chromedriver.zip - mv */chromedriver /usr/local/bin/chromedriver - sudo chmod +x /usr/local/bin/chromedriver - - # Clean up - rm -rf chromedriver.zip google-chrome-stable_current_amd64.deb - - # Create temporary directories for Chrome user data - mkdir -p /tmp/chrome-user-data + sudo apt-get update + sudo apt-get install -y google-chrome-stable - name: Run Selenium tests env: From d2bab41e461465cd87b67f826c95b613b1f31684 Mon Sep 17 00:00:00 2001 From: omri zaher Date: Sun, 10 Aug 2025 11:02:55 +0300 Subject: [PATCH 4/5] Fix formatting in README.md by removing unnecessary line breaks --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index d28dc0edb..df38b941b 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ docker-compose.yml at https://github.com/wekan/wekan/blob/main/docker-compose.ym - [WeKan and Standard for Public Code](https://wekan.fi/standard-for-public-code/) assessment was made at 2023-11. Currently Wekan meets 8 out of 16 criteria out of the box. - Some others could be met with small changes. + Some others could be met with small changes ## Code stats @@ -49,6 +49,7 @@ See bottom of https://github.com/wekan/wekan/issues/3874 ## FAQ **NOTE**: + - Please read the [FAQ](https://github.com/wekan/wekan/blob/main/docs/FAQ/FAQ.md) first - Please don't feed the [trolls](https://github.com/wekan/wekan/blob/main/docs/FAQ/FAQ.md#why-am-i-called-a-troll) and [spammers](https://github.com/wekan/wekan/blob/main/docs/FAQ/FAQ.md#why-am-i-called-a-spammer) that are mentioned in the FAQ :) From 8403cb806c51046475f3d0f72114a2b2a39409d4 Mon Sep 17 00:00:00 2001 From: omri zaher Date: Sun, 10 Aug 2025 13:19:43 +0300 Subject: [PATCH 5/5] Add debug step to output WEKAN_URL in UI testing workflow --- .github/workflows/ui-testing.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ui-testing.yml b/.github/workflows/ui-testing.yml index 04a69e5a8..2a3d765d7 100644 --- a/.github/workflows/ui-testing.yml +++ b/.github/workflows/ui-testing.yml @@ -33,6 +33,12 @@ jobs: sudo apt-get update sudo apt-get install -y google-chrome-stable + - name: Debug WEKAN_URL + run: | + echo "WEKAN_URL: ${WEKAN_URL}" + env: + WEKAN_URL: ${{ secrets.WEKAN_URL }} + - name: Run Selenium tests env: HEADLESS: true