Andreas/wekan
1
0
Fork 0
mirror of https://github.com/wekan/wekan.git synced 2025-12-16 23:40:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Don't interpret dragging an element as a click

Browse source 
Remove `enableClickOnTouch` as this behavior is not intuitive.
This commit is contained in:
Marc Hartmayer 2020-04-24 22:41:24 +02:00
parent 6d1cdebfe2
commit f1b18d79cd
6 changed files with 6 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

5
client/components/boards/boardBody.js
View file

@ -1,7 +1,7 @@
import { Cookies } from 'meteor/ostrio:cookies'; import { Cookies } from 'meteor/ostrio:cookies';
const cookies = new Cookies(); const cookies = new Cookies();
const subManager = new SubsManager(); const subManager = new SubsManager();
const { calculateIndex, enableClickOnTouch } = Utils; const { calculateIndex } = Utils;
const swimlaneWhileSortingHeight = 150; const swimlaneWhileSortingHeight = 150;
BlazeComponent.extendComponent({ BlazeComponent.extendComponent({
@ -191,9 +191,6 @@ BlazeComponent.extendComponent({
}, },
}); });
// ugly touch event hotfix
enableClickOnTouch('.js-swimlane:not(.placeholder)');
this.autorun(() => { this.autorun(() => {
let showDesktopDragHandles = false; let showDesktopDragHandles = false;
currentUser = Meteor.user(); currentUser = Meteor.user();

5
client/components/boards/boardsList.js
View file

@ -1,5 +1,5 @@
const subManager = new SubsManager(); const subManager = new SubsManager();
const { calculateIndex, enableClickOnTouch } = Utils; const { calculateIndex } = Utils;
Template.boardListHeaderBar.events({ Template.boardListHeaderBar.events({
'click .js-open-archived-board'() { 'click .js-open-archived-board'() {
@ -68,9 +68,6 @@ BlazeComponent.extendComponent({
}, },
}); });
// ugly touch event hotfix
enableClickOnTouch(itemsSelector);
// Disable drag-dropping if the current user is not a board member or is comment only // Disable drag-dropping if the current user is not a board member or is comment only
this.autorun(() => { this.autorun(() => {
$boards.sortable('option', 'disabled', !userIsAllowedToMove()); $boards.sortable('option', 'disabled', !userIsAllowedToMove());

8
client/components/cards/cardDetails.js
View file

@ -1,5 +1,5 @@
const subManager = new SubsManager(); const subManager = new SubsManager();
const { calculateIndexData, enableClickOnTouch } = Utils; const { calculateIndexData } = Utils;
let cardColors; let cardColors;
Meteor.startup(() => { Meteor.startup(() => {
@ -231,9 +231,6 @@ BlazeComponent.extendComponent({
}, },
}); });
// ugly touch event hotfix
enableClickOnTouch('.card-checklist-items .js-checklist');
const $subtasksDom = this.$('.card-subtasks-items'); const $subtasksDom = this.$('.card-subtasks-items');
$subtasksDom.sortable({ $subtasksDom.sortable({
@ -269,9 +266,6 @@ BlazeComponent.extendComponent({
}, },
}); });
// ugly touch event hotfix
enableClickOnTouch('.card-subtasks-items .js-subtasks');
function userIsMember() { function userIsMember() {
return Meteor.user() && Meteor.user().isBoardMember(); return Meteor.user() && Meteor.user().isBoardMember();
} }

5
client/components/cards/checklists.js
View file

@ -1,4 +1,4 @@
const { calculateIndexData, enableClickOnTouch, capitalize } = Utils; const { calculateIndexData, capitalize } = Utils;
function initSorting(items) { function initSorting(items) {
items.sortable({ items.sortable({
@ -36,9 +36,6 @@ function initSorting(items) {
checklistItem.move(checklistId, sortIndex.base); checklistItem.move(checklistId, sortIndex.base);
}, },
}); });
// ugly touch event hotfix
enableClickOnTouch('.js-checklist-item:not(.placeholder)');
} }
BlazeComponent.extendComponent({ BlazeComponent.extendComponent({

5
client/components/lists/list.js
View file

@ -1,6 +1,6 @@
import { Cookies } from 'meteor/ostrio:cookies'; import { Cookies } from 'meteor/ostrio:cookies';
const cookies = new Cookies(); const cookies = new Cookies();
const { calculateIndex, enableClickOnTouch } = Utils; const { calculateIndex } = Utils;
BlazeComponent.extendComponent({ BlazeComponent.extendComponent({
// Proxy // Proxy
@ -114,9 +114,6 @@ BlazeComponent.extendComponent({
}, },
}); });
// ugly touch event hotfix
enableClickOnTouch(itemsSelector);
this.autorun(() => { this.autorun(() => {
let showDesktopDragHandles = false; let showDesktopDragHandles = false;
currentUser = Meteor.user(); currentUser = Meteor.user();

5
client/components/swimlanes/swimlanes.js
View file

@ -1,6 +1,6 @@
import { Cookies } from 'meteor/ostrio:cookies'; import { Cookies } from 'meteor/ostrio:cookies';
const cookies = new Cookies(); const cookies = new Cookies();
const { calculateIndex, enableClickOnTouch } = Utils; const { calculateIndex } = Utils;
function currentListIsInThisSwimlane(swimlaneId) { function currentListIsInThisSwimlane(swimlaneId) {
const currentList = Lists.findOne(Session.get('currentList')); const currentList = Lists.findOne(Session.get('currentList'));
@ -87,9 +87,6 @@ function initSortable(boardComponent, $listsDom) {
}, },
}); });
// ugly touch event hotfix
enableClickOnTouch('.js-list:not(.js-list-composer)');
function userIsMember() { function userIsMember() {
return ( return (
Meteor.user() && Meteor.user() &&