diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce29cfb7e..b444bf1dd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,13 @@
+# Upcoming Wekan release
+
+This release adds the following new features:
+
+- [Improve authentication](https://github.com/wekan/wekan/pull/2065): remove login dropdown,
+ and add setting `DEFAULT_AUTHENTICATION_METHOD=ldap` or
+ `sudo snap set wekan default-authentication-method='ldap'`. Thanks to Akuket. Closes wekan/wekan-ldap#31
+
+Thanks to above GitHub users for their contributions.
+
# v1.94 2018-12-18 Wekan version
This release adds the following new features:
diff --git a/Dockerfile b/Dockerfile
index 1383883e7..b64b124ad 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -70,6 +70,7 @@ ARG LOGOUT_IN
ARG LOGOUT_ON_HOURS
ARG LOGOUT_ON_MINUTES
ARG CORS
+ARG DEFAULT_AUTHENTICATION_METHOD
# Set the environment variables (defaults where required)
# DOES NOT WORK: paxctl fix for alpine linux: https://github.com/wekan/wekan/issues/1303
@@ -142,7 +143,8 @@ ENV BUILD_DEPS="apt-utils bsdtar gnupg gosu wget curl bzip2 build-essential pyth
LOGOUT_IN="" \
LOGOUT_ON_HOURS="" \
LOGOUT_ON_MINUTES="" \
- CORS=""
+ CORS="" \
+ DEFAULT_AUTHENTICATION_METHOD=""
# Copy the app to the image
COPY ${SRC_PATH} /home/wekan/app
diff --git a/client/components/main/editor.js b/client/components/main/editor.js
index 20ece5622..152f69e2a 100755
--- a/client/components/main/editor.js
+++ b/client/components/main/editor.js
@@ -9,10 +9,12 @@ Template.editor.onRendered(() => {
match: /\B@([\w.]*)$/,
search(term, callback) {
const currentBoard = Boards.findOne(Session.get('currentBoard'));
- callback(currentBoard.activeMembers().map((member) => {
- const username = Users.findOne(member.userId).username;
- return username.includes(term) ? username : null;
- }).filter(Boolean));
+ if (currentBoard) {
+ callback(currentBoard.activeMembers().map((member) => {
+ const username = Users.findOne(member.userId).username;
+ return username.includes(term) ? username : null;
+ }).filter(Boolean));
+ }
},
template(value) {
return value;
@@ -37,6 +39,9 @@ const at = HTML.CharRef({html: '@', str: '@'});
Blaze.Template.registerHelper('mentions', new Template('mentions', function() {
const view = this;
const currentBoard = Boards.findOne(Session.get('currentBoard'));
+ if (!currentBoard) {
+ return HTML.Raw('');
+ }
const knowedUsers = currentBoard.members.map((member) => {
const u = Users.findOne(member.userId);
if(u){
diff --git a/client/components/main/layouts.jade b/client/components/main/layouts.jade
index 55ee2686a..1c22fee6c 100644
--- a/client/components/main/layouts.jade
+++ b/client/components/main/layouts.jade
@@ -23,7 +23,6 @@ template(name="userFormsLayout")
br
section.auth-dialog
+Template.dynamic(template=content)
- +connectionMethod
if isCas
.at-form
button#cas(class='at-btn submit' type='submit') {{casSignInLabel}}
diff --git a/client/components/main/layouts.js b/client/components/main/layouts.js
index a50d167e3..89dcca2df 100644
--- a/client/components/main/layouts.js
+++ b/client/components/main/layouts.js
@@ -6,29 +6,14 @@ const i18nTagToT9n = (i18nTag) => {
return i18nTag;
};
-const validator = {
- set(obj, prop, value) {
- if (prop === 'state' && value !== 'signIn') {
- $('.at-form-authentication').hide();
- } else if (prop === 'state' && value === 'signIn') {
- $('.at-form-authentication').show();
- }
- // The default behavior to store the value
- obj[prop] = value;
- // Indicate success
- return true;
- },
-};
-
-Template.userFormsLayout.onCreated(() => {
+Template.userFormsLayout.onCreated(function() {
+ Meteor.call('getDefaultAuthenticationMethod', (error, result) => {
+ this.data.defaultAuthenticationMethod = new ReactiveVar(error ? undefined : result);
+ });
Meteor.subscribe('setting');
-
});
Template.userFormsLayout.onRendered(() => {
-
- AccountsTemplates.state.form.keys = new Proxy(AccountsTemplates.state.form.keys, validator);
-
const i18nTag = navigator.language;
if (i18nTag) {
T9n.setLanguage(i18nTagToT9n(i18nTag));
@@ -101,13 +86,11 @@ Template.userFormsLayout.events({
}
});
},
- 'click #at-btn'(event) {
- /* All authentication method can be managed/called here.
- !! DON'T FORGET to correctly fill the fields of the user during its creation if necessary authenticationMethod : String !!
- */
- const authenticationMethodSelected = $('.select-authentication').val();
- // Local account
- if (authenticationMethodSelected === 'password') {
+ 'click #at-btn'(event, instance) {
+ const email = $('#at-field-username_and_email').val();
+ const password = $('#at-field-password').val();
+
+ if (FlowRouter.getRouteName() !== 'atSignIn' || password === '' || email === '') {
return;
}
@@ -115,29 +98,11 @@ Template.userFormsLayout.events({
event.preventDefault();
event.stopImmediatePropagation();
- const email = $('#at-field-username_and_email').val();
- const password = $('#at-field-password').val();
-
- // Ldap account
- if (authenticationMethodSelected === 'ldap') {
- // Check if the user can use the ldap connection
- Meteor.subscribe('user-authenticationMethod', email, {
- onReady() {
- const user = Users.findOne();
- if (user === undefined || user.authenticationMethod === 'ldap') {
- // Use the ldap connection package
- Meteor.loginWithLDAP(email, password, function(error) {
- if (!error) {
- // Connection
- return FlowRouter.go('/');
- }
- return error;
- });
- }
- return this.stop();
- },
- });
- }
+ Meteor.subscribe('user-authenticationMethod', email, {
+ onReady() {
+ return authentication.call(this, instance, email, password);
+ },
+ });
},
});
@@ -146,3 +111,49 @@ Template.defaultLayout.events({
Modal.close();
},
});
+
+function authentication(instance, email, password) {
+ const user = Users.findOne();
+
+ // Authentication with password
+ if (user && user.authenticationMethod === 'password') {
+ $('#at-pwd-form').submit();
+ return this.stop();
+ }
+
+ const authenticationMethod = user
+ ? user.authenticationMethod
+ : instance.data.defaultAuthenticationMethod.get();
+
+ switch (authenticationMethod) {
+ case 'ldap':
+ // Use the ldap connection package
+ Meteor.loginWithLDAP(email, password, function(error) {
+ if (error) {
+ displayError('error-ldap-login');
+ return this.stop();
+ } else {
+ return FlowRouter.go('/');
+ }
+ });
+ break;
+
+ default:
+ displayError('error-undefined');
+ }
+
+ return this.stop();
+}
+
+function displayError(code) {
+ const translated = TAPi18n.__(code);
+
+ if (translated === code) {
+ return;
+ }
+
+ if(!$('.at-error').length) {
+ $('.at-pwd-form').before('
');
+ }
+ $('.at-error p').text(translated);
+}
diff --git a/client/components/settings/connectionMethod.jade b/client/components/settings/connectionMethod.jade
deleted file mode 100644
index ac4c8c642..000000000
--- a/client/components/settings/connectionMethod.jade
+++ /dev/null
@@ -1,6 +0,0 @@
-template(name='connectionMethod')
- div.at-form-authentication
- label {{_ 'authentication-method'}}
- select.select-authentication
- each authentications
- option(value="{{value}}") {{_ value}}
diff --git a/client/components/settings/connectionMethod.js b/client/components/settings/connectionMethod.js
deleted file mode 100644
index 9fe8f382d..000000000
--- a/client/components/settings/connectionMethod.js
+++ /dev/null
@@ -1,34 +0,0 @@
-Template.connectionMethod.onCreated(function() {
- this.authenticationMethods = new ReactiveVar([]);
-
- Meteor.call('getAuthenticationsEnabled', (_, result) => {
- if (result) {
- // TODO : add a management of different languages
- // (ex {value: ldap, text: TAPi18n.__('ldap', {}, T9n.getLanguage() || 'en')})
- this.authenticationMethods.set([
- {value: 'password'},
- // Gets only the authentication methods availables
- ...Object.entries(result).filter((e) => e[1]).map((e) => ({value: e[0]})),
- ]);
- }
-
- // If only the default authentication available, hides the select boxe
- const content = $('.at-form-authentication');
- if (!(this.authenticationMethods.get().length > 1)) {
- content.hide();
- } else {
- content.show();
- }
- });
-});
-
-Template.connectionMethod.onRendered(() => {
- // Moves the select boxe in the first place of the at-pwd-form div
- $('.at-form-authentication').detach().prependTo('.at-pwd-form');
-});
-
-Template.connectionMethod.helpers({
- authentications() {
- return Template.instance().authenticationMethods.get();
- },
-});
diff --git a/docker-compose-build.yml b/docker-compose-build.yml
index a3ee2bd64..d72769484 100644
--- a/docker-compose-build.yml
+++ b/docker-compose-build.yml
@@ -223,6 +223,9 @@ services:
# LOGOUT_ON_MINUTES : The number of minutes
# example : LOGOUT_ON_MINUTES=55
#- LOGOUT_ON_MINUTES=
+ # DEFAULT_AUTHENTICATION_METHOD : The default authentication method used if a user does not exist to create and authenticate. Method can be password or ldap.
+ # example : DEFAULT_AUTHENTICATION_METHOD=ldap
+ #- DEFAULT_AUTHENTICATION_METHOD=
depends_on:
- wekandb
diff --git a/docker-compose-postgresql.yml b/docker-compose-postgresql.yml
index ab15d978c..215dc7d56 100644
--- a/docker-compose-postgresql.yml
+++ b/docker-compose-postgresql.yml
@@ -245,6 +245,9 @@ services:
# LOGOUT_ON_MINUTES : The number of minutes
# example : LOGOUT_ON_MINUTES=55
#- LOGOUT_ON_MINUTES=
+ # DEFAULT_AUTHENTICATION_METHOD : The default authentication method used if a user does not exist to create and authenticate. . Method can be password or ldap.
+ # example : DEFAULT_AUTHENTICATION_METHOD=ldap
+ #- DEFAULT_AUTHENTICATION_METHOD=
depends_on:
- mongodb
diff --git a/docker-compose.yml b/docker-compose.yml
index 0cb58cffe..7d7bf9d10 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -212,6 +212,9 @@ services:
# LOGOUT_ON_MINUTES : The number of minutes
# example : LOGOUT_ON_MINUTES=55
#- LOGOUT_ON_MINUTES=
+ # DEFAULT_AUTHENTICATION_METHOD : The default authentication method used if a user does not exist to create and authenticate. Method can be password or ldap.
+ # example : DEFAULT_AUTHENTICATION_METHOD=ldap
+ #- DEFAULT_AUTHENTICATION_METHOD=
depends_on:
- wekandb
diff --git a/i18n/ar.i18n.json b/i18n/ar.i18n.json
index e19f9b40f..a2692e96f 100644
--- a/i18n/ar.i18n.json
+++ b/i18n/ar.i18n.json
@@ -619,5 +619,7 @@
"layout": "Layout",
"hide-logo": "Hide Logo",
"add-custom-html-after-body-start": "Add Custom HTML after start",
- "add-custom-html-before-body-end": "Add Custom HTML before end"
+ "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before Anfang hinzu",
- "add-custom-html-before-body-end": "Füge benutzerdefiniertes HTML vor start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before ",
- "add-custom-html-before-body-end": "Añade HTML personalizado después de start",
- "add-custom-html-before-body-end": "Add Custom HTML before شروع",
- "add-custom-html-before-body-end": "افزودن کد های HTML قبل از alun jälkeen",
- "add-custom-html-before-body-end": "Lisä HTML ennen start",
- "add-custom-html-before-body-end": "Add Custom HTML before ",
+ "add-custom-html-before-body-end": "Ajouter le HTML personnalisé avant la fin du start",
- "add-custom-html-before-body-end": "Add Custom HTML before .",
- "add-custom-html-before-body-end": "הוספת קוד HTML מותאם אישית בסוף ה start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before ",
- "add-custom-html-before-body-end": "Добавить HTML до завершения start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before start",
- "add-custom-html-before-body-end": "Add Custom HTML before 之前",
- "add-custom-html-before-body-end": "添加定制的HTML在结束 start",
- "add-custom-html-before-body-end": "Add Custom HTML before