diff --git a/client/components/boards/boardBody.js b/client/components/boards/boardBody.js index 0195bb545..ad1078369 100644 --- a/client/components/boards/boardBody.js +++ b/client/components/boards/boardBody.js @@ -191,21 +191,11 @@ BlazeComponent.extendComponent({ }); this.autorun(() => { - let showDesktopDragHandles = false; - currentUser = Meteor.user(); - if (currentUser) { - showDesktopDragHandles = (currentUser.profile || {}) - .showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - showDesktopDragHandles = true; - } else { - showDesktopDragHandles = false; - } - if (Utils.isMiniScreen() || showDesktopDragHandles) { + if (Utils.isMiniScreenOrShowDesktopDragHandles()) { $swimlanesDom.sortable({ handle: '.js-swimlane-header-handle', }); - } else if (!Utils.isMiniScreen() && !showDesktopDragHandles) { + } else if (!Utils.isMiniScreen() && !Utils.isShowDesktopDragHandles()) { $swimlanesDom.sortable({ handle: '.swimlane-header', }); diff --git a/client/components/cards/minicard.jade b/client/components/cards/minicard.jade index e804b3e4c..d222ec925 100644 --- a/client/components/cards/minicard.jade +++ b/client/components/cards/minicard.jade @@ -3,13 +3,9 @@ template(name="minicard") class="{{#if isLinkedCard}}linked-card{{/if}}" class="{{#if isLinkedBoard}}linked-board{{/if}}" class="minicard-{{colorClass}}") - if isMiniScreen + if isMiniScreenOrShowDesktopDragHandles .handle .fa.fa-arrows - unless isMiniScreen - if showDesktopDragHandles - .handle - .fa.fa-arrows if cover .minicard-cover(style="background-image: url('{{cover.url}}');") if labels diff --git a/client/components/cards/minicard.js b/client/components/cards/minicard.js index 9bf687ef9..d0c4929c4 100644 --- a/client/components/cards/minicard.js +++ b/client/components/cards/minicard.js @@ -75,16 +75,6 @@ BlazeComponent.extendComponent({ }).register('minicard'); Template.minicard.helpers({ - showDesktopDragHandles() { - currentUser = Meteor.user(); - if (currentUser) { - return (currentUser.profile || {}).showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - return true; - } else { - return false; - } - }, hiddenMinicardLabelText() { currentUser = Meteor.user(); if (currentUser) { diff --git a/client/components/lists/list.js b/client/components/lists/list.js index 1cfbaff9a..f5446275d 100644 --- a/client/components/lists/list.js +++ b/client/components/lists/list.js @@ -117,22 +117,11 @@ BlazeComponent.extendComponent({ }); this.autorun(() => { - let showDesktopDragHandles = false; - currentUser = Meteor.user(); - if (currentUser) { - showDesktopDragHandles = (currentUser.profile || {}) - .showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - showDesktopDragHandles = true; - } else { - showDesktopDragHandles = false; - } - - if (Utils.isMiniScreen() || showDesktopDragHandles) { + if (Utils.isMiniScreenOrShowDesktopDragHandles()) { $cards.sortable({ handle: '.handle', }); - } else if (!Utils.isMiniScreen() && !showDesktopDragHandles) { + } else if (!Utils.isMiniScreen() && !Utils.isShowDesktopDragHandles()) { $cards.sortable({ handle: '.minicard', }); @@ -178,19 +167,6 @@ BlazeComponent.extendComponent({ }, }).register('list'); -Template.list.helpers({ - showDesktopDragHandles() { - currentUser = Meteor.user(); - if (currentUser) { - return (currentUser.profile || {}).showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - return true; - } else { - return false; - } - }, -}); - Template.miniList.events({ 'click .js-select-list'() { const listId = this._id; diff --git a/client/components/lists/listHeader.jade b/client/components/lists/listHeader.jade index c01e9d616..866665308 100644 --- a/client/components/lists/listHeader.jade +++ b/client/components/lists/listHeader.jade @@ -44,7 +44,7 @@ template(name="listHeader") a.js-add-card.fa.fa-plus.list-header-plus-icon(title="{{_ 'add-card-to-top-of-list'}}") a.fa.fa-navicon.js-open-list-menu(title="{{_ 'listActionPopup-title'}}") if currentUser.isBoardAdmin - if showDesktopDragHandles + if isShowDesktopDragHandles a.list-header-handle.handle.fa.fa-arrows.js-list-handle template(name="editListTitleForm") diff --git a/client/components/lists/listHeader.js b/client/components/lists/listHeader.js index 91d6064cd..e9a8b2676 100644 --- a/client/components/lists/listHeader.js +++ b/client/components/lists/listHeader.js @@ -122,18 +122,7 @@ BlazeComponent.extendComponent({ Template.listHeader.helpers({ isBoardAdmin() { return Meteor.user().isBoardAdmin(); - }, - - showDesktopDragHandles() { - currentUser = Meteor.user(); - if (currentUser) { - return (currentUser.profile || {}).showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - return true; - } else { - return false; - } - }, + } }); Template.listActionPopup.helpers({ diff --git a/client/components/swimlanes/swimlaneHeader.jade b/client/components/swimlanes/swimlaneHeader.jade index 5319402c2..072b7ccee 100644 --- a/client/components/swimlanes/swimlaneHeader.jade +++ b/client/components/swimlanes/swimlaneHeader.jade @@ -26,7 +26,7 @@ template(name="swimlaneFixedHeader") a.fa.fa-plus.js-open-add-swimlane-menu.swimlane-header-plus-icon(title="{{_ 'add-swimlane'}}") a.fa.fa-navicon.js-open-swimlane-menu(title="{{_ 'swimlaneActionPopup-title'}}") unless isMiniScreen - if showDesktopDragHandles + if isShowDesktopDragHandles a.swimlane-header-handle.handle.fa.fa-arrows.js-swimlane-header-handle if isMiniScreen a.swimlane-header-miniscreen-handle.handle.fa.fa-arrows.js-swimlane-header-handle diff --git a/client/components/swimlanes/swimlaneHeader.js b/client/components/swimlanes/swimlaneHeader.js index 9d01ee34c..b941d46ed 100644 --- a/client/components/swimlanes/swimlaneHeader.js +++ b/client/components/swimlanes/swimlaneHeader.js @@ -28,19 +28,6 @@ BlazeComponent.extendComponent({ }, }).register('swimlaneHeader'); -Template.swimlaneHeader.helpers({ - showDesktopDragHandles() { - currentUser = Meteor.user(); - if (currentUser) { - return (currentUser.profile || {}).showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - return true; - } else { - return false; - } - }, -}); - Template.swimlaneFixedHeader.helpers({ isBoardAdmin() { return Meteor.user().isBoardAdmin(); diff --git a/client/components/swimlanes/swimlanes.js b/client/components/swimlanes/swimlanes.js index b6fe744b5..623bb857f 100644 --- a/client/components/swimlanes/swimlanes.js +++ b/client/components/swimlanes/swimlanes.js @@ -95,22 +95,11 @@ function initSortable(boardComponent, $listsDom) { //} boardComponent.autorun(() => { - let showDesktopDragHandles = false; - currentUser = Meteor.user(); - if (currentUser) { - showDesktopDragHandles = (currentUser.profile || {}) - .showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - showDesktopDragHandles = true; - } else { - showDesktopDragHandles = false; - } - - if (Utils.isMiniScreen() || showDesktopDragHandles) { + if (Utils.isMiniScreenOrShowDesktopDragHandles) { $listsDom.sortable({ handle: '.js-list-handle', }); - } else if (!Utils.isMiniScreen() && !showDesktopDragHandles) { + } else if (!Utils.isMiniScreen() && !Utils.isShowDesktopDragHandles()) { $listsDom.sortable({ handle: '.js-list-header', }); @@ -172,19 +161,8 @@ BlazeComponent.extendComponent({ // the user will legitimately expect to be able to select some text with // his mouse. - let showDesktopDragHandles = false; - currentUser = Meteor.user(); - if (currentUser) { - showDesktopDragHandles = (currentUser.profile || {}) - .showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - showDesktopDragHandles = true; - } else { - showDesktopDragHandles = false; - } - const noDragInside = ['a', 'input', 'textarea', 'p'].concat( - Utils.isMiniScreen() || showDesktopDragHandles + Utils.isMiniScreenOrShowDesktopDragHandles() ? ['.js-list-handle', '.js-swimlane-header-handle'] : ['.js-list-header'], ); @@ -264,16 +242,6 @@ BlazeComponent.extendComponent({ }).register('addListForm'); Template.swimlane.helpers({ - showDesktopDragHandles() { - currentUser = Meteor.user(); - if (currentUser) { - return (currentUser.profile || {}).showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - return true; - } else { - return false; - } - }, canSeeAddList() { return Meteor.user().isBoardAdmin(); /* diff --git a/client/components/users/userHeader.jade b/client/components/users/userHeader.jade index 98e8c36b9..d5fe14739 100644 --- a/client/components/users/userHeader.jade +++ b/client/components/users/userHeader.jade @@ -134,7 +134,7 @@ template(name="changeSettingsPopup") a.js-toggle-desktop-drag-handles i.fa.fa-arrows | {{_ 'show-desktop-drag-handles'}} - if showDesktopDragHandles + if isShowDesktopDragHandles i.fa.fa-check unless currentUser.isWorker li diff --git a/client/components/users/userHeader.js b/client/components/users/userHeader.js index 7088e4309..1270eff39 100644 --- a/client/components/users/userHeader.js +++ b/client/components/users/userHeader.js @@ -259,16 +259,6 @@ Template.changeLanguagePopup.events({ }); Template.changeSettingsPopup.helpers({ - showDesktopDragHandles() { - currentUser = Meteor.user(); - if (currentUser) { - return (currentUser.profile || {}).showDesktopDragHandles; - } else if (window.localStorage.getItem('showDesktopDragHandles')) { - return true; - } else { - return false; - } - }, hiddenSystemMessages() { currentUser = Meteor.user(); if (currentUser) { diff --git a/client/lib/utils.js b/client/lib/utils.js index f8f684325..3c1e79f93 100644 --- a/client/lib/utils.js +++ b/client/lib/utils.js @@ -248,6 +248,8 @@ Utils = { const currentUser = Meteor.user(); if (currentUser) { return (currentUser.profile || {}).showDesktopDragHandles; + } else if (window.localStorage.getItem('showDesktopDragHandles')) { + return true; } else { return false; }