Andreas/wekan
1
0
Fork 0
mirror of https://github.com/wekan/wekan.git synced 2025-12-16 15:30:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Refuse to delete a card as long as there is link to it

Browse source 
This fixes https://github.com/wekan/wekan/issues/2785.
This commit is contained in:
Marc Hartmayer 2020-04-30 01:03:37 +02:00
parent 2691f033cb
commit b740381a72
2 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

21
client/components/lists/listHeader.js
View file

@ -223,8 +223,25 @@ BlazeComponent.extendComponent({
Template.listMorePopup.events({
'click .js-delete': Popup.afterConfirm('listDelete', function() {
Popup.close();
this.allCards().map(card => Cards.remove(card._id));
Lists.remove(this._id);
// TODO how can we avoid the fetch call?
const allCards = this.allCards().fetch();
const allCardIds = _.pluck(allCards, '_id');
// it's okay if the linked cards are on the same list
if (
Cards.find({
$and: [
{ listId: { $ne: this._id } },
{ linkedId: { $in: allCardIds } },
],
}).count() === 0
) {
allCardIds.map(_id => Cards.remove(_id));
Lists.remove(this._id);
} else {
// TODO popup with a hint that the list cannot be deleted as there are
// linked cards. We can adapt the query above so we can list the linked
// cards.
}
Utils.goBoardId(this.boardId);
}),
});