From ac6491ea127215cb07ca490fc2cc1af7c3778e8f Mon Sep 17 00:00:00 2001 From: Maxime Quandalle Date: Sun, 3 Jan 2016 23:45:46 +0100 Subject: [PATCH] Remove unnecessary template name declaration This code was duplicate with the name we use to `register` the component. A update of blaze-component removed the need to duplicate this declaration. --- client/components/activities/activities.js | 4 ---- client/components/activities/comments.js | 4 ---- client/components/boards/boardArchive.js | 4 ---- client/components/boards/boardBody.js | 8 -------- client/components/boards/boardHeader.js | 16 ---------------- client/components/boards/boardsList.js | 4 ---- client/components/cards/cardDetails.js | 4 ---- client/components/cards/labels.js | 4 ---- client/components/import/import.js | 4 ---- client/components/lists/list.js | 4 ---- client/components/lists/listBody.js | 8 -------- client/components/lists/listHeader.js | 4 ---- client/components/sidebar/sidebar.js | 8 -------- client/components/sidebar/sidebarArchives.js | 4 ---- client/components/sidebar/sidebarFilters.js | 8 -------- client/components/users/userAvatar.js | 4 ---- 16 files changed, 92 deletions(-) diff --git a/client/components/activities/activities.js b/client/components/activities/activities.js index c1465b04b..f64173803 100644 --- a/client/components/activities/activities.js +++ b/client/components/activities/activities.js @@ -1,10 +1,6 @@ const activitiesPerPage = 20; BlazeComponent.extendComponent({ - template() { - return 'activities'; - }, - onCreated() { // XXX Should we use ReactiveNumber? this.page = new ReactiveVar(1); diff --git a/client/components/activities/comments.js b/client/components/activities/comments.js index 18bf9ef06..9b6aedd69 100644 --- a/client/components/activities/comments.js +++ b/client/components/activities/comments.js @@ -1,10 +1,6 @@ const commentFormIsOpen = new ReactiveVar(false); BlazeComponent.extendComponent({ - template() { - return 'commentForm'; - }, - onDestroyed() { commentFormIsOpen.set(false); }, diff --git a/client/components/boards/boardArchive.js b/client/components/boards/boardArchive.js index bd0de0a3f..aab1e2c6d 100644 --- a/client/components/boards/boardArchive.js +++ b/client/components/boards/boardArchive.js @@ -5,10 +5,6 @@ Template.boardListHeaderBar.events({ }); BlazeComponent.extendComponent({ - template() { - return 'archivedBoards'; - }, - onCreated() { this.subscribe('archivedBoards'); }, diff --git a/client/components/boards/boardBody.js b/client/components/boards/boardBody.js index 9c1625cd2..15268a6bb 100644 --- a/client/components/boards/boardBody.js +++ b/client/components/boards/boardBody.js @@ -1,10 +1,6 @@ const subManager = new SubsManager(); BlazeComponent.extendComponent({ - template() { - return 'board'; - }, - onCreated() { this.draggingActive = new ReactiveVar(false); this.showOverlay = new ReactiveVar(false); @@ -180,10 +176,6 @@ Template.boardBody.onRendered(function() { }); BlazeComponent.extendComponent({ - template() { - return 'addListForm'; - }, - // Proxy open() { this.childComponents('inlinedForm')[0].open(); diff --git a/client/components/boards/boardHeader.js b/client/components/boards/boardHeader.js index f8ccfba50..acf40f44a 100644 --- a/client/components/boards/boardHeader.js +++ b/client/components/boards/boardHeader.js @@ -41,10 +41,6 @@ Template.boardChangeTitlePopup.events({ }); BlazeComponent.extendComponent({ - template() { - return 'boardHeaderBar'; - }, - isStarred() { const boardId = Session.get('currentBoard'); const user = Meteor.user(); @@ -93,10 +89,6 @@ BlazeComponent.extendComponent({ }).register('boardHeaderBar'); BlazeComponent.extendComponent({ - template() { - return 'boardChangeColorPopup'; - }, - backgroundColors() { return Boards.simpleSchema()._schema.color.allowedValues; }, @@ -119,10 +111,6 @@ BlazeComponent.extendComponent({ }).register('boardChangeColorPopup'); BlazeComponent.extendComponent({ - template() { - return 'createBoardPopup'; - }, - onCreated() { this.visibilityMenuIsOpen = new ReactiveVar(false); this.visibility = new ReactiveVar('private'); @@ -170,10 +158,6 @@ BlazeComponent.extendComponent({ }).register('createBoardPopup'); BlazeComponent.extendComponent({ - template() { - return 'boardChangeVisibilityPopup'; - }, - visibilityCheck() { const currentBoard = Boards.findOne(Session.get('currentBoard')); return this.currentData() === currentBoard.permission; diff --git a/client/components/boards/boardsList.js b/client/components/boards/boardsList.js index 131adf9d3..e4bb050e9 100644 --- a/client/components/boards/boardsList.js +++ b/client/components/boards/boardsList.js @@ -1,8 +1,4 @@ BlazeComponent.extendComponent({ - template() { - return 'boardList'; - }, - boards() { return Boards.find({ archived: false, diff --git a/client/components/cards/cardDetails.js b/client/components/cards/cardDetails.js index f6cd41409..2b04adad6 100644 --- a/client/components/cards/cardDetails.js +++ b/client/components/cards/cardDetails.js @@ -1,8 +1,4 @@ BlazeComponent.extendComponent({ - template() { - return 'cardDetails'; - }, - mixins() { return [Mixins.InfiniteScrolling, Mixins.PerfectScrollbar]; }, diff --git a/client/components/cards/labels.js b/client/components/cards/labels.js index 4e61a0c6d..20d95bc61 100644 --- a/client/components/cards/labels.js +++ b/client/components/cards/labels.js @@ -4,10 +4,6 @@ Meteor.startup(() => { }); BlazeComponent.extendComponent({ - template() { - return 'formLabel'; - }, - onCreated() { this.currentColor = new ReactiveVar(this.data().color); }, diff --git a/client/components/import/import.js b/client/components/import/import.js index 63285e577..ec469a772 100644 --- a/client/components/import/import.js +++ b/client/components/import/import.js @@ -7,10 +7,6 @@ /// - getLabel(): i18n key for the text displayed in the popup, usually to /// explain how to get the data out of the source system. const ImportPopup = BlazeComponent.extendComponent({ - template() { - return 'importPopup'; - }, - jsonText() { return Session.get('import.text'); }, diff --git a/client/components/lists/list.js b/client/components/lists/list.js index e454cb480..e19097835 100644 --- a/client/components/lists/list.js +++ b/client/components/lists/list.js @@ -1,10 +1,6 @@ const { calculateIndex } = Utils; BlazeComponent.extendComponent({ - template() { - return 'list'; - }, - // Proxy openForm(options) { this.childComponents('listBody')[0].openForm(options); diff --git a/client/components/lists/listBody.js b/client/components/lists/listBody.js index c3a85614d..907c21571 100644 --- a/client/components/lists/listBody.js +++ b/client/components/lists/listBody.js @@ -1,8 +1,4 @@ BlazeComponent.extendComponent({ - template() { - return 'listBody'; - }, - mixins() { return [Mixins.PerfectScrollbar]; }, @@ -122,10 +118,6 @@ function toggleValueInReactiveArray(reactiveValue, value) { } BlazeComponent.extendComponent({ - template() { - return 'addCardForm'; - }, - onCreated() { this.labels = new ReactiveVar([]); this.members = new ReactiveVar([]); diff --git a/client/components/lists/listHeader.js b/client/components/lists/listHeader.js index e393dac1d..c9eaee124 100644 --- a/client/components/lists/listHeader.js +++ b/client/components/lists/listHeader.js @@ -1,8 +1,4 @@ BlazeComponent.extendComponent({ - template() { - return 'listHeader'; - }, - editTitle(evt) { evt.preventDefault(); const newTitle = this.childComponents('inlinedForm')[0].getValue().trim(); diff --git a/client/components/sidebar/sidebar.js b/client/components/sidebar/sidebar.js index e414c1f9f..0af32f8fe 100644 --- a/client/components/sidebar/sidebar.js +++ b/client/components/sidebar/sidebar.js @@ -9,10 +9,6 @@ const viewTitles = { }; BlazeComponent.extendComponent({ - template() { - return 'sidebar'; - }, - mixins() { return [Mixins.InfiniteScrolling, Mixins.PerfectScrollbar]; }, @@ -232,10 +228,6 @@ Template.membersWidget.onRendered(draggableMembersLabelsWidgets); Template.labelsWidget.onRendered(draggableMembersLabelsWidgets); BlazeComponent.extendComponent({ - template() { - return 'addMemberPopup'; - }, - onCreated() { this.error = new ReactiveVar(''); this.loading = new ReactiveVar(false); diff --git a/client/components/sidebar/sidebarArchives.js b/client/components/sidebar/sidebarArchives.js index 189702671..c8196f234 100644 --- a/client/components/sidebar/sidebarArchives.js +++ b/client/components/sidebar/sidebarArchives.js @@ -1,8 +1,4 @@ BlazeComponent.extendComponent({ - template() { - return 'archivesSidebar'; - }, - tabs() { return [ { name: TAPi18n.__('cards'), slug: 'cards' }, diff --git a/client/components/sidebar/sidebarFilters.js b/client/components/sidebar/sidebarFilters.js index ba4e4df94..0a57f02c3 100644 --- a/client/components/sidebar/sidebarFilters.js +++ b/client/components/sidebar/sidebarFilters.js @@ -1,8 +1,4 @@ BlazeComponent.extendComponent({ - template() { - return 'filterSidebar'; - }, - events() { return [{ 'click .js-toggle-label-filter'(evt) { @@ -37,10 +33,6 @@ function mutateSelectedCards(mutationName, ...args) { } BlazeComponent.extendComponent({ - template() { - return 'multiselectionSidebar'; - }, - mapSelection(kind, _id) { return Cards.find(MultiSelection.getMongoSelector()).map((card) => { const methodName = kind === 'label' ? 'hasLabel' : 'isAssigned'; diff --git a/client/components/users/userAvatar.js b/client/components/users/userAvatar.js index 1e531882a..1066c6328 100644 --- a/client/components/users/userAvatar.js +++ b/client/components/users/userAvatar.js @@ -52,10 +52,6 @@ Template.userAvatarInitials.helpers({ }); BlazeComponent.extendComponent({ - template() { - return 'changeAvatarPopup'; - }, - onCreated() { this.error = new ReactiveVar(''); },