Andreas/wekan
1
0
Fork 0
mirror of https://github.com/wekan/wekan.git synced 2025-12-17 16:00:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Delete user at REST API and Admin Panel/People/People. There is still bug of

Browse source 
leaving empty user avatars to boards: boards members, card members and assignees have
empty users. So it would be better to delete user from all boards before deleting user.

Thanks to darren-teo and xet7 !

Fixes #2716
This commit is contained in:
Lauri Ojansivu 2021-06-24 22:29:03 +03:00
parent 9122a339cb
commit 9e16a405d8
2 changed files with 14 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

17
client/components/settings/peopleBody.jade
View file

@ -571,15 +571,16 @@ template(name="settingsUserPopup")
a.impersonate-user a.impersonate-user
i.fa.fa-user i.fa.fa-user
| {{_ 'impersonate-user'}} | {{_ 'impersonate-user'}}
//hr hr
//li li
// form form
// label.hide.userId(type="text" value=user._id) label.hide.userId(type="text" value=user._id)
// div.buttonsContainer div.buttonsContainer
// input#deleteButton.card-details-red.right.wide(type="button" value="{{_ 'delete'}}") input#deleteButton.card-details-red.right.wide(type="button" value="{{_ 'delete'}}")
// Delete is not enabled yet, because it does leave empty user avatars // Delete is enabled, but there is still bug of leaving empty user avatars
// to boards: boards members, card members and assignees have // to boards: boards members, card members and assignees have
// empty users. See: // empty users. So it is better to remove user from all boards before removing user.
// See:
// - wekan/client/components/settings/peopleBody.jade deleteButton // - wekan/client/components/settings/peopleBody.jade deleteButton
// - wekan/client/components/settings/peopleBody.js deleteButton // - wekan/client/components/settings/peopleBody.js deleteButton
// - wekan/client/components/sidebar/sidebar.js Popup.afterConfirm('removeMember' // - wekan/client/components/sidebar/sidebar.js Popup.afterConfirm('removeMember'

8
models/users.js
View file

@ -2065,16 +2065,18 @@ if (Meteor.isServer) {
try { try {
Authentication.checkUserId(req.userId); Authentication.checkUserId(req.userId);
const id = req.params.userId; const id = req.params.userId;
// Delete is not enabled yet, because it does leave empty user avatars // Delete user is enabled, but is still has bug of leaving empty user avatars
// to boards: boards members, card members and assignees have // to boards: boards members, card members and assignees have
// empty users. See: // empty users. So it would be better to delete user from all boards before
// deleting user.
// See:
// - wekan/client/components/settings/peopleBody.jade deleteButton // - wekan/client/components/settings/peopleBody.jade deleteButton
// - wekan/client/components/settings/peopleBody.js deleteButton // - wekan/client/components/settings/peopleBody.js deleteButton
// - wekan/client/components/sidebar/sidebar.js Popup.afterConfirm('removeMember' // - wekan/client/components/sidebar/sidebar.js Popup.afterConfirm('removeMember'
// that does now remove member from board, card members and assignees correctly, // that does now remove member from board, card members and assignees correctly,
// but that should be used to remove user from all boards similarly // but that should be used to remove user from all boards similarly
// - wekan/models/users.js Delete is not enabled // - wekan/models/users.js Delete is not enabled
// Meteor.users.remove({ _id: id }); Meteor.users.remove({ _id: id });
JsonRoutes.sendResult(res, { JsonRoutes.sendResult(res, {
code: 200, code: 200,
data: { data: {