From 9cbef4ba4b2e0a12bee5884abf7f771132d04ecd Mon Sep 17 00:00:00 2001
From: Louis Orleans <louis@orleans.io>
Date: Sat, 20 Feb 2021 14:11:17 -0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=92=20fix=20warning=20from=20deepcode?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 models/customFields.js | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/models/customFields.js b/models/customFields.js
index cb69a761b..3996a3843 100644
--- a/models/customFields.js
+++ b/models/customFields.js
@@ -453,16 +453,18 @@ if (Meteor.isServer) {
     (req, res) => {
       Authentication.checkUserId(req.userId);
 
-      if (req.body.hasOwnProperty('items')) {
+      if (req.body.hasOwnProperty('items') && Array.isArray(req.body.items)) {
         CustomFields.direct.update(
           { _id: req.params.customFieldId },
           {
             $push: {
               'settings.dropdownItems': {
-                $each: req.body.items.map(name => ({
-                  _id: Random.id(6),
-                  name,
-                })),
+                $each: req.body.items
+                  .filter(name => typeof name === 'string')
+                  .map(name => ({
+                    _id: Random.id(6),
+                    name,
+                  })),
               },
             },
           },