Andreas/wekan
1
0
Fork 0
mirror of https://github.com/wekan/wekan.git synced 2025-12-16 23:40:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

models: make the REST API more uniform

Browse source 
All of the other REST API are in the form 'modelId' but a few ones in
boards.js and users.js.

Change it for a more uniform API.
This commit is contained in:
Benjamin Tissoires 2018-06-26 11:10:16 +02:00
parent 24f66c9f88
commit 9aa5584c9c
2 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
models/boards.js
View file

@ -823,9 +823,9 @@ if (Meteor.isServer) {
} }
}); });
JsonRoutes.add('GET', '/api/boards/:id', function (req, res) { JsonRoutes.add('GET', '/api/boards/:boardId', function (req, res) {
try { try {
const id = req.params.id; const id = req.params.boardId;
Authentication.checkBoardAccess(req.userId, id); Authentication.checkBoardAccess(req.userId, id);
JsonRoutes.sendResult(res, { JsonRoutes.sendResult(res, {
@ -878,10 +878,10 @@ if (Meteor.isServer) {
} }
}); });
JsonRoutes.add('DELETE', '/api/boards/:id', function (req, res) { JsonRoutes.add('DELETE', '/api/boards/:boardId', function (req, res) {
try { try {
Authentication.checkUserId(req.userId); Authentication.checkUserId(req.userId);
const id = req.params.id; const id = req.params.boardId;
Boards.remove({ _id: id }); Boards.remove({ _id: id });
JsonRoutes.sendResult(res, { JsonRoutes.sendResult(res, {
code: 200, code: 200,
@ -898,9 +898,9 @@ if (Meteor.isServer) {
} }
}); });
JsonRoutes.add('PUT', '/api/boards/:id/labels', function (req, res) { JsonRoutes.add('PUT', '/api/boards/:boardId/labels', function (req, res) {
Authentication.checkUserId(req.userId); Authentication.checkUserId(req.userId);
const id = req.params.id; const id = req.params.boardId;
try { try {
if (req.body.hasOwnProperty('label')) { if (req.body.hasOwnProperty('label')) {
const board = Boards.findOne({ _id: id }); const board = Boards.findOne({ _id: id });

12
models/users.js
View file

@ -713,10 +713,10 @@ if (Meteor.isServer) {
} }
}); });
JsonRoutes.add('GET', '/api/users/:id', function (req, res) { JsonRoutes.add('GET', '/api/users/:userId', function (req, res) {
try { try {
Authentication.checkUserId(req.userId); Authentication.checkUserId(req.userId);
const id = req.params.id; const id = req.params.userId;
JsonRoutes.sendResult(res, { JsonRoutes.sendResult(res, {
code: 200, code: 200,
data: Meteor.users.findOne({ _id: id }), data: Meteor.users.findOne({ _id: id }),
@ -730,10 +730,10 @@ if (Meteor.isServer) {
} }
}); });
JsonRoutes.add('PUT', '/api/users/:id', function (req, res) { JsonRoutes.add('PUT', '/api/users/:userId', function (req, res) {
try { try {
Authentication.checkUserId(req.userId); Authentication.checkUserId(req.userId);
const id = req.params.id; const id = req.params.userId;
const action = req.body.action; const action = req.body.action;
let data = Meteor.users.findOne({ _id: id }); let data = Meteor.users.findOne({ _id: id });
if (data !== undefined) { if (data !== undefined) {
@ -872,10 +872,10 @@ if (Meteor.isServer) {
} }
}); });
JsonRoutes.add('DELETE', '/api/users/:id', function (req, res) { JsonRoutes.add('DELETE', '/api/users/:userId', function (req, res) {
try { try {
Authentication.checkUserId(req.userId); Authentication.checkUserId(req.userId);
const id = req.params.id; const id = req.params.userId;
Meteor.users.remove({ _id: id }); Meteor.users.remove({ _id: id });
JsonRoutes.sendResult(res, { JsonRoutes.sendResult(res, {
code: 200, code: 200,