From 4ee88e026e86ab26757d46c9dadffa5005a7740f Mon Sep 17 00:00:00 2001 From: "Sam X. Chen" Date: Thu, 19 Sep 2019 15:16:48 -0400 Subject: [PATCH 1/4] Buxfixed: if username contains space, it will cause @ commment failed to send out email and other --- client/components/main/editor.js | 18 +++++++++---- models/activities.js | 46 ++++++++++++++++++-------------- 2 files changed, 39 insertions(+), 25 deletions(-) diff --git a/client/components/main/editor.js b/client/components/main/editor.js index b1725227c..39c03aa96 100755 --- a/client/components/main/editor.js +++ b/client/components/main/editor.js @@ -94,7 +94,13 @@ Template.editor.onRendered(() => { currentBoard .activeMembers() .map(member => { - const username = Users.findOne(member.userId).username; + const user = Users.findOne(member.userId); + if (user._id === Meteor.userId()) { + return null; + } + const value = user.username; + const username = + value && value.match(/\s+/) ? `"${value}"` : value; return username.includes(term) ? username : null; }) .filter(Boolean), @@ -120,9 +126,10 @@ Template.editor.onRendered(() => { ? [ ['view', ['fullscreen']], ['table', ['table']], - ['font', ['bold', 'underline']], - //['fontsize', ['fontsize']], + ['font', ['bold']], ['color', ['color']], + ['insert', ['video']], // iframe tag will be sanitized TODO if iframe[class=note-video-clip] can be added into safe list, insert video can be enabled + //['fontsize', ['fontsize']], ] : [ ['style', ['style']], @@ -345,11 +352,12 @@ Blaze.Template.registerHelper( } return member; }); - const mentionRegex = /\B@([\w.]*)/gi; + const mentionRegex = /\B@(?:(?:"([\w.\s]*)")|([\w.]+))/gi; // including space in username let currentMention; while ((currentMention = mentionRegex.exec(content)) !== null) { - const [fullMention, username] = currentMention; + const [fullMention, quoteduser, simple] = currentMention; + const username = quoteduser || simple; const knowedUser = _.findWhere(knowedUsers, { username }); if (!knowedUser) { continue; diff --git a/models/activities.js b/models/activities.js index dcabfbc23..a9c9768f1 100644 --- a/models/activities.js +++ b/models/activities.js @@ -180,28 +180,34 @@ if (Meteor.isServer) { const comment = activity.comment(); params.comment = comment.text; if (board) { - const atUser = /(?:^|>|\b|\s)@(\S+?)(?:\s|$|<|\b)/g; const comment = params.comment; - if (comment.match(atUser)) { - const commenter = params.user; - while (atUser.exec(comment)) { - const username = RegExp.$1; - if (commenter === username) { - // it's person at himself, ignore it? - continue; - } - const atUser = - Users.findOne(username) || Users.findOne({ username }); - if (atUser && atUser._id) { - const uid = atUser._id; - params.atUsername = username; - params.atEmails = atUser.emails; - if (board.hasMember(uid)) { - title = 'act-atUserComment'; - watchers = _.union(watchers, [uid]); - } - } + const knownUsers = board.members.map(member => { + const u = Users.findOne(member.userId); + if (u) { + member.username = u.username; + member.emails = u.emails; } + return member; + }); + const mentionRegex = /\B@(?:(?:"([\w.\s]*)")|([\w.]+))/gi; // including space in username + let currentMention; + while ((currentMention = mentionRegex.exec(comment)) !== null) { + /*eslint no-unused-vars: ["error", { "varsIgnorePattern": "[iI]gnored" }]*/ + const [ignored, quoteduser, simple] = currentMention; + const username = quoteduser || simple; + if (username === params.user) { + // ignore commenter mention himself? + continue; + } + const atUser = _.findWhere(knownUsers, { username }); + if (!atUser) { + continue; + } + const uid = atUser.userId; + params.atUsername = username; + params.atEmails = atUser.emails; + title = 'act-atUserComment'; + watchers = _.union(watchers, [uid]); } } params.commentId = comment._id; From a37723f8a48277a152e4ef1fa2a42e6bb986b3a9 Mon Sep 17 00:00:00 2001 From: "Sam X. Chen" Date: Sat, 21 Sep 2019 15:32:21 -0400 Subject: [PATCH 2/4] Fixing method in users.js didn't have check userId --- models/users.js | 1 + 1 file changed, 1 insertion(+) diff --git a/models/users.js b/models/users.js index ee53c7ab7..9147322ca 100644 --- a/models/users.js +++ b/models/users.js @@ -541,6 +541,7 @@ Users.mutations({ Meteor.methods({ setUsername(username, userId) { check(username, String); + check(userId, String); const nUsersWithUsername = Users.find({ username }).count(); if (nUsersWithUsername > 0) { throw new Meteor.Error('username-already-taken'); From 8d7714760c0e532d1f3d17d451dd91ba74e966e8 Mon Sep 17 00:00:00 2001 From: "Sam X. Chen" Date: Wed, 25 Sep 2019 11:26:46 -0400 Subject: [PATCH 3/4] BUG FIX: archived cards still sent out notification --- models/cards.js | 1 + 1 file changed, 1 insertion(+) diff --git a/models/cards.js b/models/cards.js index 1414f6d74..d30baaf10 100644 --- a/models/cards.js +++ b/models/cards.js @@ -1558,6 +1558,7 @@ function cardRemover(userId, doc) { const findDueCards = days => { const seekDue = ($from, $to, activityType) => { Cards.find({ + archived: false, dueAt: { $gte: $from, $lt: $to }, }).forEach(card => { const username = Users.findOne(card.userId).username; From d5cff1ec48bf9ab13a32576e7495ae54c3d2c0f7 Mon Sep 17 00:00:00 2001 From: "Sam X. Chen" Date: Wed, 25 Sep 2019 11:48:20 -0400 Subject: [PATCH 4/4] Add feature: differentiating new due time and modified due time --- i18n/en.i18n.json | 1 + models/activities.js | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/i18n/en.i18n.json b/i18n/en.i18n.json index 1adee4fc5..443043050 100644 --- a/i18n/en.i18n.json +++ b/i18n/en.i18n.json @@ -731,6 +731,7 @@ "almostdue": "current due time %s is approaching", "pastdue": "current due time %s is past", "duenow": "current due time %s is today", + "act-newDue": "__card__ has 1st due reminder [__board__]", "act-withDue": "__card__ due reminders [__board__]", "act-almostdue": "was reminding the current due (__timeValue__) of __card__ is approaching", "act-pastdue": "was reminding the current due (__timeValue__) of __card__ is past", diff --git a/models/activities.js b/models/activities.js index a9c9768f1..cb1dddafc 100644 --- a/models/activities.js +++ b/models/activities.js @@ -242,8 +242,8 @@ if (Meteor.isServer) { (!activity.timeKey || activity.timeKey === 'dueAt') && activity.timeValue ) { - // due time reminder - title = 'act-withDue'; + // due time reminder, if it doesn't have old value, it's a brand new set, need some differentiation + title = activity.timeOldValue ? 'act-withDue' : 'act-newDue'; } ['timeValue', 'timeOldValue'].forEach(key => { // copy time related keys & values to params