From 7b23c85117e97e9c83fb0e9a76b0f4d4fba24456 Mon Sep 17 00:00:00 2001 From: Nadav Tasher Date: Fri, 3 Jan 2025 17:15:40 +0200 Subject: [PATCH] Fix assignee toggling keyboard shortcut to only toggle current board members --- client/lib/keyboard.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/client/lib/keyboard.js b/client/lib/keyboard.js index 4513e03de..9faa163f7 100644 --- a/client/lib/keyboard.js +++ b/client/lib/keyboard.js @@ -190,21 +190,23 @@ Mousetrap.bind(_.range(1, 10).map(x => `ctrl+alt+${x}`), (evt, key) => { const memberIndex = parseInt(key.split("+").pop()) - 1; const currentBoard = Utils.getCurrentBoard(); - const boardMembers = currentBoard.memberUsers(); + const validBoardMembers = currentBoard.memberUsers().filter(member => member.isBoardMember()); - if (memberIndex >= boardMembers.length) + if (memberIndex >= validBoardMembers.length) return; + const memberId = validBoardMembers[memberIndex]._id; + if (MultiSelection.isActive()) { for (const cardId of MultiSelection.getSelectedCardIds()) - Cards.findOne(cardId).toggleAssignee(boardMembers[memberIndex]._id); + Cards.findOne(cardId).toggleAssignee(memberId); } else { const cardId = getSelectedCardId(); if (!cardId) return; - Cards.findOne(cardId).toggleAssignee(boardMembers[memberIndex]._id); + Cards.findOne(cardId).toggleAssignee(memberId); } });