Fixed issue with possible race condition, suggested by @mquandalle

This commit is contained in:
Kenton Hamaluik 2015-10-08 12:22:03 -06:00
parent e4c5d2cbe6
commit 77ca52d8c2

View file

@ -45,11 +45,9 @@ BlazeComponent.extendComponent({
let foundUserIds = []; // eslint-disable-line prefer-const let foundUserIds = []; // eslint-disable-line prefer-const
currentBoard.members.forEach((member) => { currentBoard.members.forEach((member) => {
const username = Users.findOne(member.userId).username; const username = Users.findOne(member.userId).username;
const nameNdx = title.indexOf(`@${username}`); if(title.indexOf(`@${username}`) !== -1) {
if(nameNdx !== -1) {
foundUserIds.push(member.userId); foundUserIds.push(member.userId);
title = title.substr(0, nameNdx) title = title.replace(`@${username}`, '');
+ title.substr(nameNdx + username.length + 1);
} }
}); });
@ -59,11 +57,9 @@ BlazeComponent.extendComponent({
currentBoard.labels.forEach((label) => { currentBoard.labels.forEach((label) => {
const labelName = (!label.name || label.name === '') const labelName = (!label.name || label.name === '')
? label.color : label.name; ? label.color : label.name;
const labelNdx = title.indexOf(`#${labelName}`); if(title.indexOf(`#${labelName}`) !== -1) {
if(labelNdx !== -1) {
foundLabelIds.push(label._id); foundLabelIds.push(label._id);
title = title.substr(0, labelNdx) title = title.replace(`#${labelName}`, '');
+ title.substr(labelNdx + labelName.length + 1);
} }
}); });