From 63596b1fbdeee85cb23ddeb48cf69722ff49dff5 Mon Sep 17 00:00:00 2001
From: omri zaher <omriza5@gmail.com>
Date: Fri, 19 Sep 2025 20:00:15 +0300
Subject: [PATCH] Refactor logging messages in e2e workflow and test files for
 improved clarity

---
 .github/workflows/e2e-testing.yml | 14 +++++++-------
 tests/auth/test_login.py          |  4 ++--
 tests/board/test_board.py         | 24 +-----------------------
 3 files changed, 10 insertions(+), 32 deletions(-)

diff --git a/.github/workflows/e2e-testing.yml b/.github/workflows/e2e-testing.yml
index 66128af51..904d27a9f 100644
--- a/.github/workflows/e2e-testing.yml
+++ b/.github/workflows/e2e-testing.yml
@@ -112,7 +112,7 @@ jobs:
             echo "⏳ Waiting for Wekan to start..."
             for i in {1..24}; do
               if curl -s http://localhost > /dev/null 2>&1; then
-                echo "✅ Wekan is responding!"
+                echo "Wekan is responding!"
                 break
               fi
               echo "Waiting... (attempt $i/24)"
@@ -120,7 +120,7 @@ jobs:
             done
 
             # Create user directly in database with the exact structure from browser
-            echo "👤 Creating test user directly in database..."
+            echo "Creating test user directly in database..."
             sudo docker exec wekan-db mongosh wekan --eval '
               // Remove existing user first
               db.users.deleteMany({username: "omriza5"});
@@ -167,11 +167,11 @@ jobs:
               });
 
               if (result.acknowledged) {
-                print("✅ User omriza5 created successfully");
+                print("User omriza5 created successfully");
               } else {
-                print("❌ Failed to create user");
+                print("Failed to create user");
               }
-            ' || echo "❌ Failed to execute MongoDB command"
+            ' || echo "Failed to execute MongoDB command"
 
             # Verify user was created
             echo "🔍 Verifying user creation..."
@@ -186,9 +186,9 @@ jobs:
 
             LOGIN_CODE=$(echo $LOGIN_RESPONSE | tr -d '\n' | sed -e 's/.*HTTPSTATUS://')
             if [[ "$LOGIN_CODE" == "200" ]]; then
-              echo "✅ Login test successful"
+              echo "Login test successful"
             else
-              echo "⚠️ Login test failed (Code: $LOGIN_CODE)"
+              echo "Login test failed (Code: $LOGIN_CODE)"
               echo "Response: $(echo $LOGIN_RESPONSE | sed -e 's/HTTPSTATUS:.*//g')"
             fi
 
diff --git a/tests/auth/test_login.py b/tests/auth/test_login.py
index 84838f070..aa2a09c20 100644
--- a/tests/auth/test_login.py
+++ b/tests/auth/test_login.py
@@ -25,7 +25,7 @@ class TestLogin:
 
         assert response.status_code == 200
         json_response = response.json()
-        print("Response JSON:", json_response)
+
         assert 'token' in json_response
         assert isinstance(json_response['token'], str)
         assert len(json_response['token']) > 0
@@ -44,7 +44,7 @@ class TestLogin:
 
       assert response.status_code in [400, 401, 404]
       json_response = response.json()
-      print("Response JSON:", json_response)
+
       assert 'error' in json_response
       assert json_response['error'] == 'not-found'
       assert 'reason' in json_response
diff --git a/tests/board/test_board.py b/tests/board/test_board.py
index 0c3f90edf..b12f00943 100644
--- a/tests/board/test_board.py
+++ b/tests/board/test_board.py
@@ -14,9 +14,7 @@ class TestBoard:
       }
 
       response = requests.post(f"{base_url}/users/login", data=login_data)
-      print(f"URL:{base_url}/users/login")
-      print(f"🔑 Login response status: {response.status_code}, body: {response.text}")
-    #   print("response_JSON:", response.json())
+
       if response.status_code == 200:
             json_response = response.json()
             if 'token' in json_response:
@@ -33,24 +31,6 @@ class TestBoard:
       response = requests.get(f"{base_url}")
       assert response.status_code == 200
 
-
-  def test_get_user_boards(self):
-      """Test getting information about boards of user"""
-      if not self.auth_token:
-          pytest.skip("No authentication token available")
-
-      response = requests.get(
-            f"{base_url}/api/users/{self.user_id}/boards",
-            headers={"Authorization": f"Bearer {self.auth_token}"}
-      )
-
-      assert response.status_code == 200
-
-        # Should return a list of boards
-      boards_data = response.json()
-      assert isinstance(boards_data, list), "Response should be a list of boards"
-      assert "title" in boards_data[0], "First board object should have a 'title' key"
-
   def test_create_board_minimal(self):
       """Test creating a board with minimal required fields"""
       if not self.auth_token:
@@ -196,7 +176,5 @@ class TestBoard:
             headers={"Authorization": f"Bearer {self.auth_token}"}
         )
 
-        print(f"📋 Get boards API status: {response.json()}")
-
         # Should work with authentication
         assert response.status_code in [200, 204]