From 5e3a9dc059b52df75f492339ad18bb6acc87b904 Mon Sep 17 00:00:00 2001 From: Martin Filser Date: Mon, 16 Jan 2023 23:00:10 +0100 Subject: [PATCH] Move every Meteor.user() to the ReactiveCache --- client/components/activities/activities.js | 8 +-- client/components/boards/boardArchive.js | 4 +- client/components/boards/boardBody.js | 13 ++--- client/components/boards/boardHeader.js | 21 +++---- client/components/boards/boardsList.js | 51 ++++++----------- client/components/cards/attachments.js | 2 +- client/components/cards/cardDetails.js | 34 +++++------ client/components/cards/checklists.js | 16 +++--- client/components/cards/minicard.js | 3 +- client/components/lists/list.js | 12 +--- client/components/lists/listBody.js | 9 +-- client/components/lists/listHeader.js | 15 ++--- client/components/main/dueCards.js | 3 +- client/components/main/layouts.js | 2 +- .../components/notifications/notification.js | 4 +- .../notifications/notificationsDrawer.js | 6 +- .../components/rules/actions/boardActions.js | 4 +- client/components/sidebar/sidebar.js | 22 ++++---- client/components/sidebar/sidebarArchives.js | 3 +- client/components/sidebar/sidebarFilters.js | 6 +- client/components/swimlanes/swimlaneHeader.js | 5 +- client/components/swimlanes/swimlanes.js | 24 +------- client/components/users/userAvatar.js | 12 +--- client/components/users/userHeader.js | 25 +++++---- client/config/blazeHelpers.js | 5 ++ client/lib/datepicker.js | 3 +- client/lib/dialogWithBoardSwimlaneList.js | 2 +- client/lib/filter.js | 3 +- client/lib/i18n.js | 5 +- client/lib/keyboard.js | 12 ++-- client/lib/utils.js | 14 ++--- models/boards.js | 12 ++-- models/integrations.js | 2 +- models/org.js | 12 ++-- models/settings.js | 2 +- models/swimlanes.js | 5 -- models/team.js | 12 ++-- models/users.js | 56 +++++++++---------- server/notifications/outgoing.js | 2 +- server/publications/cards.js | 5 +- server/publications/notifications.js | 4 +- server/statistics.js | 3 +- 42 files changed, 211 insertions(+), 252 deletions(-) diff --git a/client/components/activities/activities.js b/client/components/activities/activities.js index 2696c7851..6295b805e 100644 --- a/client/components/activities/activities.js +++ b/client/components/activities/activities.js @@ -25,7 +25,7 @@ BlazeComponent.extendComponent({ searchId = Session.get(`current${capitalizedMode}`); } const limit = this.page.get() * activitiesPerPage; - const user = Meteor.user(); + const user = ReactiveCache.getCurrentUser(); const hideSystem = user ? user.hasHiddenSystemMessages() : false; if (searchId === null) return; @@ -283,7 +283,7 @@ Template.activity.helpers({ Template.commentReactions.events({ 'click .reaction'(event) { - if (Meteor.user().isBoardMember()) { + if (ReactiveCache.getCurrentUser().isBoardMember()) { const codepoint = event.currentTarget.dataset['codepoint']; const commentId = Template.instance().data.commentId; const cardComment = CardComments.findOne({_id: commentId}); @@ -295,7 +295,7 @@ Template.commentReactions.events({ Template.addReactionPopup.events({ 'click .add-comment-reaction'(event) { - if (Meteor.user().isBoardMember()) { + if (ReactiveCache.getCurrentUser().isBoardMember()) { const codepoint = event.currentTarget.dataset['codepoint']; const commentId = Template.instance().data.commentId; const cardComment = CardComments.findOne({_id: commentId}); @@ -326,7 +326,7 @@ Template.addReactionPopup.helpers({ Template.commentReactions.helpers({ isSelected(userIds) { - return userIds.includes(Meteor.user()._id); + return Meteor.userId() && userIds.includes(Meteor.userId()); }, userNames(userIds) { return Users.find({_id: {$in: userIds}}) diff --git a/client/components/boards/boardArchive.js b/client/components/boards/boardArchive.js index aa1ee7eda..f269d1fdc 100644 --- a/client/components/boards/boardArchive.js +++ b/client/components/boards/boardArchive.js @@ -1,10 +1,12 @@ +import { ReactiveCache } from '/imports/reactiveCache'; + BlazeComponent.extendComponent({ onCreated() { this.subscribe('archivedBoards'); }, isBoardAdmin() { - return Meteor.user().isBoardAdmin(); + return ReactiveCache.getCurrentUser().isBoardAdmin(); }, archivedBoards() { diff --git a/client/components/boards/boardBody.js b/client/components/boards/boardBody.js index ad400ba0e..5be6e4519 100644 --- a/client/components/boards/boardBody.js +++ b/client/components/boards/boardBody.js @@ -205,11 +205,10 @@ BlazeComponent.extendComponent({ } // Disable drag-dropping if the current user is not a board member - //$swimlanesDom.sortable('option', 'disabled', !userIsMember()); $swimlanesDom.sortable( 'option', 'disabled', - !Meteor.user() || !Meteor.user().isBoardAdmin(), + !ReactiveCache.getCurrentUser()?.isBoardAdmin(), ); }); @@ -232,7 +231,7 @@ BlazeComponent.extendComponent({ }, isViewSwimlanes() { - currentUser = Meteor.user(); + const currentUser = ReactiveCache.getCurrentUser(); if (currentUser) { return (currentUser.profile || {}).boardView === 'board-view-swimlanes'; } else { @@ -243,7 +242,7 @@ BlazeComponent.extendComponent({ }, isViewLists() { - currentUser = Meteor.user(); + const currentUser = ReactiveCache.getCurrentUser(); if (currentUser) { return (currentUser.profile || {}).boardView === 'board-view-lists'; } else { @@ -252,7 +251,7 @@ BlazeComponent.extendComponent({ }, isViewCalendar() { - currentUser = Meteor.user(); + const currentUser = ReactiveCache.getCurrentUser(); if (currentUser) { return (currentUser.profile || {}).boardView === 'board-view-cal'; } else { @@ -418,7 +417,7 @@ BlazeComponent.extendComponent({ }, select: function(startDate) { const currentBoard = Utils.getCurrentBoard(); - const currentUser = Meteor.user(); + const currentUser = ReactiveCache.getCurrentUser(); const $modal = $(`