Don't send emails if missing smtp host

config/accounts.js

@@ -17,12 +17,17 @@ AccountsTemplates.addFields([{
   template: 'invitationCode',
 }]);
 
+let sendVerificationEmail = false;
+if (process.env.MAIL_URL) {
+  sendVerificationEmail = true;
+}
+
 AccountsTemplates.configure({
   defaultLayout: 'userFormsLayout',
   defaultContentRegion: 'content',
   confirmPassword: false,
   enablePasswordChange: true,
-  sendVerificationEmail: true,
+  sendVerificationEmail,
   showForgotPasswordLink: true,
   onLogoutHook() {
     const homePage = 'home';
@@ -69,4 +74,3 @@ if (Meteor.isServer) {
     };
   });
 }
-

models/settings.js

@@ -35,6 +35,9 @@ Settings.attachSchema(new SimpleSchema({
 }));
 Settings.helpers({
   mailUrl () {
+    if (!this.mailServer.host) {
+      return null;
+    }
     if (!this.mailServer.username && !this.mailServer.password) {
       return `smtp://${this.mailServer.host}:${this.mailServer.port}/`;
     }
@@ -69,7 +72,7 @@ if (Meteor.isServer) {
   });
   Settings.after.update((userId, doc, fieldNames) => {
     // assign new values to mail-from & MAIL_URL in environment
-    if (_.contains(fieldNames, 'mailServer')) {
+    if (_.contains(fieldNames, 'mailServer') && _.contains(fieldNames, 'host')) {
       if (!doc.mailServer.username && !doc.mailServer.password) {
         process.env.MAIL_URL = `smtp://${doc.mailServer.host}:${doc.mailServer.port}/`;
       } else {
@@ -97,12 +100,14 @@ if (Meteor.isServer) {
         url: FlowRouter.url('sign-up'),
       };
       const lang = author.getLanguage();
+      if (Settings.findOne().mailUrl()) {
         Email.send({
           to: icode.email,
           from: Accounts.emailTemplates.from,
           subject: TAPi18n.__('email-invite-register-subject', params, lang),
           text: TAPi18n.__('email-invite-register-text', params, lang),
         });
+      }
     } catch (e) {
       throw new Meteor.Error('email-fail', e.message);
     }

models/users.js

@@ -369,6 +369,7 @@ if (Meteor.isServer) {
       board.addMember(user._id);
       user.addInvite(boardId);
 
+      if (Settings.findOne().mailUrl()) {
         try {
           const params = {
             user: user.username,
@@ -386,7 +387,7 @@ if (Meteor.isServer) {
         } catch (e) {
           throw new Meteor.Error('email-fail', e.message);
         }
-
+      }
       return { username: user.username, email: user.emails[0].address };
     },
   });
@@ -502,4 +503,3 @@ if (Meteor.isServer) {
     }
   });
 }
-

server/notifications/email.js

@@ -26,6 +26,7 @@ Meteor.startup(() => {
       const text = texts.join('\n\n');
       user.clearEmailBuffer();
 
+      if (Settings.findOne().mailUrl()) {
         try {
           Email.send({
             to: user.emails[0].address.toLowerCase(),
@@ -36,6 +37,7 @@ Meteor.startup(() => {
         } catch (e) {
           return;
         }
+      }
     }, 30000);
   });
 });