From 5606414f8975fa0f75642d2e3a6b48c7559186f9 Mon Sep 17 00:00:00 2001 From: Lauri Ojansivu Date: Tue, 24 Dec 2024 19:41:56 +0200 Subject: [PATCH] Hide and disable Keyboard Shortcuts, because they make using Ctrl-C to copy etc impossible. Thanks to xet7 ! Fixes #5603, fixes #2423, fixes #1878, fixes #931 --- client/components/sidebar/sidebar.jade | 8 ++++---- client/components/sidebar/sidebar.js | 2 ++ client/lib/keyboard.js | 5 +++++ 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/client/components/sidebar/sidebar.jade b/client/components/sidebar/sidebar.jade index 65c002a47..31206299e 100644 --- a/client/components/sidebar/sidebar.jade +++ b/client/components/sidebar/sidebar.jade @@ -5,10 +5,10 @@ template(name="sidebar") // title="{{showTongueTitle}}") // i.fa.fa-navicon .sidebar-actions - .sidebar-shortcuts - a.board-header-btn.js-shortcuts(title="{{_ 'keyboard-shortcuts' }}") - i.fa.fa-keyboard-o - span {{_ 'keyboard-shortcuts' }} + //.sidebar-shortcuts + // a.board-header-btn.js-shortcuts(title="{{_ 'keyboard-shortcuts' }}") + // i.fa.fa-keyboard-o + // span {{_ 'keyboard-shortcuts' }} a.sidebar-xmark.js-close-sidebar ✕ .sidebar-content.js-board-sidebar-content //a.hide-btn.js-hide-sidebar diff --git a/client/components/sidebar/sidebar.js b/client/components/sidebar/sidebar.js index f7e8f2b2b..25dd1774f 100644 --- a/client/components/sidebar/sidebar.js +++ b/client/components/sidebar/sidebar.js @@ -123,9 +123,11 @@ BlazeComponent.extendComponent({ location.reload(); } }, +/* 'click .js-shortcuts'() { FlowRouter.go('shortcuts'); }, +*/ 'click .js-close-sidebar'() { Sidebar.toggle() }, diff --git a/client/lib/keyboard.js b/client/lib/keyboard.js index b84c1e494..c5fd98d7e 100644 --- a/client/lib/keyboard.js +++ b/client/lib/keyboard.js @@ -1,5 +1,6 @@ import { ReactiveCache } from '/imports/reactiveCache'; +/* // XXX There is no reason to define these shortcuts globally, they should be // attached to a template (most of them will go in the `board` template). @@ -255,8 +256,11 @@ Mousetrap.bind('n', evt => { evt.preventDefault(); } }); +*/ + Template.keyboardShortcuts.helpers({ +/* mapping: [ { keys: ['w'], @@ -319,4 +323,5 @@ Template.keyboardShortcuts.helpers({ action: 'remove-labels-multiselect' }, ], +*/ });