From 2055d916e956a435156717e4423199ea58756a93 Mon Sep 17 00:00:00 2001 From: Martin Filser Date: Wed, 27 Oct 2021 17:24:23 +0200 Subject: [PATCH 1/3] Labels/Drag handles on desktop view with drag handles were too long --- client/components/cards/labels.styl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/client/components/cards/labels.styl b/client/components/cards/labels.styl index 38aea559d..aa00a28b7 100644 --- a/client/components/cards/labels.styl +++ b/client/components/cards/labels.styl @@ -225,3 +225,6 @@ ul.edit-labels-pop-over span.fa.label-handle padding-right: 10px; + + span.fa.label-handle + .card-label + max-width: 180px From 94f8fb239348c621466046ce0e3c33238cfbe2b5 Mon Sep 17 00:00:00 2001 From: Martin Filser Date: Wed, 27 Oct 2021 17:26:16 +0200 Subject: [PATCH 2/3] Fix: Labels at desktop view with enabled drag handles were sortable --- client/components/cards/labels.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/components/cards/labels.js b/client/components/cards/labels.js index f84960fa4..1c11e3019 100644 --- a/client/components/cards/labels.js +++ b/client/components/cards/labels.js @@ -67,7 +67,7 @@ BlazeComponent.extendComponent({ // Disable drag-dropping if the current user is not a board member or is comment only this.autorun(() => { - if (Utils.isMiniScreen()) { + if (Utils.isMiniScreenOrShowDesktopDragHandles()) { $labels.sortable({ handle: '.label-handle', }); From e9c1b2b2c495bed349bb1cf44549b6ffaef631b6 Mon Sep 17 00:00:00 2001 From: Martin Filser Date: Wed, 27 Oct 2021 17:27:17 +0200 Subject: [PATCH 3/3] Fix: Labels on desktop view can be added/deleted again --- client/components/cards/labels.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/components/cards/labels.js b/client/components/cards/labels.js index 1c11e3019..4027076d7 100644 --- a/client/components/cards/labels.js +++ b/client/components/cards/labels.js @@ -79,7 +79,7 @@ BlazeComponent.extendComponent({ { 'click .js-select-label'(event) { const card = Utils.getCurrentCard(); - const labelId = this._id; + const labelId = this.currentData()._id; card.toggleLabel(labelId); event.preventDefault(); },