Andreas/wekan
1
0
Fork 0
mirror of https://github.com/wekan/wekan.git synced 2025-12-16 23:40:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Fix "PROPAGATE_OIDC_DATA" mechanism if "info.groups" is undefined

Browse source 
This may happen if no group information is shared via OAuth2/OIDC but synchronization of user data is intended by WeKan administration. Without the patch the following exception is raised:
Error in OAuth Server: groups is not iterable
This commit is contained in:
Tobias Wolf 2023-07-16 23:13:41 +02:00
parent 9370c1d472
commit 452e2e2408
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
packages/wekan-oidc/oidc_server.js
View file

@ -287,15 +287,16 @@ Meteor.methods({
check(info, Object); check(info, Object);
check(userId, String); check(userId, String);
var propagateOidcData = process.env.PROPAGATE_OIDC_DATA || false; var propagateOidcData = process.env.PROPAGATE_OIDC_DATA || false;
if (propagateOidcData) if (propagateOidcData) {
{
users= Meteor.users; users= Meteor.users;
user = users.findOne({'services.oidc.id': userId}); user = users.findOne({'services.oidc.id': userId});
if(user) if(user) {
{ //updates/creates Groups and user admin privileges accordingly if not undefined
//updates/creates Groups and user admin privileges accordingly if (info.groups) {
addGroupsWithAttributes(user, info.groups); addGroupsWithAttributes(user, info.groups);
}
if(info.email) addEmail(user, info.email); if(info.email) addEmail(user, info.email);
if(info.fullname) changeFullname(user, info.fullname); if(info.fullname) changeFullname(user, info.fullname);
if(info.username) changeUsername(user, info.username); if(info.username) changeUsername(user, info.username);