diff --git a/client/components/boards/boardsList.js b/client/components/boards/boardsList.js index 23a9ce8b2..69a29b3c2 100644 --- a/client/components/boards/boardsList.js +++ b/client/components/boards/boardsList.js @@ -151,8 +151,8 @@ BlazeComponent.extendComponent({ } const currUser = ReactiveCache.getCurrentUser(); - let orgIdsUserBelongs = currUser !== undefined && currUser.teams !== 'undefined' ? currUser.orgIdsUserBelongs() : ''; - if (orgIdsUserBelongs && orgIdsUserBelongs != '') { + let orgIdsUserBelongs = currUser?.orgIdsUserBelongs() || ''; + if (orgIdsUserBelongs) { let orgsIds = orgIdsUserBelongs.split(','); // for(let i = 0; i < orgsIds.length; i++){ // query.$and[2].$or.push({'orgs.orgId': orgsIds[i]}); @@ -162,8 +162,8 @@ BlazeComponent.extendComponent({ query.$and[2].$or.push({ 'orgs.orgId': { $in: orgsIds } }); } - let teamIdsUserBelongs = currUser !== undefined && currUser.teams !== 'undefined' ? currUser.teamIdsUserBelongs() : ''; - if (teamIdsUserBelongs && teamIdsUserBelongs != '') { + let teamIdsUserBelongs = currUser?.teamIdsUserBelongs() || ''; + if (teamIdsUserBelongs) { let teamsIds = teamIdsUserBelongs.split(','); // for(let i = 0; i < teamsIds.length; i++){ // query.$or[2].$or.push({'teams.teamId': teamsIds[i]}); @@ -199,15 +199,12 @@ BlazeComponent.extendComponent({ }, boardMembers(boardId) { - let boardMembers = []; /* Bug Board icons random dance https://github.com/wekan/wekan/issues/4214 const lists = ReactiveCache.getBoard(boardId) - let members = lists.members - members.forEach(member => { - boardMembers.push(member.userId); - }); - */ + const boardMembers = lists?.members.map(member => member.userId); return boardMembers; + */ + return []; }, isStarred() { diff --git a/models/users.js b/models/users.js index b6bf53793..4288111bc 100644 --- a/models/users.js +++ b/models/users.js @@ -687,14 +687,11 @@ Users.helpers({ return ''; }, orgIdsUserBelongs() { + let ret = ''; if (this.orgs) { - return this.orgs - .map(function (org) { - return org.orgId; - }) - .join(','); + ret = this.orgs.map(org => org.orgId).join(','); } - return ''; + return ret; }, teamsUserBelongs() { if (this.teams) { @@ -708,14 +705,11 @@ Users.helpers({ return ''; }, teamIdsUserBelongs() { + let ret = ''; if (this.teams) { - return this.teams - .map(function (team) { - return team.teamId; - }) - .join(','); + ret = this.teams.map(team => team.teamId).join(','); } - return ''; + return ret; }, boards() { return Boards.userBoards(this._id, null, {}, { sort: { sort: 1 } });