From 1a049e44991ccaff65abbcee5021b4cf939e8f17 Mon Sep 17 00:00:00 2001 From: Lauri Ojansivu Date: Tue, 19 Jan 2021 19:31:10 +0200 Subject: [PATCH] Fixed LDAP Group Filters not working in docker. Thanks to Sancretor ! Fixes wekan/wekan-ldap#86 --- packages/wekan-ldap/server/loginHandler.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/wekan-ldap/server/loginHandler.js b/packages/wekan-ldap/server/loginHandler.js index 79b3899a0..090ef9da3 100644 --- a/packages/wekan-ldap/server/loginHandler.js +++ b/packages/wekan-ldap/server/loginHandler.js @@ -56,17 +56,17 @@ Accounts.registerLoginHandler('ldap', function(loginRequest) { throw new Error('User not Found'); } - if (ldap.authSync(users[0].dn, loginRequest.ldapPass) === true) { - if (ldap.isUserInGroup(loginRequest.username, users[0])) { - ldapUser = users[0]; - } else { - throw new Error('User not in a valid group'); - } - } else { - log_info('Wrong password for', loginRequest.username); - } - } + if (ldap.isUserInGroup(loginRequest.username, users[0])) { + ldapUser = users[0]; + } else { + throw new Error('User not in a valid group'); + } + if (ldap.authSync(users[0].dn, loginRequest.ldapPass) !== true) { + ldapUser = null; + log_info('Wrong password for', loginRequest.username) + } + } } catch (error) { log_error(error);