From 79e61f6d640ece8908e6a2cc6ea8497577da68f5 Mon Sep 17 00:00:00 2001 From: Johannes Zellner Date: Thu, 28 Sep 2023 12:29:00 +0200 Subject: [PATCH 1/2] Fix regression which hides the password change form This came in via https://github.com/wekan/wekan/pull/5032/files as I wasn't aware the class name was reused. Unfortunately I couldn't find how to create an explicit new class name for only the password change form, so we show the form in code now. Fixes #5144 --- client/components/users/userHeader.js | 1 + 1 file changed, 1 insertion(+) diff --git a/client/components/users/userHeader.js b/client/components/users/userHeader.js index a4cc10b40..22fd808b4 100644 --- a/client/components/users/userHeader.js +++ b/client/components/users/userHeader.js @@ -248,6 +248,7 @@ Template.editProfilePopup.events({ // XXX For some reason the useraccounts autofocus isnt working in this case. // See https://github.com/meteor-useraccounts/core/issues/384 Template.changePasswordPopup.onRendered(function() { + $('.at-pwd-form').show(); this.find('#at-field-current_password').focus(); }); From 7ebdd1b68be281e0b24b25bf356e5c216990d24e Mon Sep 17 00:00:00 2001 From: Johannes Zellner Date: Thu, 28 Sep 2023 12:30:12 +0200 Subject: [PATCH 2/2] Do not close form for immediate visual feedback on password change --- config/accounts.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/config/accounts.js b/config/accounts.js index 07cb99321..cbfb9d4dd 100644 --- a/config/accounts.js +++ b/config/accounts.js @@ -126,10 +126,9 @@ AccountsTemplates.configure({ AccountsTemplates.configureRoute('changePwd', { redirect() { - // XXX We should emit a notification once we have a notification system. - // Currently the user has no indication that his modification has been - // applied. - Popup.back(); + // We should go back with the popup but we don't since user feedback about the change is within the popup only. + // Once we have a global feedback popup mechanism we can use that here and close with the following: + // Popup.back(); }, });