Move every Lists.findOne() to the ReactiveCache

client/components/swimlanes/swimlanes.js

@@ -1,7 +1,7 @@
 const { calculateIndex } = Utils;
 
 function currentListIsInThisSwimlane(swimlaneId) {
-  const currentList = Lists.findOne(Session.get('currentList'));
+  const currentList = Utils.getCurrentList();
   return (
     currentList &&
     (currentList.swimlaneId === swimlaneId || currentList.swimlaneId === '')

client/lib/dialogWithBoardSwimlaneListCard.js

@@ -1,3 +1,4 @@
+import { ReactiveCache } from '/imports/reactiveCache';
 import { DialogWithBoardSwimlaneList } from '/client/lib/dialogWithBoardSwimlaneList';
 
 export class DialogWithBoardSwimlaneListCard extends DialogWithBoardSwimlaneList {
@@ -22,7 +23,7 @@ export class DialogWithBoardSwimlaneListCard extends DialogWithBoardSwimlaneList
 
   /** returns all available cards of the current list */
   cards() {
-    const list = Lists.findOne(this.selectedListId.get());
+    const list = ReactiveCache.getList(this.selectedListId.get());
     let ret = [];
     if (list) {
       ret = list.cards(this.selectedSwimlaneId.get());

client/lib/multiSelection.js

@@ -8,8 +8,8 @@ function getCardsBetween(idA, idB) {
   function getListsStrictlyBetween(id1, id2) {
     return Lists.find({
       $and: [
-        { sort: { $gt: Lists.findOne(id1).sort } },
+        { sort: { $gt: ReactiveCache.getList(id1).sort } },
-        { sort: { $lt: Lists.findOne(id2).sort } },
+        { sort: { $lt: ReactiveCache.getList(id2).sort } },
       ],
       archived: false,
     }).map(pluckId);

models/activities.js

@@ -26,7 +26,7 @@ Activities.helpers({
     return Users.findOne(this.memberId);
   },
   list() {
-    return Lists.findOne(this.listId);
+    return ReactiveCache.getList(this.listId);
   },
   swimlane() {
     return Swimlanes.findOne(this.swimlaneId);
@@ -35,7 +35,7 @@ Activities.helpers({
     return Swimlanes.findOne(this.oldSwimlaneId);
   },
   oldList() {
-    return Lists.findOne(this.oldListId);
+    return ReactiveCache.getList(this.oldListId);
   },
   card() {
     return ReactiveCache.getCard(this.cardId);

models/boards.js

@@ -1176,7 +1176,7 @@ Boards.helpers({
   },
 
   getDefaultSubtasksList() {
-    return Lists.findOne(this.getDefaultSubtasksListId());
+    return ReactiveCache.getList(this.getDefaultSubtasksListId());
   },
 
   getDefaultDateSettingsListId() {
@@ -1194,7 +1194,7 @@ Boards.helpers({
   },
 
   getDefaultDateSettingsList() {
-    return Lists.findOne(this.getDefaultDateSettingsListId());
+    return ReactiveCache.getList(this.getDefaultDateSettingsListId());
   },
 
   getDefaultSwimline() {

models/lists.js

@@ -274,7 +274,7 @@ Lists.helpers({
   },
 
   getWipLimit(option) {
-    const list = Lists.findOne({ _id: this._id });
+    const list = ReactiveCache.getList(this._id);
     if (!list.wipLimit) {
       // Necessary check to avoid exceptions for the case where the doc doesn't have the wipLimit field yet set
       return 0;
@@ -389,12 +389,12 @@ Meteor.methods({
     if (limit === 0) {
       limit = 1;
     }
-    Lists.findOne({ _id: listId }).setWipLimit(limit);
+    ReactiveCache.getList(listId).setWipLimit(limit);
   },
 
   enableWipLimit(listId) {
     check(listId, String);
-    const list = Lists.findOne({ _id: listId });
+    const list = ReactiveCache.getList(listId);
     if (list.getWipLimit('value') === 0) {
       list.setWipLimit(1);
     }
@@ -403,7 +403,7 @@ Meteor.methods({
 
   enableSoftLimit(listId) {
     check(listId, String);
-    const list = Lists.findOne({ _id: listId });
+    const list = ReactiveCache.getList(listId);
     list.toggleSoftLimit(!list.getWipLimit('soft'));
   },
 

models/triggers.js

@@ -47,11 +47,11 @@ Triggers.helpers({
   },
 
   fromList() {
-    return Lists.findOne(this.fromId);
+    return ReactiveCache.getList(this.fromId);
   },
 
   toList() {
-    return Lists.findOne(this.toId);
+    return ReactiveCache.getList(this.toId);
   },
 
   findList(title) {

server/notifications/watch.js

@@ -15,7 +15,7 @@ Meteor.methods({
       if (!watchableObj) throw new Meteor.Error('error-board-doesNotExist');
       board = watchableObj;
     } else if (watchableType === 'list') {
-      watchableObj = Lists.findOne(id);
+      watchableObj = ReactiveCache.getList(id);
       if (!watchableObj) throw new Meteor.Error('error-list-doesNotExist');
       board = watchableObj.board();
     } else if (watchableType === 'card') {

server/rulesHelper.js

@@ -37,7 +37,7 @@ RulesHelper = {
       // in any [*] board
       let value = activity[field];
       if (field === 'oldListName') {
-        const oldList = Lists.findOne({ _id: activity.oldListId });
+        const oldList = ReactiveCache.getList(activity.oldListId);
         if (oldList) {
           value = oldList.title;
         }