Andreas/wekan
1
0
Fork 0
mirror of https://github.com/wekan/wekan.git synced 2025-12-16 15:30:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

list: make sure the spinner of infinite scrolling doesn't show on load

Browse source 
When loading a board on a high resolution screen, there is a chance there
is not enough cards displayed and the spinner is still there, spinning
forever.

Add an idle callback that checks if the spinner is still there, and while
it is there, extend the number of cards to show.

Fixes #2250
This commit is contained in:
Benjamin Tissoires 2019-03-26 15:54:53 +01:00
parent fb163a2493
commit 00376b43f8
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
client/components/lists/listBody.js
View file

@ -5,6 +5,7 @@ BlazeComponent.extendComponent({
onCreated() {
// for infinite scrolling
this.cardlimit = new ReactiveVar(InfiniteScrollIter);
this.spinnerShown = false;
},
onRendered() {
@ -19,9 +20,8 @@ BlazeComponent.extendComponent({
const observer = new IntersectionObserver((entries) => {
entries.forEach((entry) => {
if (entry.isIntersecting) {
this.cardlimit.set(this.cardlimit.get() + InfiniteScrollIter);
}
this.spinnerShown = entry.isIntersecting;
this.updateList();
});
}, options);
@ -29,6 +29,13 @@ BlazeComponent.extendComponent({
}
},
updateList() {
if (this.spinnerShown) {
this.cardlimit.set(this.cardlimit.get() + InfiniteScrollIter);
window.requestIdleCallback(() => this.updateList());
}
},
mixins() {
return [Mixins.PerfectScrollbar];
},