Andreas/watchtower
1
0
Fork 0
mirror of https://github.com/containrrr/watchtower.git synced 2025-09-22 05:40:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: use a more specific error type for no container info (#1115)

Browse source 
Co-authored-by: Jeremy L. Morris <jmorris@digitalocean.com>
This commit is contained in:
Jeremy L. Morris 2021-11-12 06:21:34 -05:00 • committed by GitHub
parent ac00e4844e
commit d9d6f794a1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pkg/container/container.go
View file

@ -285,7 +285,7 @@ func (c Container) VerifyConfiguration() error {
containerInfo := c.ContainerInfo() containerInfo := c.ContainerInfo()
if containerInfo == nil { if containerInfo == nil {
return errorInvalidConfig return errorNoContainerInfo
} }
containerConfig := containerInfo.Config containerConfig := containerInfo.Config

2
pkg/container/container_test.go
View file

@ -23,7 +23,7 @@ var _ = Describe("the container", func() {
c := mockContainerWithPortBindings() c := mockContainerWithPortBindings()
c.containerInfo = nil c.containerInfo = nil
err := c.VerifyConfiguration() err := c.VerifyConfiguration()
Expect(err).To(Equal(errorInvalidConfig)) Expect(err).To(Equal(errorNoContainerInfo))
}) })
}) })
When("verifying a container with no config", func() { When("verifying a container with no config", func() {

1
pkg/container/errors.go
View file

@ -3,5 +3,6 @@ package container
import "errors" import "errors"
var errorNoImageInfo = errors.New("no available image info") var errorNoImageInfo = errors.New("no available image info")
var errorNoContainerInfo = errors.New("no available container info")
var errorNoExposedPorts = errors.New("exposed ports does not match port bindings") var errorNoExposedPorts = errors.New("exposed ports does not match port bindings")
var errorInvalidConfig = errors.New("container configuration missing or invalid") var errorInvalidConfig = errors.New("container configuration missing or invalid")