Andreas/watchtower
1
0
Fork 0
mirror of https://github.com/containrrr/watchtower.git synced 2025-12-15 14:40:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Unsafe Command Expansion in build-tplprev.sh

Browse source 
The script uses `cd $(git rev-parse --show-toplevel)`, which fails if the path has spaces.

Therefore, replaced `cd $(command)` with `cd "$(command)"` to properly handle spaces.

After these changes. it prevents build failures due to incorrect path handling and improves error reporting too.
This commit is contained in:
Advait Patel 2025-02-20 01:11:18 -06:00
parent 76f9cea516
commit c1b1e569e8
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
scripts/build-tplprev.sh
View file

@ -1,7 +1,16 @@
#!/bin/bash
cd $(git rev-parse --show-toplevel)
# get the repo root directory safely
REPO_ROOT="$(git rev-parse --show-toplevel)"
cd "$REPO_ROOT" || { echo "Error: Failed to change directory"; exit 1; }
cp "$(go env GOROOT)/misc/wasm/wasm_exec.js" ./docs/assets/
GOARCH=wasm GOOS=js go build -o ./docs/assets/tplprev.wasm ./tplprev
# build webassembly binary
GOARCH=wasm GOOS=js go build -o ./docs/assets/tplprev.wasm ./tplprev
if [ $? -ne 0 ]; then
echo "Error: WASM build failed!"
exit 1
fi
echo "WASM build successful!"