Jyri-Petteri Paloposki
d4c9041ccd
More code style fixes
2021-01-06 03:47:35 +02:00
Jyri-Petteri Paloposki
371f8d5adf
Coding style fixes
2020-10-27 21:00:19 +02:00
Jyri-Petteri Paloposki
d8acf60049
Code style fixes
2020-10-10 05:14:24 +03:00
Jyri-Petteri Paloposki
d3ba80c84e
#2203 : Allow using REST API with token
2019-05-04 20:31:32 +03:00
Jyri-Petteri Paloposki
b9a80a385e
#2036 : Change empty XML responses to have the correct base element
2019-05-03 11:47:05 +03:00
Matt Rogers
7fe0cf271a
Access MIME types via hash lookup instead of constant
...
Use a constant to look up a mime type is deprecated.
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
Matt Rogers
506f3f991a
Convert render :nothing => true
to head :ok
...
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:06:38 -05:00
Matt Rogers
5805c511bb
Convert render :text
to render :body
...
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:03:35 -05:00
Matt Rogers
60ae4f6f5f
Convert before_filter
to before_action
...
`before_filter` has been removed in future versions of rails.
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 12:55:27 -05:00
Carsten Otto
ed3bca22a4
Remove 'project_hidden' state
...
Compute it using project/context state
Notable change:
todo.hidden? now also returns true if the todo is completed
2016-04-16 09:27:33 +02:00
Carsten Otto
d2931ea7f0
sort current projects by last_reviewed date
...
fixes #1960
2016-01-21 22:30:48 +01:00
Carsten Otto
33c814e1b9
use local variable where possible
2016-01-17 17:52:28 +01:00
Carsten Otto
a4ef5654e9
explicit loading does not seem to be necessary
2016-01-17 17:51:49 +01:00
Carsten Otto
dc6eed3956
remove instance variable for projects, not necessary
2016-01-17 17:50:04 +01:00
Carsten Otto
94f60ffba4
do not load contexts for review, not necessary
2016-01-17 17:43:31 +01:00
Dan Rice
dbd2aa71b3
Merge branch '2.3_branch'
2015-08-30 11:43:10 -04:00
Reinier Balt
ddd9c07d3b
Fasterer: Use &:symbol is faster
...
Calling argumentless methods within blocks is slower than using
symbol to proc.
2015-08-19 14:48:31 +02:00
Carsten Otto
1fa6a182c1
remove context if name is not set in update form
...
fixes #1839
2015-08-09 13:42:29 +02:00
Matt Rogers
bca2440ca0
Merge pull request #1857 from C-Otto/tracks-1852
...
Show meaningful numbers in badge for completed projects and recurring actions
2015-08-07 21:01:32 -04:00
Carsten Otto
2039ae05db
document code
...
This helps solving the TODO mentioned a few lines above
2015-06-15 09:46:47 +02:00
Carsten Otto
5ffaf98c7b
show 0-0 instead of 1-0 if no project/action exists
...
limit maximum to actual number of projects/actions
2015-05-14 12:53:24 +02:00
Carsten Otto
296b8135a1
make code of completed projects and completed recurring actions more similar
2015-05-13 23:46:35 +02:00
Matt Rogers
aa41e20e46
Remove trailing whitespace and tabs
2014-08-14 21:05:05 -05:00
Reinier Balt
bbf6cdf702
fix failing cucumber scenario's and update gems
2013-09-18 10:38:20 +02:00
Reinier Balt
e2eb31cfcc
Merge pull request #206 from mmozuras/refactor_unless_blanks_into_presents
...
Refactor unless blanks into presents
2013-09-13 06:08:16 -07:00
Mindaugas Mozūras
25e764b21a
Refactor "unless blank?" into "if present?"
2013-09-13 15:40:09 +03:00
Mindaugas Mozūras
962b4fa5c9
Use respond_to { |format| format.any } to reduce duplication
2013-09-13 14:58:28 +03:00
Reinier Balt
4a485558e2
Merge branch 'master' into rails4
...
Conflicts:
Gemfile.lock
config/routes.rb
2013-06-17 09:25:02 +02:00
Reinier Balt
0a57a68a87
Project and context view can now be grouped by context and project (using view menu)
2013-06-11 11:12:21 +02:00
Reinier Balt
671f64b419
move to strong_parameters of rails4.
2013-05-27 12:44:31 +02:00
Reinier Balt
8ffacca393
fix cucumber scenario's.
...
One still fails on Cookie overflow, but works testing by hand...
2013-05-13 17:13:26 +02:00
Reinier Balt
80974fb0d5
empty non-saved project caused rss builder to fail
2013-05-13 12:50:10 +02:00
Reinier Balt
ebff4cfc0c
start fixing deprecation warnings
2013-05-11 23:13:32 +02:00
Reinier Balt
cdfb65d529
remove duplication of all_done_todos and done_todos in project and context container
2013-05-11 10:38:34 +02:00
Reinier Balt
85fc82d494
refactor done todos view and tests
2013-03-18 12:36:40 +01:00
Reinier Balt
f22dfc1f9b
initial changes to add an option to select either context or project as grouping of todos on home or tag page
...
* new menu item in view menu
* js to toggle view
* store setting in cookie to keep de choice of view persistent
* refactor index and tag page of todos to look more alike
* refactor context and project partials to look more alike
2013-03-18 12:32:28 +01:00
Reinier Balt
ef91dd0c64
another set of dynamic finder migrations. All non-cucumber tests pass
2013-02-27 11:50:49 +01:00
Reinier Balt
3482af5072
fix #1393 by calculating todo count for hidden projects too
2013-02-20 20:08:15 +01:00
Matt Rogers
4d2f25ab20
Refactor the fetching of done todos
...
Move the get_done_today, get_done_this_week, and get_done_this month
methods into their own class in lib/tracks and use the new class in the
context, project, and todo controllers.
This removes the complexity from the application controller, silos it
off, and slightly reduces the complexity of the other controllers so
that they don't have to duplicate as much code.
The tradeoff here is that the code that was moved out into its own class
was also duplicated in the todos controller due to a different use case
that I didn't see before. This is still an improvement however and so
I'm ok with going back and tackling the extra complexity added to
TodoController at a later date.
2012-11-27 23:07:46 -06:00
Reinier Balt
23b92d853a
Merge pull request #84 from sukima/fix_projects_api_crash
...
Fix projects api crash
2012-07-11 06:36:51 -07:00
Reinier Balt
bd8498f39c
fix #1287 . Fix various small bugs and some small improvements
2012-06-29 16:48:30 +02:00
Reinier Balt
89f96da623
fix #1290 . Actionize and alphabetize did not work for hidden projects
2012-06-27 14:40:20 +02:00
Devin Weaver
e71d23555e
Fixes a crash when using the XML API
...
The use of "http://localhost/projects.xml " would crash with missing
method 'all' for object 'Array'
This is because the variable @projects did not need to use all in the
XML formatting since it was already assigned above and is now an array.
2012-06-07 15:55:26 -04:00
Devin Weaver
c2d627bb43
Removes redundent assignment of @new_project
2012-06-07 15:54:58 -04:00
Reinier Balt
436cc862d6
fix text feeds
2012-05-20 05:46:52 +02:00
Reinier Balt
5e477a4d25
first pass of all tests done
2012-05-18 15:33:47 +02:00
Reinier Balt
005723cb4f
get login, mobile and notes features passing
2012-05-12 13:37:36 +02:00
Reinier Balt
63175c115b
all non-cucumber tests are passing
2012-04-30 13:56:41 +02:00
Reinier Balt
13b58f3a10
all unit and functional tests are passing
2012-04-30 13:56:40 +02:00
Reinier Balt
96db48dd86
get project integrations and login controller tests running
2012-04-30 13:56:40 +02:00