Andreas/tracks
1
0
Fork 0
mirror of https://github.com/TracksApp/tracks.git synced 2025-12-25 19:48:48 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
3753 commits 32 branches 36 tags 32 MiB
Commit graph

652 commits

Author SHA1 Message Date
Matt Rogers
8bf0627d41
Merge pull request #2210 from ZeiP/bug/2032_api_filters 
#2032: Use context and project filters in API also when not requestin…
 2019-05-12 13:52:19 -05:00
Matt Rogers
996395cc80
Merge pull request #2207 from TracksApp/exists-instead-of-count 
Use exists? instead of count > 0
 2019-05-04 14:54:21 -05:00
Jyri-Petteri Paloposki
8c5edd2dcf #2032: Use context and project filters in API also when not requesting only done items 2019-05-04 22:47:39 +03:00
Jyri-Petteri Paloposki
d3ba80c84e #2203: Allow using REST API with token 2019-05-04 20:31:32 +03:00
Matt Rogers
a7d8b3c950
Use exists? instead of count > 0 2019-05-04 10:32:15 -05:00
Jyri-Petteri Paloposki
b9a80a385e #2036: Change empty XML responses to have the correct base element 2019-05-03 11:47:05 +03:00
Matt Rogers
d08608c755
Remove the query code from TodosController 
It has been completely replaced with our new query object
 2019-04-11 14:38:56 -05:00
Matt Rogers
df091c7ec5
Use the results of the new query object 
This confirms that we've successfully extracted the code and now we can
start removing the old code.
 2019-04-07 20:08:11 -05:00
Matt Rogers
eb7c34e973
Run both the new query and the old query 
Throw away the results of the new query for now. Now that we know it
will run without raising exceptions, we can replace the old query with
the new query.
 2019-04-07 20:04:28 -05:00
Matt Rogers
f2647e3f94
Remove deprecations printed out in the test suite 2018-11-20 19:57:02 -06:00
Matt Rogers
32d267d6cd
Remove private variable usage from models 
It seems that `@new_record_before_save` as an instance variable has been
present since around 2007 and it wasn't until Rails 5.1 that things were
changed in such a way to make this inaccessible now.
 2018-11-12 13:23:30 -06:00
Matt Rogers
6d81e14b41
Use a non deprecated method to collect errors 
Hash-based access to set an error is deprecated. Use
ActiveModel::Errors.add instead.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
 2018-11-03 15:12:27 -05:00
Matt Rogers
7fe0cf271a
Access MIME types via hash lookup instead of constant 
Use a constant to look up a mime type is deprecated.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
 2018-11-03 15:02:00 -05:00
Matt Rogers
b5faedb4ff
Use reload to reload AR models 
Passing a boolean to the model method will stop working in Rails 5.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
 2018-09-22 13:12:23 -05:00
Matt Rogers
506f3f991a
Convert render :nothing => true to head :ok 
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
 2018-09-22 13:06:38 -05:00
Matt Rogers
17f704a074
Convert after_filter to after_action 
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
 2018-09-22 13:04:46 -05:00
Matt Rogers
5805c511bb
Convert render :text to render :body 
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
 2018-09-22 13:03:35 -05:00
Matt Rogers
60ae4f6f5f
Convert before_filter to before_action 
`before_filter` has been removed in future versions of rails.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
 2018-09-22 12:55:27 -05:00
Dan Rice
1ba829e960 Merge branch '2.3_branch' 2016-10-15 13:13:02 -04:00
Matt Rogers
c2296b5b99 Use Arel to generate case insensitve tag searches 2016-08-25 23:10:40 -05:00
Carsten Otto
f26f72272b remove TODO from code, migrated to #2018 2016-05-29 23:03:58 +02:00
Carsten Otto
ed3bca22a4 Remove 'project_hidden' state 
Compute it using project/context state

Notable change:
todo.hidden? now also returns true if the todo is completed
 2016-04-16 09:27:33 +02:00
Dan Rice
0843b78d08 Clean up reference to check_for_deprecated_password_hash 
Ref #1733
 2016-02-28 17:58:03 -05:00
Jan-Yves Ruzicka
ccf13418f4 Extract rendering to helper method. Shift filename sanitization to controller. 2016-02-02 11:08:12 +00:00
Carsten Otto
d2931ea7f0 sort current projects by last_reviewed date 
fixes #1960
 2016-01-21 22:30:48 +01:00
Carsten Otto
33c814e1b9 use local variable where possible 2016-01-17 17:52:28 +01:00
Carsten Otto
a4ef5654e9 explicit loading does not seem to be necessary 2016-01-17 17:51:49 +01:00
Carsten Otto
dc6eed3956 remove instance variable for projects, not necessary 2016-01-17 17:50:04 +01:00
Carsten Otto
94f60ffba4 do not load contexts for review, not necessary 2016-01-17 17:43:31 +01:00
Matt Rogers
3468d1ec13 Merge branch '2.3_branch' 2015-12-08 20:14:33 -06:00
Matt Rogers
c4836672c8 Merge pull request #1909 from C-Otto/tracks-1881 
Activate successors on predecessor destroy
 2015-12-08 20:02:06 -06:00
Dan Rice
dbd2aa71b3 Merge branch '2.3_branch' 2015-08-30 11:43:10 -04:00
Matt Rogers
dd6b9f0359 Merge pull request #1917 from lrbalt/fix-content-type-attachment 
remove old hack to set content type to application/html
 2015-08-20 11:23:21 -05:00
Reinier Balt
5092b388fe Fasterer: Parallel assignment is slower 
Parallel assignment is slower than sequential assignment.
Only got the low hanging fruit. There are some functions that
have multiple return values. Fixing this needs more refactoring.
 2015-08-19 15:12:52 +02:00
Reinier Balt
9f81e1a5c3 fasterer: Use attr_reader for reading ivars. 2015-08-19 14:52:13 +02:00
Reinier Balt
0d224a5fe9 fasterer: hash#fetch with block is faster 
hash#fetch with block is faster than hash#fetch with
second parameter
 2015-08-19 14:49:52 +02:00
Reinier Balt
ddd9c07d3b Fasterer: Use &:symbol is faster 
Calling argumentless methods within blocks is slower than using
symbol to proc.
 2015-08-19 14:48:31 +02:00
Reinier Balt
f7f10b8a61 remove old hack to set content type to application/html 
This prevents attachments to be seen as something different than
html content. For example, message/rfc822 for email was being
replaced by application/html causing wrong application to be
started on the client.
 2015-08-19 14:27:26 +02:00
Carsten Otto
e0143cf435 move actual activation to model 
fixes #1881
 2015-08-09 13:47:17 +02:00
Carsten Otto
1fa6a182c1 remove context if name is not set in update form 
fixes #1839
 2015-08-09 13:42:29 +02:00
Matt Rogers
bb934b6474 Remove the Google Gadget Integration 
Google has discontinued the "Add any gadget by URL" Labs feature. Remove
the feature from the application.
 2015-08-07 21:31:00 -04:00
Matt Rogers
486204c1d7 Merge pull request #1888 from C-Otto/tracks-1882 
navigate back to note's project after deletion
 2015-08-07 21:05:21 -04:00
Matt Rogers
bca2440ca0 Merge pull request #1857 from C-Otto/tracks-1852 
Show meaningful numbers in badge for completed projects and recurring actions
 2015-08-07 21:01:32 -04:00
Matt Rogers
f393afb69f Merge branch '2.3_branch' 
This brings the master branch up to date with the 2.3 release branch
 2015-08-07 20:27:14 -04:00
Matt Rogers
258528460d Merge pull request #1873 from C-Otto/default-context-choice-2.3 
(2.3) in tag view, do not use more-or-less random context for the form
 2015-08-07 20:02:01 -04:00
Matt Rogers
1c0a70df75 Merge pull request #1903 from lrbalt/fix-test-errors 
Fix failing tests for non-UTC timezones
 2015-08-07 19:50:58 -04:00
Reinier Balt
f2c6c2d3af show attachment in view and make it downloadable 2015-08-05 16:05:56 +02:00
Reinier Balt
e58379e81f This fixes failing tests when the timezone is different than utc 
There were several problems:
* Time.now returns the systems time, not the users time
* fixtures do not translate dates from timezone to utc, but stores the
  date verbatim
* calling a controller will set the timezone to the preference of the
  current_user. So it could be changed while you do not realize this. I
  fixed the failing test, but problems could be elsewhere
 2015-08-05 11:50:33 +02:00
Carsten Otto
2039ae05db document code 
This helps solving the TODO mentioned a few lines above
 2015-06-15 09:46:47 +02:00
Dan Rice
8dd4970b0c Merge branch '2.3_branch' 2015-06-14 18:20:08 -04:00