Commit graph

1544 commits

Author SHA1 Message Date
Matt Rogers
11b9081064
Use !exists? instead of empty?
`exists?` issues a better SQL query than `empty?`
2019-05-04 15:16:36 -05:00
Matt Rogers
996395cc80
Merge pull request #2207 from TracksApp/exists-instead-of-count
Use exists? instead of count > 0
2019-05-04 14:54:21 -05:00
Matt Rogers
2c627be0cc
Merge pull request #2208 from ZeiP/feature/2203_api_token
#2203: Allow using REST API with token
2019-05-04 14:49:24 -05:00
Jyri-Petteri Paloposki
16ca18e4f5 #2034: Change the REST API documentation to point to the existing done tasks API 2019-05-04 20:35:38 +03:00
Jyri-Petteri Paloposki
d3ba80c84e #2203: Allow using REST API with token 2019-05-04 20:31:32 +03:00
Matt Rogers
a7d8b3c950
Use exists? instead of count > 0 2019-05-04 10:32:15 -05:00
Jyri-Petteri Paloposki
b9a80a385e #2036: Change empty XML responses to have the correct base element 2019-05-03 11:47:05 +03:00
Matt Rogers
d08608c755
Remove the query code from TodosController
It has been completely replaced with our new query object
2019-04-11 14:38:56 -05:00
Matt Rogers
63ac90ebb2
Convert to using symbols everywhere 2019-04-11 11:28:43 -05:00
Matt Rogers
fc17a03bc0
Add tests for the new object and fix a bug
Each of the individual query chunks has their own test, in addition to a
test for the full combination of parameters that could influence a
query.

There is also a bugfix for the tag query in here, since I want, as much
as possible, to have passing tests on every commit.
2019-04-11 09:53:53 -05:00
Matt Rogers
df091c7ec5
Use the results of the new query object
This confirms that we've successfully extracted the code and now we can
start removing the old code.
2019-04-07 20:08:11 -05:00
Matt Rogers
eb7c34e973
Run both the new query and the old query
Throw away the results of the new query for now. Now that we know it
will run without raising exceptions, we can replace the old query with
the new query.
2019-04-07 20:04:28 -05:00
Matt Rogers
ec1a4d78ba
Temporarily add the sanitize helper
This is so we can keep the tests passing by fixing a NoMethodError when
attempting to run both the new query object and the existing code at the
same time.
2019-04-07 20:01:22 -05:00
Matt Rogers
9de975f8eb
Extract a query object for not done todos 2019-04-07 19:59:01 -05:00
Matt Rogers
f2647e3f94
Remove deprecations printed out in the test suite 2018-11-20 19:57:02 -06:00
Matt Rogers
32d267d6cd
Remove private variable usage from models
It seems that `@new_record_before_save` as an instance variable has been
present since around 2007 and it wasn't until Rails 5.1 that things were
changed in such a way to make this inaccessible now.
2018-11-12 13:23:30 -06:00
Matt Rogers
78742d15b8
Remove rendering of the charts
There's something wrong with the swf_fu gem. It's not worth it to fix a
gem that hasn't seen any activity in six years and is using outdated
flash technology in the first place.
2018-11-12 13:19:49 -06:00
Matt Rogers
c3a13bca16
Fix the undefined reference to Staleness
Not sure what's going on with Rails' autoloading here, so fix it the
ruby way by using plain ol' `require`
2018-11-12 08:55:42 -06:00
Matt Rogers
0e21d64890
Convert to ApplicationRecord
Rails 5 requires the use of this superclass for all database backed
model objects now.
2018-11-03 15:57:14 -05:00
Matt Rogers
6d81e14b41
Use a non deprecated method to collect errors
Hash-based access to set an error is deprecated. Use
ActiveModel::Errors.add instead.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:12:27 -05:00
Matt Rogers
7fe0cf271a
Access MIME types via hash lookup instead of constant
Use a constant to look up a mime type is deprecated.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-11-03 15:02:00 -05:00
Matt Rogers
6e70fcbe5e
Update how the sorting is done in the User model
Use the `sort_by` method to do the sorting rather than converting to an
array and then calling `sort`

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-10-27 11:27:22 -05:00
Matt Rogers
cf6f9de377
Merge pull request #2115 from hewo/feature_search_in_navbar
Feature search in navbar
2018-09-23 13:55:26 -05:00
Matt Rogers
b5faedb4ff
Use reload to reload AR models
Passing a boolean to the model method will stop working in Rails 5.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:12:23 -05:00
Matt Rogers
506f3f991a
Convert render :nothing => true to head :ok
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:06:38 -05:00
Matt Rogers
17f704a074
Convert after_filter to after_action
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:04:46 -05:00
Matt Rogers
5805c511bb
Convert render :text to render :body
Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 13:03:35 -05:00
Matt Rogers
60ae4f6f5f
Convert before_filter to before_action
`before_filter` has been removed in future versions of rails.

Co-Authored-By: Dan Rice <dnrce@users.noreply.github.com>
2018-09-22 12:55:27 -05:00
Heiner Wohner
3786d12e5a removes bootstrap css class from main view 2018-09-03 13:30:48 +02:00
Heiner Wohner
5117ec7d99 add searchbar to navbar 2018-09-03 12:39:05 +02:00
ericmoon
6dcaa76f09 cucumber removal 2018-07-24 12:34:55 -07:00
Matt Rogers
a65ab48b9f
Merge pull request #2096 from RyanTruran/origin
A more rational way to load the text input with the previous names
2018-01-03 09:31:36 -06:00
Ryan Truran
db7603f799 A more rational way to decode the html entities in editable
a more rational way to handle edit fields

revert to previous

add html_safe
2017-12-28 10:01:54 -06:00
Matt Rogers
500892e1a4 Fix the top 10 longest running projects list
Sorting by running time without a reverse takes the shortest running
projects.
2017-06-13 17:12:15 -05:00
Carsten Otto
b7bada0791 reorder buttons for recurring todos to make the order uniform
fixes #2069
2017-03-18 14:42:34 +01:00
Carsten Otto
ccac45b377 fix typo 2017-03-05 13:56:36 +01:00
Carsten Otto
238b2fd670 add missing space
bug introduced in c46e5a9e1d

fixes #2063
2017-02-28 22:16:48 +01:00
Dan Rice
55c5d07aff Limit swf_fu to the stats page
Fixes #2061
2017-02-12 15:27:00 -05:00
Dan Rice
1ba829e960 Merge branch '2.3_branch' 2016-10-15 13:13:02 -04:00
Matt Rogers
e01872d515 Merge pull request #2016 from C-Otto/fix-feeds-2.3
use @not_done_todos for feeds
2016-08-27 10:12:59 -05:00
Matt Rogers
c2296b5b99 Use Arel to generate case insensitve tag searches 2016-08-25 23:10:40 -05:00
Carsten Otto
a2726de78c fix typo 2016-07-19 19:10:15 +02:00
Dan Rice
5a5d293b80 Fix navbar link title of "Recurring Todos" 2016-06-25 20:16:22 -04:00
Dan Rice
23a22413f5 Load jquery-ui-rails CSS via "require" instead of "import"
Fixes #2024 and #2025
2016-06-25 16:55:17 -04:00
Matt Rogers
7748253388 Merge pull request #1910 from dnrce/rails42
Upgrade to Rails 4.2
2016-06-14 19:27:18 -05:00
Robin Dickson
67f33b3e39 Remove JS for search input autofocus
Previously replaced by HTML5 autofocus.
2016-06-06 16:28:14 +01:00
Robin Dickson
9dc698e775 Convert search page to use bootstrap 2016-06-06 11:23:45 +01:00
Carsten Otto
f26f72272b remove TODO from code, migrated to #2018 2016-05-29 23:03:58 +02:00
Carsten Otto
6bc9151400 use @not_done_todos for feeds
fixes #1726

the name @not_done_todos is wrong and should be replaced in a dedicated fix
2016-05-29 22:59:42 +02:00
Dan Rice
d7d86446c0 Upgrade to Rails 4.2
* Update boilerplate with `bin/rake rails:upgrade`
* Use test instead of test:all rake task
* Change stylesheet extensions from .css.scss to .scss
* Update docs to use localhost instead of 0.0.0.0 because Rails 4.2
  no longer listens on all addresses by default.
2016-05-22 21:58:52 -04:00